Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Thu, 28 Sep 2023 15:49:00 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Peter Gonda <pgonda@google.com>,
        Dan Williams <dan.j.williams@intel.com>
CC:     <linux-coco@lists.linux.dev>,
        Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        Erdem Aktas <erdemaktas@google.com>, <peterz@infradead.org>,
        <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
        <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v4 6/6] virt: tdx-guest: Add Quote generation support
 using TSM_REPORTS
Message-ID: <651602dc4c6e3_91c1e2947f@dwillia2-xfh.jf.intel.com.notmuch>
References: <169570181657.596431.6178773442587231200.stgit@dwillia2-xfh.jf.intel.com>
 <169570185411.596431.3153227201984845022.stgit@dwillia2-xfh.jf.intel.com>
 <CAMkAt6r2VPPMZ__SQfJse8qWsUyYW3AgYbOUVM0S_Vtk=KvkxQ@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAMkAt6r2VPPMZ__SQfJse8qWsUyYW3AgYbOUVM0S_Vtk=KvkxQ@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YjJHb1E4MkpUTUJrYkJCa2ZmL0RnMGlIN3VocEV2UUxHV1NsNmhHQW5CY25w?=
 =?utf-8?B?MlJacVZ1MDQvWTlYRHFQMVZ6TFNMM21NWC8rQStEaVoyR29EK1A2czNoa3Rp?=
 =?utf-8?B?M3RJVUxONVNyWXBGbmpLNjFZSVhlaVFOSlU3bVlmY2lJOE5reXoycE1LcjlI?=
 =?utf-8?B?T2JEL3ZVTGZwSFZyM3U3TVlDR1dSeEMralVBRldMZUllRmtXZlZORFRkZ2hi?=
 =?utf-8?B?aDNvb3pWaUNLOHFPa0VJc0pPaDh5aTZSTmh4QlhvVCtVOWxzRDBpSTh1bzQ5?=
 =?utf-8?B?VVFNQVhZelhST0tvdFNuQkxQUzlibXJzbmJGckxDNjBEWEUrWVVKN0lNSjBt?=
 =?utf-8?B?UWxkZE5rbTRXVFdDZHdIL1c5ODluU01nOTVuN0RXUG5tNE5ORTVBT1JQSlFx?=
 =?utf-8?B?SGFKdXNuVjZneW9uTWZiMzZMeWdVVVJGZFJ2R2R6TFBBSG9OWVRTQjdoV3JF?=
 =?utf-8?B?VUdzTEFnd1VyU0VmVzVnd2ZIem5lUFJ0dHc2dm5YSkVJK3NpYytMSHdYZVZt?=
 =?utf-8?B?SngxSEhIc3I3a240eFRSNFEzZFUzajF4WURZZ2dWbkNWbjhWbmw2cWluZTMy?=
 =?utf-8?B?MDd3c3ViSDQ2U2llWlNMRXgreXNhYk9ldnpTdTB6UXVZWGlVUlh0bnkrZTZH?=
 =?utf-8?B?TFB2TGxka3V0SU5UOFRON3VBaGtPQjJISW41U2RMWkNDYW5wUzBiRWxqcEFa?=
 =?utf-8?B?c3FZSlVRcnZ4eWVOMk1ldWhXQTAvYWo1MkdHVFZ4eTZTZGJtTnJ3Ynp5SUZL?=
 =?utf-8?B?OWo5OUZFYzdVZWVQd3RPYW03VFRmUFBrRCtoU2hNdlpZWnJ2bmVRS3U5eVd4?=
 =?utf-8?B?aXdTUGR3VHB5MjRQM1huaFVVeVp4OGIybzl0bFF2N2E2ajNOQ2MyVkFuc080?=
 =?utf-8?B?SXpUa3hKMUpCZndoZXNxUGRhSGFlVWc4OGVhOFdHTnRVZWR6QnRWeDlTVW14?=
 =?utf-8?B?QzdRK09nRm1JcFNweFlRS1hHb1Q2Q3o3Y0lRK2t3THRFVzVudFN1YkNZWkNo?=
 =?utf-8?B?Zi9aOXNtN2VpRmJNNDViZGtnRDQxUjdqSDhsamNSNTJRTkdyREoyT3krcGhS?=
 =?utf-8?B?SWJ2RkJuK3g0L1VUVVNpY1lIWkxvWkVkWWE2Q050MHRldVZCZUlwaVYvZ0Yx?=
 =?utf-8?B?QmFpaU9RWmNYRWlFY3RhaTZMMzNZcHIvRVJVak1Kdmg3cTM2TWcveGgyN2VU?=
 =?utf-8?B?Rm11WjdzWjNaYzkvMTFNQ2pVRHUyWTFlWElDL2NqVWVKUGxCeDlVNFZEeVNk?=
 =?utf-8?B?SzhGQlRmVUQ3RHZ2SUJ0Y0R5Nk1LcFBqUVRRaWNQc0pOQmFWcXh3N0p5WXVE?=
 =?utf-8?B?d3pLWmNYWlVhSStSbHdBTlBRbCs5Y0x5eXNoc1UvNHk3bHdWaG1JQUxoSVdy?=
 =?utf-8?B?cnZnUTlxZHNGNEUvSFFvZ3BWclJjVkFsWkc4WFRJU1g5ZmRKaHpuRzhlRnl6?=
 =?utf-8?B?RVZRRHpRNU5oaUpoL3FDWk5jL3JUcks1bzhvbzhLQmFDQ3FxUytmOHl6RFZ3?=
 =?utf-8?B?Y3FrSVFCVW10NmhKVGUvVDB4WUZSK2hGdFNId1RzdjFieGhwZVVuNVdNUWhR?=
 =?utf-8?B?MkJ1OGZyQkQ2UFQzanRkRHVEY3psVTZjRkFsSkI1SXNpN0x2UEpYNXJybWVY?=
 =?utf-8?B?cTl0Unl1Zk1JSWlwMjRDdXFzQnc0bE5QSDB1QTA4VGhmbWo1MVkvam9TY3Nr?=
 =?utf-8?B?TCtwbk1QeGloY1JidnpaSXNSaEZ2d3B6aWduS2ZVYUluSEJHKzdzdCt6K09C?=
 =?utf-8?B?VWdSUTA2a2lGYURYeDlaNWVvUUlqYjEwN28vRld4MklXSXZ4TVRPTFZ4bGY2?=
 =?utf-8?B?MFJHM25ZOTBYMlpXYmhEZ1V5Vkl2K3o3TnFtbnpydDhzcjh0bkpsMEdaQnBl?=
 =?utf-8?B?TXYwUll4aXplc0s4RmZzOFVxQ2FtdzhLQXhZdU9tUi92TDJnK1RCMEJtUHVx?=
 =?utf-8?B?cnExdUhwY0IxWGpXaXF6WHV2NmtUV3JabXpUMG1xUGRwcktxZEVCcUduZGYz?=
 =?utf-8?B?OFFvL3pSZmkyWkNocldKcmVvNlJ5clZKUWxuMGw3VnR0UHl5T3B0WXdSdnRj?=
 =?utf-8?B?ZjdZRlY1VkNqaWVheVJIb1BqcXNiY3lKTDN1OWF0aGZyMXMvbkxhZ2V0SkdC?=
 =?utf-8?B?U0RZNUdMekF0bFRvVFJ6aStWa3QrRG45WGx3cyt3Zjh2bDIvejFxUTdvODJm?=
 =?utf-8?B?b1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7be1be44-28b6-44c9-053d-08dbc0751ced
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2023 22:49:03.7713
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ivWvIu5zJdn8Vkd/IyqSdleTOY0q/97VLBmIOzAWQfr2cK8KUATGownT4s+hy/33uZYYFBct8mDZRHU4+whsYW37AUHEEkqaLPdgEHTCd6Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8578
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 28 Sep 2023 15:49:41 -0700 (PDT)

Peter Gonda wrote:
> On Mon, Sep 25, 2023 at 10:17 PM Dan Williams <dan.j.williams@intel.com> wrote:
> >
> > From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> >
> > In TDX guest, the attestation process is used to verify the TDX guest
> > trustworthiness to other entities before provisioning secrets to the
> > guest. The first step in the attestation process is TDREPORT
> > generation, which involves getting the guest measurement data in the
> > format of TDREPORT, which is further used to validate the authenticity
> > of the TDX guest. TDREPORT by design is integrity-protected and can
> > only be verified on the local machine.
> >
> > To support remote verification of the TDREPORT in a SGX-based
> > attestation, the TDREPORT needs to be sent to the SGX Quoting Enclave
> > (QE) to convert it to a remotely verifiable Quote. SGX QE by design can
> > only run outside of the TDX guest (i.e. in a host process or in a
> > normal VM) and guest can use communication channels like vsock or
> > TCP/IP to send the TDREPORT to the QE. But for security concerns, the
> > TDX guest may not support these communication channels. To handle such
> > cases, TDX defines a GetQuote hypercall which can be used by the guest
> > to request the host VMM to communicate with the SGX QE. More details
> > about GetQuote hypercall can be found in TDX Guest-Host Communication
> > Interface (GHCI) for Intel TDX 1.0, section titled
> > "TDG.VP.VMCALL<GetQuote>".
> >
> > Trusted Security Module (TSM) [1] exposes a common ABI for Confidential
> > Computing Guest platforms to get the measurement data via ConfigFS.
> > Extend the TSM framework and add support to allow an attestation agent
> > to get the TDX Quote data (included usage example below).
> >
> >   report=/sys/kernel/config/tsm/report/report0
> >   mkdir $report
> >   dd if=/dev/urandom bs=64 count=1 > $report/inblob
> >   hexdump -C $report/outblob
> >   rmdir $report
> >
> > GetQuote TDVMCALL requires TD guest pass a 4K aligned shared buffer
> > with TDREPORT data as input, which is further used by the VMM to copy
> > the TD Quote result after successful Quote generation. To create the
> > shared buffer, allocate a large enough memory and mark it shared using
> > set_memory_decrypted() in tdx_guest_init(). This buffer will be re-used
> > for GetQuote requests in the TDX TSM handler.
> >
> > Although this method reserves a fixed chunk of memory for GetQuote
> > requests, such one time allocation can help avoid memory fragmentation
> > related allocation failures later in the uptime of the guest.
> >
> > Since the Quote generation process is not time-critical or frequently
> > used, the current version uses a polling model for Quote requests and
> > it also does not support parallel GetQuote requests.
> >
> > Link: https://lore.kernel.org/lkml/169342399185.3934343.3035845348326944519.stgit@dwillia2-xfh.jf.intel.com/ [1]
> > Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> > Reviewed-by: Erdem Aktas <erdemaktas@google.com>
> > Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> 
> Hey Dan,
> 
> I tried running your test commands on an SNP enabled guest. To build
> the kernel I just checked out linus/master and applied your series. I
> haven't done any debugging yet, so I will update with what I find.
> 
> root@Ubuntu2004:~#   hexdump -C $report/outblob
> [  219.871875] ------------[ cut here ]------------
> [  219.876642] kernel BUG at include/linux/scatterlist.h:187!

Ok, it does not like virtual address of one of the buffers, but my
changes "should" not have affected that as get_ext_report() internally
uses snp_dev->certs_data and snp_dev->response for bounce buffering the
actual request / response memory. First test I want to try once I can
get on an SNP system is compare this to the ioctl path just make sure
that succeeds.