Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Sender: Ingo Molnar <mingo.kernel.org@gmail.com>
Date:   Thu, 28 Sep 2023 23:17:23 +0200
From:   Ingo Molnar <mingo@kernel.org>
To:     Marc Zyngier <maz@kernel.org>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Biju Das <biju.das.jz@bp.renesas.com>,
        Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Maulik Shah <quic_mkshah@quicinc.com>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] irqchip fixes for 6.6, take #1
Message-ID: <ZRXtYzIA5dK1iPVb@gmail.com>
References: <20230924094105.2361754-1-maz@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230924094105.2361754-1-maz@kernel.org>
Precedence: bulk


* Marc Zyngier <maz@kernel.org> wrote:

> Dmitry Baryshkov (1):
>       arm64: dts: qcom: sm8150: extend the size of the PDC resource

This SOB chain, while valid, is a hodgepodge with no rhyme and reason:

  Fixes: 397ad94668c1 ("arm64: dts: qcom: sm8150: Add pdc interrupt controller node")
  Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
  Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
  Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
  Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
  Signed-off-by: Marc Zyngier <maz@kernel.org>
  Link: https://lore.kernel.org/r/20230905-topic-sm8x50-upstream-pdc-ver-v4-2-fc633c7df84b@linaro.org

Besides the ordering, people in the SOB chain should not have a separate
Reviewed-by tag: *of course* anyone who forwards a patch with a SOB has
reviewed it, it's basically implicit.

So the tags should be something like:

  Fixes: 397ad94668c1 ("arm64: dts: qcom: sm8150: Add pdc interrupt controller node")
  Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
  Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
  Signed-off-by: Marc Zyngier <maz@kernel.org>
  Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
  Link: https://lore.kernel.org/r/20230905-topic-sm8x50-upstream-pdc-ver-v4-2-fc633c7df84b@linaro.org

Ie. we generally sort the tags not chronologically (or whatever the original idea
was), but group them topically, sort the groups by importance, and only within
the group is there chronological order.

Thanks,

	Ingo