Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Mon, 25 Sep 2023 23:28:40 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Hugh Dickins <hughd@google.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Andi Kleen <ak@linux.intel.com>,
        Christoph Lameter <cl@linux.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        David Hildenbrand <david@redhat.com>,
        Suren Baghdasaryan <surenb@google.com>,
        Yang Shi <shy828301@gmail.com>,
        Sidhartha Kumar <sidhartha.kumar@oracle.com>,
        Vishal Moola <vishal.moola@gmail.com>,
        Kefeng Wang <wangkefeng.wang@huawei.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Tejun Heo <tj@kernel.org>,
        Mel Gorman <mgorman@techsingularity.net>,
        Michal Hocko <mhocko@suse.com>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org
Subject: Re: [PATCH 05/12] mempolicy trivia: slightly more consistent naming
Message-ID: <ZRIJmIWQ4WRLkZZ7@casper.infradead.org>
References: <2d872cef-7787-a7ca-10e-9d45a64c80b4@google.com>
 <1a75d3dd-7fa-7a41-c76b-1232198a9a4a@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1a75d3dd-7fa-7a41-c76b-1232198a9a4a@google.com>
Precedence: bulk

On Mon, Sep 25, 2023 at 01:26:55AM -0700, Hugh Dickins wrote:
> Before getting down to work, do a little cleanup, mainly of inconsistent
> variable naming.  I gave up trying to rationalize mpol versus pol versus
> policy, and node versus nid, but let's avoid p and nd.  Remove a few
> superfluous blank lines, but add one; and here prefer vma->vm_policy to
> vma_policy(vma) - the latter being appropriate in other sources, which
> have to allow for !CONFIG_NUMA.  That intriguing line about KERNEL_DS?
> should have gone in v2.6.15, when numa_policy_init() stopped using
> set_mempolicy(2)'s system call handler.

Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>