Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Fri, 29 Sep 2023 08:39:42 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Lino Sanfilippo <LinoSanfilippo@gmx.de>,
        Lino Sanfilippo <l.sanfilippo@kunbus.com>
Cc:     gregkh@linuxfoundation.org, jirislaby@kernel.org,
        shawnguo@kernel.org, s.hauer@pengutronix.de,
        ilpo.jarvinen@linux.intel.com, mcoquelin.stm32@gmail.com,
        alexandre.torgue@foss.st.com, linux-kernel@vger.kernel.org,
        linux-serial@vger.kernel.org, l.sanfilippo@kunbus.com,
        lukas@wunner.de, p.rosenberger@kunbus.com
Subject: Re: [PATCH 6/6] serial: imx: do not set RS485 enabled if it is not
 supported
Message-ID: <20230929063942.qukemr4o7l5vdmud@pengutronix.de>
References: <20230928221246.13689-1-LinoSanfilippo@gmx.de>
 <20230928221246.13689-7-LinoSanfilippo@gmx.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="yu5mcexmqulaqvex"
Content-Disposition: inline
In-Reply-To: <20230928221246.13689-7-LinoSanfilippo@gmx.de>
Precedence: bulk


--yu5mcexmqulaqvex
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Sep 29, 2023 at 12:12:46AM +0200, Lino Sanfilippo wrote:
> From: Lino Sanfilippo <l.sanfilippo@kunbus.com>
>=20
> If the imx driver cannot support RS485 it sets the UARTS rs485_supported
> structure to NULL. But it still calls uart_get_rs485_mode() which may set
> the RS485_ENABLED flag.
> The flag however is evaluated by the serial core in uart_configure_port()

I wonder if this is the code location where this problem should be
addressed. Or alternatively don't let uart_get_rs485_mode() set
RS485_ENABLED (and other flags) if rs485_supported doesn't suggest that
this works?

> [...]
>=20
> Signed-off-by: Lino Sanfilippo <l.sanfilippo@kunbus.com>

I don't know how picky Greg is here, but formally you missed to add an
S-o-b line for the sender of this patch (i.e. you with your gmx
address).

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--yu5mcexmqulaqvex
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmUWcS0ACgkQj4D7WH0S
/k47wAgAniMRiA+dl7M7pf4WXvom8QfwhOuzi/ZJVgQr7Sj0ZAnIWPLIKiiaR0zP
pNXr8qWggxnpYHw16JMLUsxCsPc5ZIudcgKzKBGQCbwG4TZreZJI7UGiV0UXoHku
Owvhb7x76chV/Zp+pCusPHMZZiN1VlS90to/oc3FnAg4PH65vuyMvgxPAX3SSUhB
qzHII257rxUIfET19HOFHKFyNgA4QNgme1XTyBxKbOB8tb+qLiMAFOpe+5XG/5Qq
LxkfDfi1dV9UHpTY5JvlmwgODB04srgN2v5zsiZ+ghujB8T0RpR6aaTaMptqBCOy
+Gusp1Hp79etQUN4XmNNMWn9ozjWqw==
=Gvvs
-----END PGP SIGNATURE-----

--yu5mcexmqulaqvex--