Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <480a3b0b-f6fd-8300-804b-36f390f2f36b@linaro.org>
Date:   Fri, 29 Sep 2023 06:03:49 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.15.1
Subject: Re: [PATCH 2/2] drm/panel: Add driver for BOE RM692E5 AMOLED panel
Content-Language: en-GB
To:     Konrad Dybcio <konrad.dybcio@linaro.org>,
        Jessica Zhang <quic_jesszhan@quicinc.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Konrad Dybcio <konradybcio@kernel.org>
Cc:     Marijn Suijten <marijn.suijten@somainline.org>,
        dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Luca Weiss <luca.weiss@fairphone.com>
References: <20230927-topic-fp5_disp-v1-0-a6aabd68199f@linaro.org>
 <20230927-topic-fp5_disp-v1-2-a6aabd68199f@linaro.org>
 <000416ca-3bbe-4913-9fe5-0993b90b2829@quicinc.com>
 <9febcacd-675f-4d91-9338-f8b3fad4cf62@linaro.org>
From:   Neil Armstrong <neil.armstrong@linaro.org>
In-Reply-To: <9febcacd-675f-4d91-9338-f8b3fad4cf62@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Le 29/09/2023 à 02:02, Konrad Dybcio a écrit :
> On 29.09.2023 00:00, Jessica Zhang wrote:
>> Hi Konrad,
>>
>> On 9/27/2023 6:19 AM, Konrad Dybcio wrote:
>>> Add support for the 2700x1224 AMOLED BOE panel bundled with a RM692E5
>>> driver IC, as found on the Fairphone 5 smartphone.
>>>
>>> Co-developed-by: Luca Weiss <luca.weiss@fairphone.com>
>>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>> ---
> [...]
> 
>>> +static int rm692e5_on(struct rm692e5_panel *ctx)
>>> +{
>>> +    struct mipi_dsi_device *dsi = ctx->dsi;
>>> +    struct device *dev = &dsi->dev;
>>> +    int ret;
>>> +
>>> +    dsi->mode_flags |= MIPI_DSI_MODE_LPM;
>>> +
>>> +    mipi_dsi_generic_write_seq(dsi, 0xfe, 0x41);
>>> +    usleep_range(1000, 2000);
>>
>> I'm not familiar with this panel, but is calling usleep() after almost every single DCS command necessary or specified by the spec?
> Removing them doesn't seem to cause adverse effects, so I'm willing to
> do that :)
> 
> [...]
> 
>> Are these generic DCS commands? If so, can you use the MIPI_DCS_* command macros/helpers when applicable?
> Unfortunately, it doesn't seem so.
> 
> [...]
> 
>> Just to check my understanding of the comment here.. so the above DCS command will set the panel to 90Hz, and if we change the parameter to 0x00, it will be set to 60Hz instead?
> Yes. Since the commands differ, I was reluctant to introduce
> a second, identical-except-60hz mode for now. Though I can
> define a driver-specific struct like this:
> 
> struct rm69e25_panel_desc {
> 	drm_display_mode drm_mode;
> 	u8 framerate_magic;
> };
> 
> and then define both a 60 and a 90 mode.
> 
> 
> I also moved DCS calls from .unprepare to .disable so that they
> are not sent to a DSI host that's powered off and will include
> that in v2. LMK if you have more comments.

Those changes would be great,

Thanks,
Neil

> 
> Konrad