Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <1d74ceae-f337-4062-a93d-bd4a2799dc3f@quicinc.com>
Date:   Fri, 29 Sep 2023 10:58:01 +0530
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] arm64: dts: qcom: sa8775p: Add RPMh sleep stats
To:     Konrad Dybcio <konrad.dybcio@linaro.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>
CC:     <quic_mkshah@quicinc.com>, <quic_lsrao@quicinc.com>,
        <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>
References: <20230926044814.535-1-quic_rkakarla@quicinc.com>
 <149165d9-1c89-45a5-90ab-82ce546f49f5@linaro.org>
Content-Language: en-US
From:   Raghavendra Kakarla <quic_rkakarla@quicinc.com>
In-Reply-To: <149165d9-1c89-45a5-90ab-82ce546f49f5@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 9/27/2023 12:36 AM, Konrad Dybcio wrote:
> On 26.09.2023 06:48, Raghavendra Kakarla wrote:
>> Add device node for sleep stats driver which provides various
>> low power mode stats.
>>
>> Cc: devicetree@vger.kernel.org
>> Signed-off-by: Raghavendra Kakarla <quic_rkakarla@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sa8775p.dtsi | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> index 9f4f58e831a4..cee7491de675 100644
>> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> @@ -1912,6 +1912,11 @@
>>   			#clock-cells = <0>;
>>   		};
>>   
>> +		sram@c3f0000 {
>> +			compatible = "qcom,rpmh-stats";
>> +			reg = <0 0x0c3f0000 0 0x400>;
> Other nodes (such as the one 5 lines below) use 0x0 instead of
> 0 to fill out bits 63:32. Please make it consistent.
Sure, will address this in next patch.
>
> Konrad
>> +		};
>> +
>>   		spmi_bus: spmi@c440000 {
>>   			compatible = "qcom,spmi-pmic-arb";
>>   			reg = <0x0 0x0c440000 0x0 0x1100>,