Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp3770037rdh; Fri, 29 Sep 2023 01:31:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFU6lSa1BKAYlXqXUzhs3D0Q/2wJcF/sIviRoz3+MXGWfhjv4un/ML6xmYSEukjVUNtA5kN X-Received: by 2002:a17:90a:f185:b0:269:25a8:66c with SMTP id bv5-20020a17090af18500b0026925a8066cmr3317102pjb.45.1695976260464; Fri, 29 Sep 2023 01:31:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695976260; cv=none; d=google.com; s=arc-20160816; b=ic6kKDDG4lAt5+gKXn1lfuZnx22tuIuXYbSlXt2n206m0F7AzjV2y229evikg319cj 9JOmpNBR0XRPpGBSLNmykJZf0El+pkD2v86SMYiUu/tqZTcnX8gNW51qo1ehr4Bz3ule GwAdeeVLUP0slKw9fGo4pUAy/FsyiCVVTmyKxuyriu9oZhpIkwOY2DHt4dqZBkVJrPjW QYTILmZmNhHiNblCgbE1bCXEmLg01yu2hX3ue1El89M1LZvNQPcsb1R3QQ/cM62RfWyN 8LyF6omSO200WKGEy+K819BOb299iHTHI03/k4HUSIcKI6B9y5GKkjzaaJKSU7I31jvx pbNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=IdE47ccEJVgPvSH9BWbF+fIplCXC5Qc2Je9vj/botNc=; fh=aE9TRlpikkKCi2kqbIZbjlc57by4QRyNIBvq3ygstm0=; b=cCFO95poSD/yZmOWCQUUmcEPVO/2jmxziQO7wwCWfSWO5hi1o60D85SlQ0PI2Yii67 V4dkecU+W5grqfdzq5MxAvrMlBrtfudvaQGmn6uBktsqo6fVugCHoQ5vEkppkDF0Lb2h tmuH3mtEy90TKFhYYFPq/Ljk1xvofxPbCX0UZdmA5mgzDWOm2cbbCZKXYIZaBRfRY6BW SLWqNleKkHuXUh4GlaApOXuzDfanbrqcMH9+MdSirIm2yKTdYCrczPfphhfBJwdEe6cO /J1kl2ybK6UJ1Lwd4tCPPIk0Si2aBxOpH8l5h+6j97wW3meInsSOpr2Z9E4Naa1B6HGL wcBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Pr5yvZcp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id mq16-20020a17090b381000b0027408bd8420si1220495pjb.13.2023.09.29.01.30.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Sep 2023 01:31:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Pr5yvZcp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 76C33836E25C; Thu, 28 Sep 2023 23:50:11 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232781AbjI2Gtk (ORCPT + 99 others); Fri, 29 Sep 2023 02:49:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232655AbjI2Gtc (ORCPT ); Fri, 29 Sep 2023 02:49:32 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59BE51B3 for ; Thu, 28 Sep 2023 23:49:30 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2bff776fe0bso223401401fa.0 for ; Thu, 28 Sep 2023 23:49:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695970168; x=1696574968; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IdE47ccEJVgPvSH9BWbF+fIplCXC5Qc2Je9vj/botNc=; b=Pr5yvZcp+VjqHWgYEydarW6aRJbG7cJcjTS/gcRyeB27StxQRTRFvXsNbG4eKefuXS vintCQ0TkitYH4g/JynVx63syoAkU7cvZL5jKmAUlXV8/GY2NQFRv3n/RpdsEPigrK28 eYlWxL5sBJVEGEfW/EfPWok55T+6L+ak5gey4NlXwLSHF0emXlB4xdBLgwHicUo6uzr1 Evjx+J7Eh7UwcOX1VZ25ufqm5KhxLvBNMk9Fr3AwjZK94d5GzcUg5H8Zh8Az5OmIeggH L+LUvhWzXN+gU1nwupgOOB0FvL4Ew1pdilMODIMn/bAPD0cqCHZo1pVTn67bp7kkfjb9 aVXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695970168; x=1696574968; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IdE47ccEJVgPvSH9BWbF+fIplCXC5Qc2Je9vj/botNc=; b=BHuHHLYHcvlqXs0AAUnXAdd5CdVCyvvYK3C7TCQvN4iAWBFMBUhpauBREVzYQ3WwuN G+kXpyDJSjNNcS1DmpLQ8hlB0KjcHKMXcytLWAglpn05ug3RHytcxZauIZXY59rTFZob 19qZm67Igh0VOmPlj0iPEOxbfF9gw5oZZPaIGdQyD1BQ2VdtQC82pSKdtoEHR6L822Y1 qVo67PRZMXFde0KwCTNPqFMS0WiCrG23Tw4EYWeCDQLU38Y17LOq6V3m53pWzXLA/ftQ Bwyusot77DBNInhoHjBDecHOZL4pklUlKmiCmpKiullvcknUQLYcQ0jjo2gbHNzikx52 EPnA== X-Gm-Message-State: AOJu0Yx0h6PSME396AKqvSjOUxamuXoFgzFrGdhWcf5lYG9B7dk9i9Ru Ma4XXo1ZyxDYLBjp64XbLPOALA== X-Received: by 2002:a05:6512:4819:b0:505:6ede:20b0 with SMTP id eo25-20020a056512481900b005056ede20b0mr825848lfb.58.1695970168197; Thu, 28 Sep 2023 23:49:28 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id o6-20020a05600c378600b00405ee9dc69esm751819wmr.18.2023.09.28.23.49.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 23:49:27 -0700 (PDT) Date: Fri, 29 Sep 2023 09:49:24 +0300 From: Dan Carpenter To: Kalle Valo Cc: Christian Lamparter , Wu Yunchuan , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH v2 wireless-next 2/9] carl9170: remove unnecessary (void*) conversions Message-ID: References: <20230919044916.523308-1-yunchuan@nfschina.com> <87zg16iab3.fsf@kernel.org> <0b7623f7-561c-4f3b-91c1-aaf1c44f1158@kadam.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0b7623f7-561c-4f3b-91c1-aaf1c44f1158@kadam.mountain> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 28 Sep 2023 23:50:11 -0700 (PDT) On Fri, Sep 29, 2023 at 09:43:03AM +0300, Dan Carpenter wrote: > I don't know anything which would warn about this. Generally, in the > kernel we try to avoid casts but perhaps there was a static checker > which likes casts? > > If removing these sorts of casts were an issue we would have known by > now. Thinking about it more, if this caused a static checker warning then probably every kmalloc() would need a cast. regards, dan carpenter