Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp3792336rdh; Fri, 29 Sep 2023 02:25:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHD+iwLEzpmkjhfAPdYl4oCu2e5ErqWeopwY/QoYweTu89NrexEf/8awRVXaYS/o9W95Isk X-Received: by 2002:a17:90a:6ba5:b0:26f:2c5a:bbb3 with SMTP id w34-20020a17090a6ba500b0026f2c5abbb3mr3410383pjj.40.1695979513948; Fri, 29 Sep 2023 02:25:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695979513; cv=none; d=google.com; s=arc-20160816; b=HKMPrk07R0+vjra6LWMs/9pNLf8Xt7JDZlle6W8e0vpMiU1IyN9a3mAITbAzoiUN/+ 3YN6R5ZqMRY5JeeBCmiZXBlyHHNO8DpvrbLwgXTzyC4xlsAynHV4tap6w6m9RnBFk8Qp EjXRZ3971NQiHo1ahijNsZp4EbjNWqiiI2y4xvQQtZETHLZRZO/QLgOpC3bAD3EqP8A7 5Z12c0GOnA1RrpRrBXNyCdDdkgZGeg4D0KjChQtC9NDloh5fhlGNAKxj17ympzFe1i+w AEvN2tVLChjCWKfFmQKXvVT0pCTtxRhD6wTLjHSI9Ayejd8EjByzEaT+MgQxcAwB3G8K TaCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=lDFhrfVnKZT8JE+MlpCeVPtZOgoFe9WBz04bYYSfCTk=; fh=vyUhk6wY2f7Hs4rJ+AAUumMVj+8e3UJfwcV8l4jGMM0=; b=pwDTVkBDa/ER3DHsg/cfr7HUQqgLcnZppF7tI9zuCHTYllIwbP+arkcW7labJth2Xj R3EnckkQ7nofTfB0tkXMfQgYUMgCefzBLIbkhSGKf777HTfpQ+8sPt678o0MtX8Uqnws 1hW/Y8x3ah1LXWCkQe9w3nv+hKgf4wZSBQZoRoRjF1FrgO7y7F5YftTh2+8jc60Qvcth a+QD/7sX+WLQ4lIaYN9Mo8AjsQ1d8MUOd70FB1dZThJFzIMIgfxJSLmC262OwQxz+dV5 VRGGVEFX3u2eNB8WSIm9FPyk2x7PRgvs8Dz8XfEZWu+WK/wcgTToUAZuwmAzkGmYYIBJ 3VVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=xbCONu0+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id gv20-20020a17090b11d400b002773f96df0esi1123311pjb.3.2023.09.29.02.25.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Sep 2023 02:25:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=xbCONu0+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 0E5B683CF90A; Thu, 28 Sep 2023 22:47:50 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232704AbjI2FrX (ORCPT + 99 others); Fri, 29 Sep 2023 01:47:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232625AbjI2FrV (ORCPT ); Fri, 29 Sep 2023 01:47:21 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 179391A8; Thu, 28 Sep 2023 22:47:18 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27795C433C7; Fri, 29 Sep 2023 05:47:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1695966437; bh=ayyx6diQFCE4/i0OyR9K661Xi1vAvQH2euXiaM8yNm4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xbCONu0+/vj0XFwkoWnsf2TqByO3ktsHf/PXDV9pN7tSCIJIk9tQjl2vEa+B1nWTE A5+tlUezN5/nVv+6n4/7lauCZWcYaK8Cgaf3WxWx9rzg9KglKnlNYsXTHhbAG3HpyB 7R4QkY8n+gydjVqvK/axYi6fjN1pv3aGeGBtNdf4= Date: Fri, 29 Sep 2023 07:47:12 +0200 From: Greg KH To: Kees Cook Cc: Yuanhe Shu , jirislaby@kernel.org, tony.luck@intel.com, gpiccoli@igalia.com, shuah@kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 0/5] pstore: add tty frontend and multi-backend Message-ID: <2023092919-buccaneer-ibuprofen-7834@gregkh> References: <20230928024244.257687-1-xiangzao@linux.alibaba.com> <202309282030.8CE179EBB@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202309282030.8CE179EBB@keescook> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 28 Sep 2023 22:47:50 -0700 (PDT) On Thu, Sep 28, 2023 at 08:49:02PM -0700, Kees Cook wrote: > On Thu, Sep 28, 2023 at 10:42:39AM +0800, Yuanhe Shu wrote: > - I'd like to check with the TTY folks to see if this is the "right" > place to hook to get a copy of what's being written. It depends on what you want to get. What exact data are you looking for here? I couldn't figure it out and I think I already asked it in my review of the "hook" location. thanks, greg k-h