Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
MIME-Version: 1.0
References: <20230918080314.11959-1-jagathjog1996@gmail.com>
 <20230918080314.11959-3-jagathjog1996@gmail.com> <20230924153055.0b3486f9@jic23-huawei>
 <CAM+2EuJBxj7P-ymu84u308g8LCemSEsYi_TSHYtaK9PyrhqrfA@mail.gmail.com> <5eb148b4-25eb-460d-9ec8-0a40bec1dc6f@gmail.com>
In-Reply-To: <5eb148b4-25eb-460d-9ec8-0a40bec1dc6f@gmail.com>
From:   Jagath Jog J <jagathjog1996@gmail.com>
Date:   Fri, 29 Sep 2023 13:29:13 +0530
Message-ID: <CAM+2EuJUGu4QUCdZ7d28RaLNipJRVuASP9wSzF14k=oBoC4e_Q@mail.gmail.com>
Subject: Re: [RFC 2/2] iio: imu: Add driver for BMI323 IMU
To:     Denis Benato <benato.denis96@gmail.com>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        andriy.shevchenko@linux.intel.com, lars@metafoo.de,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Denis,

On Thu, Sep 28, 2023 at 2:55=E2=80=AFAM Denis Benato <benato.denis96@gmail.=
com> wrote:
>
> Hello,
>
> Some devices (as my asus rog ally) have an ACPI node describing a BOSC020=
0 sensor. The IC being used in those devices is a  bmi323 but as a result o=
f how the ACPI table reports that device, it is detected by the existing ke=
rnel module and we have no way of differentiating until after the chip ID p=
robe.
>
> The module loaded is bmc150-accel-i2c.c which currently doesn't support t=
he bmi323 and the loading of the module just fails at chip check.

bmc150 driver supports multiple accelerometer sensors such as
bma222, bma280, bmi055 and all of them are having similar
register map, but the bmi323 register map is completely different
from bmc150.


>
> I have solved the problem by expanding the current bmc150-accel-i2c.c and=
 bmc150-accel-core.c files to handle that IC in almost every part: gyroscop=
e, accelerometer and temperature sensor.
>
> What is the best way of organizing code to have this module mainlined? Is=
 it correct leaving files called bmc150-accel-* even if it is managing anot=
her IC and and not just the accelerometer part anymore?
>
> TIA for your time.
>
> Best regards,
> Denis Benato

Regards

Jagath