Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756025AbXKMQlw (ORCPT ); Tue, 13 Nov 2007 11:41:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751400AbXKMQlm (ORCPT ); Tue, 13 Nov 2007 11:41:42 -0500 Received: from mga02.intel.com ([134.134.136.20]:37264 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750776AbXKMQll (ORCPT ); Tue, 13 Nov 2007 11:41:41 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.21,411,1188802800"; d="scan'208";a="232964435" Message-ID: <4739D3A5.4020503@intel.com> Date: Tue, 13 Nov 2007 08:41:09 -0800 From: "Kok, Auke" User-Agent: Thunderbird 2.0.0.6 (X11/20070911) MIME-Version: 1.0 To: Patrick McHardy CC: Herbert Xu , David Miller , joonwpark81@gmail.com, w@1wt.eu, cfriesen@nortel.com, netdev@vger.kernel.org, djohnson+linux-kernel@sw.starentnetworks.com, linux-kernel@vger.kernel.org, e1000-devel@lists.sourceforge.net Subject: Re: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode References: <20071113.033611.73195922.davem@davemloft.net> <20071113120328.GB1086@gondor.apana.org.au> <20071113.040624.43544149.davem@davemloft.net> <20071113121647.GA1330@gondor.apana.org.au> <4739961E.90708@trash.net> In-Reply-To: <4739961E.90708@trash.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 13 Nov 2007 16:41:40.0326 (UTC) FILETIME=[10CEF860:01C82614] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1528 Lines: 35 Patrick McHardy wrote: > Herbert Xu wrote: >> On Tue, Nov 13, 2007 at 04:06:24AM -0800, David Miller wrote: >>>> In other words we can make it so that nobody is in promiscuous >>>> mode and therefore have to disable VLAN acceleration *unless* >>>> they really want to be in that state. In which case it would >>>> imply that they wish to see everything and therefore we should >>>> disable VLAN acceleration. >>> This is too complicated, we have multiple unicast MAC support >>> in the driver API already, let's simply use it. >> >> Yes I agree. People not using Patrick's new API deserves to >> get poor performance so they can switch over sooner :) >> >> What I was trying to say above is that e1000 currently uses >> the old set_multicast_list interface (rather than dev_set_rx_mode) >> so it's not immediately obvious why we're in promiscuous mode. >> We could look at dev->promiscuity - !!uc_count but that feels a >> bit fragile. >> >> Perhaps those who want to push this patch should be encouraged >> to convert e1000 to the new interface :) > > > I already posted a patch for this, not sure what happened to it. > Auke, any news on merging the secondary unicast address support? I dropped the ball on that one. Care to resend it and send me one for e1000e as well? Auke - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/