Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Fri, 29 Sep 2023 12:57:53 +0200
From:   Frederic Weisbecker <frederic@kernel.org>
To:     Ingo Molnar <mingo@kernel.org>
Cc:     linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        linux-tip-commits@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH] tick/nohz: Update comments some more
Message-ID: <ZRatsTz1mQRFJ0sW@lothringen>
References: <20230912104406.312185-3-frederic@kernel.org>
 <169582689118.27769.11953848930688373230.tip-bot2@tip-bot2>
 <ZRVCNeMcSQcXS36N@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZRVCNeMcSQcXS36N@gmail.com>
Precedence: bulk

On Thu, Sep 28, 2023 at 11:07:01AM +0200, Ingo Molnar wrote:
> > + * infrastructure actually relies on the tick itself as a backend in
> > + * low-resolution mode (see hrtimer_run_queues()).
> > + *
> > + * This low-resolution handler still makes use of some hrtimer APIs meanwhile
> > + * for commodity with expiration calculation and forwarding.
> 
> commodity?

I meant 'convenience', my usual frenglish issues...

> 
> >   */
> >  static void tick_nohz_lowres_handler(struct clock_event_device *dev)
> >  {
> 
> As well-deserved penace for my nitpicking, I've fixed these on top of
> tip:timers/core, and have also done a full scan of kernel/time/tick-sched.c
> for spelling, consistency of style and readability of comments - see
> the patch below.
> 
> Thanks,
> 
> 	Ingo
> 
> ===========================>
> From: Ingo Molnar <mingo@kernel.org>
> Date: Thu, 28 Sep 2023 10:45:54 +0200
> Subject: [PATCH] tick/nohz: Update comments some more
> 
> Inspired by recent enhancements to comments in kernel/time/tick-sched.c,
> go through the entire file and fix/unify its comments:
> 
>  - Fix over a dozen typos, spelling mistakes & cases of bad grammar.
> 
>  - Re-phrase sentences that I needed to read three times to understand.
> 
>     [ I used the following arbitrary rule-of-thumb:
>        - if I had to read a comment twice, it was usually my fault,
>        - if I had to read it a third time, it was the comment's fault. ]
> 
>  - Comma updates:
> 
>     - Add commas where needed
> 
>     - Remove commas where not needed
> 
>     - In cases where a comma is optional, choose one variant and try to
>       standardize it over similar sentences in the file.   
> 
>  - Standardize on standalone 'NOHZ' spelling in free-flowing comments:
> 
>       s/nohz/NOHZ
>       s/no idle tick/NOHZ
> 
>    Still keep 'dynticks' as a popular synonym.
> 
>  - Standardize on referring to variable names within free-flowing
>    comments with the "'var'" nomenclature, and function names as
>    "function_name()".
> 
>  - Standardize on '64-bit' and '32-bit':
>      s/32bit/32-bit
>      s/64bit/64-bit
> 
>  - Standardize on 'IRQ work':
>      s/irq work/IRQ work
> 
>  - A few other tidyups I probably missed to list.
> 
> No change in functionality intended - other than one small change to
> a syslog output string.
> 
> Signed-off-by: Ingo Molnar <mingo@kernel.org>

Looks good, thanks!