Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
From:   Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
To:     "Radu Pirea (NXP OSS)" <radu-nicolae.pirea@oss.nxp.com>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "borisp@nvidia.com" <borisp@nvidia.com>,
        "saeedm@nvidia.com" <saeedm@nvidia.com>,
        "leon@kernel.org" <leon@kernel.org>,
        "sd@queasysnail.net" <sd@queasysnail.net>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        "hkallweit1@gmail.com" <hkallweit1@gmail.com>,
        "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        "sebastian.tobuschat@oss.nxp.com" <sebastian.tobuschat@oss.nxp.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: RE: [EXT] [PATCH net-next v6 05/10] octeontx2-pf: mcs: update PN only
 when update_pn is true
Thread-Topic: [EXT] [PATCH net-next v6 05/10] octeontx2-pf: mcs: update PN
 only when update_pn is true
Thread-Index: AQHZ8eh3hbvedhmCRUmmM4+XCFyv7rAxVNxQ
Date:   Fri, 29 Sep 2023 06:20:05 +0000
Message-ID: <CO1PR18MB46669352C6BA72CEDF44993FA1C0A@CO1PR18MB4666.namprd18.prod.outlook.com>
References: <20230928084430.1882670-1-radu-nicolae.pirea@oss.nxp.com>
 <20230928084430.1882670-6-radu-nicolae.pirea@oss.nxp.com>
In-Reply-To: <20230928084430.1882670-6-radu-nicolae.pirea@oss.nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ybV5nqG66mCcJaf4+Ui83hXZ5EHvjoFmohFJuk1qmGCabrPvpITRuxyVdmIj?=
 =?us-ascii?Q?52bnbhWTSwTqf7/jJDmXBsjAxfe4+QC6BWhqip0+422YQU4YtUWwzitEixFi?=
 =?us-ascii?Q?e2WUycVtTvoQh3A31QTNtzunjj+3YyYT19uwW2D66S1r5KwUScTAKjAuZ7i/?=
 =?us-ascii?Q?+sl/8NS3zkXOQzsN9M3k9xmfWPDUDyivlOZWtAPN4o6bE9UjoIYTyBTDjVXX?=
 =?us-ascii?Q?STHjYsO3/fYnXri44Ug0+vy3mBzixLf5aPIu5p8bqohkWh5SMzyEU8xRM64r?=
 =?us-ascii?Q?rA/YI9ZmWP62j2+WZ+gLvFxnABrmY5cvfuW6m4YSv8loAQLID/qkoSpQmqpN?=
 =?us-ascii?Q?xcey97fvIqlkrBCXCZHaz4/0u0El7ta+xhdmwtdSiThthXI5Mu0kz3/uwoYf?=
 =?us-ascii?Q?e2MIpcpdoP1cM593B4tyOUfJ6nvW5bhRGdH8nbs4zwaKfh8QSvrlLQrbAZOq?=
 =?us-ascii?Q?NyNSsD36ohNPidC9940p+mUIAbH+qZJ0BObJKdGo17fmMGIUx2OJ2jfMTsOU?=
 =?us-ascii?Q?msgzJ3X65As5a9tA7nAY9CZXIFOKZU3Y5OCREAz8H1y4BM83p71oSnAJK8BW?=
 =?us-ascii?Q?3bWPTLl5/H1H+h6Zmt5eXrneeu5Q/Pz/PUYUO7KgrWdWzIIdkuTRLVOonje2?=
 =?us-ascii?Q?DSCZ3cmDxht7cunl2YcI6jJV3a9fo6aIUIidiiHuLpp7fYna0/Gph5KprivN?=
 =?us-ascii?Q?dhjOgxRJNl2BUq6Wc3K2Nu8YsYFiLyVKWAREH8awkUH40T8MDgT8DrCtn8Ui?=
 =?us-ascii?Q?rL91KXwhufRuMQMuzI4loe1TxVBKUuOy0pXZETp+XlH9oLVHCRT01tIEfKtj?=
 =?us-ascii?Q?Q6NSF5cGuvFmfn7Ds8bO9ZwEGnIeQUruMaJAGNYSgeiSwXdCPjCvVhqs3JZ2?=
 =?us-ascii?Q?W7nfNP5UpHcjZMRDvrOY5Hfm76dpt6/qu5a+OTUqEtpKo4YIyQxAQHTbC0zS?=
 =?us-ascii?Q?Q1SUFesPFa9Mpndez0BXL+HFeBNN7juNtoh7qOgsIusbzhP6R8t/ykaCV6kJ?=
 =?us-ascii?Q?79fZfSfjWo24mVFwYkXjBz2VIxZBn1bZGDhyCPXwOVqDBy8xMsUCvap+inZ3?=
 =?us-ascii?Q?q4kTAQMfns23WIAHo2WsUbbEIUKxyw6sESwQhfh1T7tW+DhoRrpgTZH808Gq?=
 =?us-ascii?Q?7J4XVo7qjxcgCqWZBlpeZXlyzPrw4UjlVG5rVjUk4ig/myMNjAN7ifdGbduv?=
 =?us-ascii?Q?RgM8p6/qYzyGdXWgNnq8Pzeku9FJhZQtH0DJqbTm44sUvTdxyxyRzajeNUFM?=
 =?us-ascii?Q?sDw8oemR9UOaYXy0JUq8Pp2QbRu9Z7TaagJ4yxy9Xtroiitl1cYsL1wyEcNe?=
 =?us-ascii?Q?g1u948abyHCosdisBovTYjf2CWxl1Xa/N1I59DGiSv3rqUc19rgciBYEMZxe?=
 =?us-ascii?Q?Yo0YCYMhSztV3QhtbDVpdJPoaRzLKav4NHSyrtpgRj5DaDBwOt/p6hA/8Y/z?=
 =?us-ascii?Q?7H6e1H5e8heeuPQaOuvcQE1FzWUrh3cQ3Rkh0256pHh17zPH9P9/tP9PYMpv?=
 =?us-ascii?Q?CJ8/tdvepHZ1qm3U579QXAS8laXnR/vm9wik/OTYNjsI/b5GVd2w+1qEQbQo?=
 =?us-ascii?Q?liW5Cn3rdvnQEdBIci0=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR18MB4666.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b1262366-ad1e-4856-8d5b-08dbc0b41f8d
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2023 06:20:05.8584
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XlvhAK27BPmL7MeYvKElDS/S8utylUyAA3ifQNCeaoso10pR1o9OSdi3Az7+zcSl+S7yW06+beIo35XZBsbnDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB3948
X-Proofpoint-ORIG-GUID: jH8icAXw_QTjKtv7bwtCe06wAujocE7Z
X-Proofpoint-GUID: jH8icAXw_QTjKtv7bwtCe06wAujocE7Z
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-09-29_04,2023-09-28_03,2023-05-22_02
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 28 Sep 2023 23:21:10 -0700 (PDT)

Hi,

>-----Original Message-----
>From: Radu Pirea (NXP OSS) <radu-nicolae.pirea@oss.nxp.com>
>Sent: Thursday, September 28, 2023 2:14 PM
>To: Sunil Kovvuri Goutham <sgoutham@marvell.com>; Geethasowjanya Akula
><gakula@marvell.com>; Subbaraya Sundeep Bhatta <sbhatta@marvell.com>;
>Hariprasad Kelam <hkelam@marvell.com>; davem@davemloft.net;
>edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
>borisp@nvidia.com; saeedm@nvidia.com; leon@kernel.org; sd@queasysnail.net;
>andrew@lunn.ch; hkallweit1@gmail.com; linux@armlinux.org.uk;
>richardcochran@gmail.com; sebastian.tobuschat@oss.nxp.com
>Cc: linux-kernel@vger.kernel.org; netdev@vger.kernel.org; linux-
>rdma@vger.kernel.org; Radu Pirea (NXP OSS) <radu-nicolae.pirea@oss.nxp.com=
>
>Subject: [EXT] [PATCH net-next v6 05/10] octeontx2-pf: mcs: update PN only
>when update_pn is true
>
>When updating SA, update the PN only when the update_pn flag is true.
>Otherwise, the PN will be reset to its previous value.
>
>Signed-off-by: Radu Pirea (NXP OSS) <radu-nicolae.pirea@oss.nxp.com>
>---
>Changes in v6:
>- patch added in v6
>
> drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c
>b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c
>index 59b138214af2..4c59850dfddf 100644
>--- a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c
>+++ b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c
>@@ -1362,6 +1362,9 @@ static int cn10k_mdo_upd_txsa(struct macsec_context
>*ctx)
> 		if (err)
> 			return err;
>
>+		if (!ctx->sa.update_pn)
>+			return 0;
>+
This is incorrect. Please change it as below:

@@ -1357,10 +1357,12 @@ static int cn10k_mdo_upd_txsa(struct macsec_context=
 *ctx)

        if (netif_running(secy->netdev)) {
                /* Keys cannot be changed after creation */
-               err =3D cn10k_write_tx_sa_pn(pfvf, txsc, sa_num,
-                                          sw_tx_sa->next_pn);
-               if (err)
-                       return err;
+               if (ctx->sa.update_pn) {
+                       err =3D cn10k_write_tx_sa_pn(pfvf, txsc, sa_num,
+                                                  sw_tx_sa->next_pn);
+                       if (err)
+                               return err;
+               }

                err =3D cn10k_mcs_link_tx_sa2sc(pfvf, secy, txsc,
                                              sa_num, sw_tx_sa->active);

> 		err =3D cn10k_mcs_link_tx_sa2sc(pfvf, secy, txsc,
> 					      sa_num, sw_tx_sa->active);
> 		if (err)
>@@ -1529,6 +1532,9 @@ static int cn10k_mdo_upd_rxsa(struct macsec_context
>*ctx)
> 		if (err)
> 			return err;
>
>+		if (!ctx->sa.update_pn)
>+			return 0;
>+
This is correct.

Thanks,
Sundeep
> 		err =3D cn10k_mcs_write_rx_sa_pn(pfvf, rxsc, sa_num,
> 					       rx_sa->next_pn);
> 		if (err)
>--
>2.34.1