Message-ID: <4739DD2F.5060605@goop.org>
Date: Tue, 13 Nov 2007 09:21:51 -0800
From: Jeremy Fitzhardinge <jeremy@goop.org>
User-Agent: Thunderbird 2.0.0.5 (X11/20070727)
MIME-Version: 1.0
To: Glauber de Oliveira Costa <gcosta@redhat.com>
CC: Andi Kleen <ak@suse.de>, lguest@ozlabs.org, kiran@scalemp.com,
       kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
       virtualization@lists.linux-foundation.org, chrisw@sous-sol.org,
       tglx@linutronix.de, anthony@codemonkey.ws, akpm@linux-foundation.org,
       mingo@elte.hu
Subject: Re: [PATCH 24/24] make vsmp a paravirt client
References: <11946338683305-git-send-email-gcosta@redhat.com>	<20071111180709.GG22277@bingen.suse.de>	<47398C4A.40806@redhat.com> <200711131333.41946.ak@suse.de> <47399DC8.7000504@redhat.com>
In-Reply-To: <47399DC8.7000504@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 773
Lines: 17

Glauber de Oliveira Costa wrote:
> the ifdef only exists because, as I said, the code itself will be always
> compiled in, to avoid an ifdef in setup_64.c. So it's just a taking it
> from here, putting it there issue. Kiran seem to prefer this way, but I
> don't really have a preference.

It would be better to have the ifdef in setup_64.c and just make the
compilation of vsmp_64.c depend on CONFIG_X86_VSMP.  If the ifdef really
rankles you could use a weak stub function somewhere, or define an
inline stub in vsmp.h.

    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/