Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Sender: Ingo Molnar <mingo.kernel.org@gmail.com>
Date:   Thu, 28 Sep 2023 11:32:51 +0200
From:   Ingo Molnar <mingo@kernel.org>
To:     Borislav Petkov <bp@alien8.de>
Cc:     Alexey Kardashevskiy <aik@amd.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH kernel v2] x86/compressed/64: reduce #VC nesting for
 intercepted CPUID for SEV-SNP guest
Message-ID: <ZRVIQwkYO5XYhRtD@gmail.com>
References: <20230926040526.957240-1-aik@amd.com>
 <ZRP6cd6rEymUaiL+@gmail.com>
 <20230927112259.GAZRQQk78aJN85ULm1@fat_crate.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230927112259.GAZRQQk78aJN85ULm1@fat_crate.local>
Precedence: bulk


* Borislav Petkov <bp@alien8.de> wrote:

> On Wed, Sep 27, 2023 at 11:48:33AM +0200, Ingo Molnar wrote:
> > Not sure how this was supposed to work - there's no 'ghcb' passed in to
> > snp_cpuid_postprocess(). Does this patch have a dependency perhaps, that
> > I missed?
> 
> Yes, it is explained above the diffstat. I'll take care of it when I get back.

Erm, yes indeed - I checked the first dependency which had the wrong SHA1
listed and which dependency is already upstream as 8dbe33956d96, but I missed
the second dependency:

> > > plus:
> > > https://lore.kernel.org/lkml/a5856fa1ebe3879de91a8f6298b6bbd901c61881.1690578565.git.thomas.lendacky@amd.com/

Alexey, for the v3 submission, instead of sending a standalone patch
that relies on a yet unmerged patch that was last submitted about two
months ago, please send a full series of patches that is self-consistent.

Ie. it should look something like this:

  [PATCH 0/2] x86: Misc SEV-SNP fixes
    [PATCH 1/2] x86/sev: Fix SNP CPUID requests to the hypervisor
    [PATCH 2/2] x86/compressed/64: Reduce #VC nesting for intercepted CPUID for SEV-SNP guest

( You can add your SOB to Tom's first patch, to signal that you
  tested it and are forwarding it, and that your fix relies on that fix. )

Thanks,

	Ingo