Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp4117649rdh; Fri, 29 Sep 2023 11:35:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEJkfpiawvvvYOx0NyIRuZxfowxVFzn9QiRa/ENRF//F8kjHwHxTA+Pghc2MpMyVaCp1SD4 X-Received: by 2002:a05:6a21:35c8:b0:131:f3a:4020 with SMTP id ba8-20020a056a2135c800b001310f3a4020mr4136939pzc.33.1696012540676; Fri, 29 Sep 2023 11:35:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696012540; cv=none; d=google.com; s=arc-20160816; b=sRtzGG2h6KcH3LBqIbEtTrn0xEcmtB31kEoErw9ZhfG0sJH9TqUTyhi/m0G/8mEmg6 h9qrAV62E8LvUaNLnRmNb9qfshqZx6s3fG7Ir4u379wqD8O/Sk9O2PvhRX/dh6v+XH2E zv038VsoL/DkVHjWMSkxfhvB18YSaMzOAd9uXfVapdcHJ/oWLEgDHDscTvaivIlXrKV5 Mg+PJD0aU+QS8ZRNIpGeo6nKUIZ4CLWdHbyEU5xAtCdza5dXJYo5NWHJqfYs2ZWJiHix 4W813qNLbRqMbY6csfbESaLhAiAHJ/stWN0bvCrXdanf1g+QtCpLDyrSJXLMPymNPaz2 Pfmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:references :cc:to:from:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=mo/Fmgs8ebIBJP4OfmoansQWGKkTUIXMnfyq+5Xah7A=; fh=teEH8EFxJNJsNE0tMjtPMLbjs4LOfpRkivpwotL3Qhg=; b=ohDo63reGAgqLKk9DEVHmgAWr9nWYSUgDWrdMZHTdCgLE2MGxfYsPb7ALbKEGUsQ5H sEfgE/CGvMVYtohFB+//nZV9O4tsIF21fHzLWs76o8e3uavXkUSTPSVwIctp++dnOQCs tQ6X9tuO9QbqC+MVZAmu1fn1f/djifjvF40yVEJn97DFWfCediAVmwtVx1zo71z99MYE FKQncl0mTnrr3t2pb9KGaPFkgffOXBy1TPe3RAXeQ7+eM9CMbt0OcCuV5D1CMkFurp+h h0qzgQufBxCdRK0xMDs4cjOtMF2C4WaBGZoH8Ff1SbgCNcFNyk4wJWAsBUttF9qKUx/+ F39A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=b1EXqp5u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id e4-20020a635444000000b00573f7d09445si21665921pgm.330.2023.09.29.11.35.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Sep 2023 11:35:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=b1EXqp5u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 1AAFC82C7B5A; Fri, 29 Sep 2023 10:22:52 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233215AbjI2RWg (ORCPT + 99 others); Fri, 29 Sep 2023 13:22:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232800AbjI2RWe (ORCPT ); Fri, 29 Sep 2023 13:22:34 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0F34193; Fri, 29 Sep 2023 10:22:31 -0700 (PDT) Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38TAhRvD004977; Fri, 29 Sep 2023 17:22:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : from : to : cc : references : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=mo/Fmgs8ebIBJP4OfmoansQWGKkTUIXMnfyq+5Xah7A=; b=b1EXqp5uU4pb5cOHsuEkYb+M5Boy6erCGlQNJITPFNOxJh5N3Lkx0s26Is2xKqCaJAhC OaufbyHL3EcYVTU/9nLpiNLC4I//7QacMOws4BxtwXC8zVR6RSKa8D1yeyBCvDOHlRMw U5U4lFs+4hx+RUk0vwZYIPTsIJ28/p/JvIRuSQ5Lz3/iqjve5PDfoYFlqEZpVCeXT29m ZyTryKQfMO9GogjXdD+OyX+mWhj/P1HMHITUtc7WOThaxOxERRkrFnahO2hn6fuJRKd6 5IL+gswWKqjfmYXp3SzY5FA8rtPOwTrZt32yX+kcbTCVLkBkC9kBsJg7guCY+EOa64Al Pw== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3tdqmv9u2v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 Sep 2023 17:22:20 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38THMHEY027482 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 Sep 2023 17:22:17 GMT Received: from [10.111.177.152] (10.49.16.6) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Fri, 29 Sep 2023 10:22:17 -0700 Message-ID: <28233946-7b20-4a08-ba0f-253e5ca5ff62@quicinc.com> Date: Fri, 29 Sep 2023 10:22:16 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 wireless-next 2/9] carl9170: remove unnecessary (void*) conversions Content-Language: en-US From: Jeff Johnson To: Christian Lamparter , Linux Wireless , , open list CC: Wu Yunchuan , Dan Carpenter , Kalle Valo References: <20230919044916.523308-1-yunchuan@nfschina.com> <87zg16iab3.fsf@kernel.org> <0b7623f7-561c-4f3b-91c1-aaf1c44f1158@kadam.mountain> <597c6e87-2d1c-4a8d-ab9f-d0d22566b9ed@quicinc.com> In-Reply-To: <597c6e87-2d1c-4a8d-ab9f-d0d22566b9ed@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01a.na.qualcomm.com (10.47.209.196) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: WjXijJQP5TDQRwNntQxUx0Sw9faqvgVY X-Proofpoint-ORIG-GUID: WjXijJQP5TDQRwNntQxUx0Sw9faqvgVY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-09-29_16,2023-09-28_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=518 spamscore=0 bulkscore=0 mlxscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 impostorscore=0 clxscore=1015 adultscore=0 phishscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2309290150 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 29 Sep 2023 10:22:52 -0700 (PDT) On 9/29/2023 9:10 AM, Jeff Johnson wrote: > On 9/29/2023 12:23 AM, Christian Lamparter wrote: >> I would like to take the chance to again point to this beauty: >> >> @Dan, @Jeff can you please comment on that too? > > I had not seen that patch since it was posted while I was transitioning > roles. It looks like a reasonable patch to me to handle FORTIFY_SOURCE > restrictions. Saw Dan's reply, and further looked at the patch and saw this wasn't actually a typical FORTIFY_SOURCE patch, so presumably this change is NOT needed.