Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <6e9200a1-cf3c-27ca-ceef-7d9b70297530@quicinc.com>
Date:   Fri, 29 Sep 2023 12:53:02 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v1] misc: fastrpc: Reset metadata buffer to avoid
 incorrect free
Content-Language: en-US
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     <srinivas.kandagatla@linaro.org>, <linux-arm-msm@vger.kernel.org>,
        <ekangupt@qti.qualcomm.com>, <linux-kernel@vger.kernel.org>,
        <fastrpc.upstream@qti.qualcomm.com>
References: <1693463723-16937-1-git-send-email-quic_ekangupt@quicinc.com>
 <2023092840-balmy-proved-e337@gregkh>
From:   Ekansh Gupta <quic_ekangupt@quicinc.com>
In-Reply-To: <2023092840-balmy-proved-e337@gregkh>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 9/28/2023 6:38 PM, Greg KH wrote:
> On Thu, Aug 31, 2023 at 12:05:23PM +0530, Ekansh Gupta wrote:
>> Metadata buffer is allocated during get_args for any remote call.
>> This buffer carries buffers, fdlists and other payload information
>> for the call. If the buffer is not reset, put_args might find some
>> garbage FDs in the fdlist which might have an existing mapping in
>> the list. This could result in improper freeing of FD map when DSP
>> might still be using the buffer. Added change to reset the metadata
>> buffer after allocation.
>>
>> Signed-off-by: Ekansh Gupta <quic_ekangupt@quicinc.com>
> 
> What commit id does this fix?
> 
> And you sent 3 patches, but not in a list, what order are they to be
> applied in?
> 
Thanks for reviewing the patches, Greg. I'll send the 3 patches as a 
patch series for better understanding.

-ekansh
> thanks,
> 
> greg k-h