Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <e15efa69-aa12-dfcb-da65-03b8a5ce76cd@intel.com>
Date:   Fri, 29 Sep 2023 09:55:55 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v3 2/7] selftests/resctrl: Extend signal handler coverage
 to unmount on receiving signal
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        =?UTF-8?Q?Maciej_Wiecz=c3=b3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
CC:     <linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
References: <20230929112039.7488-1-ilpo.jarvinen@linux.intel.com>
 <20230929112039.7488-3-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230929112039.7488-3-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OW9aZkg3dXBHYWUvaFRveXFTK3p4S3ZZanRSVlJabWl4eU5LS1hsOW1uZmky?=
 =?utf-8?B?Wk05T1VsUExIdGdjMWd5Nkl5R25CQUY5YmJ4SjdLa1lBTmxUdXgwZ2FVVHAy?=
 =?utf-8?B?Y0N5Q1IrT2RYa214eGJYRG9HMmdpejE0YXpWancxTnhLUkFHd3lGUG1JZGw5?=
 =?utf-8?B?bnE2YTJxbXgzeWpSU3QzbWg4KzJNa216ODJieUpCdlZZS2pVYllRb3NxdjVR?=
 =?utf-8?B?blFjK2R4QjhDZ2ZFamlzcHFjQVRmSDdaMXc4U2Rlbk1Kdlpxb3VyOTYzTzhy?=
 =?utf-8?B?MXJlVGZYNzFlZm1xU2hsTFBITFZtZXE5dDBEVkxPMXRoZnBZRkxLY0ZWeGsx?=
 =?utf-8?B?Z0FXYS9SWjFzWmRNSC9lZ3ZTMWg2L0lyakcySkI1aGJJUUxCeFBST2c5bUtO?=
 =?utf-8?B?eEVlenFhbXdDR0R6R3llRHNnTGlsTzVBY2VLMUZXT2sreVdTdkxhNStWZDQy?=
 =?utf-8?B?MkgyZ2xMTjhkRlpxak5weXVRWnZrdE13VnFqYVFqQlJzZU5VeTZxMStPREpW?=
 =?utf-8?B?YUtXR2VSUkQ4VjRyTldCdlc0OVN6MERWVkJjcUlxdllLL2dZc2xUTzZOWVlx?=
 =?utf-8?B?eDB0VDZnT0pmSmRWbUFtY0dhcDE0V1BBUUhnamFldUMwd0h0Y1AwL1ltZUV6?=
 =?utf-8?B?c09ZTFdiVytJenYrTndpbG9lZGlwTEFsRFllUHRJbk83b0JId3E5Qnp2ckx3?=
 =?utf-8?B?UlZxU2dnZHo4aXZzVlBjd1cvUkRmYmJYa3JUcHZUWHhWdG00d1ZmUjlmSURx?=
 =?utf-8?B?WDZXYWJ3aXB5eTNHYk9BVXRqNVlXNEVVaUJJSkw4OGNxcTVwdEtWVHoxS0V4?=
 =?utf-8?B?aGgyV081MTdKdHlMdjN6LzJQWTZ2eEpDeDVqNW9mdkFJT0QyQU91TG5OcTB2?=
 =?utf-8?B?RzNjQUpKclE2cURReVRnK1BubjRnT056VUkzdVZlcGZrRFVhNVplbndKd0Nl?=
 =?utf-8?B?dEczelNYakZYTFlLK1ZHMzBwYjRkdkt2bmh3R1lVbWlMRWlBK3dPVHlpRzdt?=
 =?utf-8?B?Zi9GMW9teDNZalNpTlk3RktEZk9qZ2VPV2JUQ2dyN2xqME9aZUgwYUx3Ui9C?=
 =?utf-8?B?WXhjTnJsTVJ1Qmd3anhFT2VIWGlxZEtVeGRnbVVXcm9WdHhleDBGOTdZQlFN?=
 =?utf-8?B?dkVESHNROG1paFR5KzhJT0FuOEFOamxsa0I2dzhoLzliUllwYzY3SEcxYlRo?=
 =?utf-8?B?QXh2ZEJiMk1SNE9jZStHWWk1Mk5HKzZzWXBhbTVjM0Q4bTMrenY2bWpob3Fq?=
 =?utf-8?B?UFR6blI5aDVxdkp6ck9UOTlVKzlSYnBxemUzSzM2WW1ndXp2cHo5WTZ0QWtS?=
 =?utf-8?B?NnZWa3c2d09lVkJVdnZJa0tSYXNUUnpYeENEdDlxenJjVnVYUWZUVW10SE5t?=
 =?utf-8?B?dWVQTW1ieXo1VzZGOURvVVZ2RVNCQ3V5ZUVCblFlemoyRzZ1VmkxZDA2YmdT?=
 =?utf-8?B?aDVPanNRMGxOdTlaYWVKd3BMWjJpUUZLUTRvb3BRcG9qZHR1c20wd29FeXI4?=
 =?utf-8?B?UjcrdkdjYjM5Wk05TTBTK3J0SFArNDNpZWFrVnhFYURkSUhjd1drS2s4QzZt?=
 =?utf-8?B?Y1BseVpiL2ZCNFhUc0lHY0ZML3VQaDh5NXN2K1kxZzhUQzE1N0tDQjVmVk04?=
 =?utf-8?B?ZlFDdDh5aTFONFdDenVGb3AvU3lOSHRMeUk3a1lvMTd0bDU2N0tyeTJvaHlu?=
 =?utf-8?B?b0tCWjdGa01GT0ZvOXJuOGVkQm1NYVBMSk9YVU5Nb3pJbGxicXE5VWlrMitY?=
 =?utf-8?B?ekZISmZtU0pVOHEwRjBxYUNvakhOYXhudWRERjdsSTJVV0ZRMEFLcTUrS2l2?=
 =?utf-8?B?MU14WUJsYlBLbEpMQkdsTlFpZnhaSlZxQWxMVDFCb1JCQ1lVNTZlaEdVT0dp?=
 =?utf-8?B?L0Z1UFBjQTdGOGsydE5EN3IwK0ZnbWx5WmtHZVZYQlVtM3grYUViTlZkcWtV?=
 =?utf-8?B?OUpCa21QUTJyOUtCVDcxQnVqVHM1c3g2SS83Y1BRczVPWHoyaFQ3dG1PWFRO?=
 =?utf-8?B?dEhoTFd0bXE3eStwTENSNU1mKzBDbFdnbDc1UlpnRzJRei9hUjdaUHJjY1dR?=
 =?utf-8?B?NDFzSzhwUW14UnRlT2RPSWFhQzdyUTFxK2FzWDlZZzZlT2RTZUxUQVRqa3ln?=
 =?utf-8?B?NXlhRGdKVzF2Y01iNE1nczIzdTJHUi9jUGJMMm9XWUNkQWM2SFFuT0pBZHBk?=
 =?utf-8?B?WEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c8661fd4-7299-4139-3a07-08dbc10cf3fc
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2023 16:55:58.1359
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Gf04EDB6K8Cj3RM+sIVxNHivEcUU0voXrPzhGlW2bLPEca2Nq+OVV7yBzkUr4cLNiYAiNAT2ui8rEHXgbO+AK1TmeDjhX+tWIwgHf0HhMz0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6469
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 29 Sep 2023 09:56:08 -0700 (PDT)

Hi Ilpo,

On 9/29/2023 4:20 AM, Ilpo Järvinen wrote:
...
> diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
> index 823672a20a43..4eab2fad97fb 100644
> --- a/tools/testing/selftests/resctrl/resctrl_tests.c
> +++ b/tools/testing/selftests/resctrl/resctrl_tests.c
> @@ -67,21 +67,45 @@ void tests_cleanup(void)
>  	cat_test_cleanup();
>  }
>  
> -static void run_mbm_test(const char * const *benchmark_cmd, int cpu_no)
> +static int test_prepare()

Please change to test_prepare(void) (checkpatch error).

>  {
>  	int res;
>  
> -	ksft_print_msg("Starting MBM BW change ...\n");
> +	res = signal_handler_register();
> +	if (res) {
> +		ksft_print_msg("Failed to register signal handler\n");
> +		return res;
> +	}
>  
>  	res = mount_resctrlfs();
>  	if (res) {
> -		ksft_exit_fail_msg("Failed to mount resctrl FS\n");
> +		signal_handler_unregister();
> +		ksft_print_msg("Failed to mount resctrl FS\n");
> +		return res;
> +	}
> +	return 0;
> +}
> +
> +static void test_cleanup()

Please change to test_cleanup(void) (checkpatch error).

> +{
> +	umount_resctrlfs();
> +	signal_handler_unregister();
> +}
> +

With the above two reports addressed you can add:

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Thank you.

Reinette