Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Sat, 30 Sep 2023 00:38:17 +0300
From:   Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To:     Mark Brown <broonie@kernel.org>
Cc:     Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Robert Foss <rfoss@kernel.org>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/bridge: adv7511: Convert to use maple tree register
 cache
Message-ID: <20230929213817.GB28737@pendragon.ideasonboard.com>
References: <20230929-drm-adv7511-v1-1-b871b28ee594@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230929-drm-adv7511-v1-1-b871b28ee594@kernel.org>
Precedence: bulk

Hi Mark,

Thank you for the patch.

On Fri, Sep 29, 2023 at 02:54:19PM +0200, Mark Brown wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.

I trust on your this statement.

> Signed-off-by: Mark Brown <broonie@kernel.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Out of curiosity, is this part of an effort to drop the rbtree cache ?

> ---
>  drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> index 2611afd2c1c1..d518de88b5c3 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> @@ -121,7 +121,7 @@ static const struct regmap_config adv7511_regmap_config = {
>  	.val_bits = 8,
>  
>  	.max_register = 0xff,
> -	.cache_type = REGCACHE_RBTREE,
> +	.cache_type = REGCACHE_MAPLE,
>  	.reg_defaults_raw = adv7511_register_defaults,
>  	.num_reg_defaults_raw = ARRAY_SIZE(adv7511_register_defaults),
>  
> @@ -1068,7 +1068,7 @@ static const struct regmap_config adv7511_cec_regmap_config = {
>  	.val_bits = 8,
>  
>  	.max_register = 0xff,
> -	.cache_type = REGCACHE_RBTREE,
> +	.cache_type = REGCACHE_MAPLE,
>  	.volatile_reg = adv7511_cec_register_volatile,
>  };
>  
> 
> ---
> base-commit: 6465e260f48790807eef06b583b38ca9789b6072
> change-id: 20230929-drm-adv7511-2d592921f8a2

-- 
Regards,

Laurent Pinchart