Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <cd4df23c-cc02-6723-e36d-34ca03409e6e@nvidia.com>
Date:   Fri, 29 Sep 2023 14:38:36 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.14.0
Subject: Re: [PATCH] hte: tegra194: improve the GPIO-related comment
Content-Language: en-US
To:     Bartosz Golaszewski <brgl@bgdev.pl>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>
Cc:     timestamp@lists.linux.dev, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>
References: <20230911094443.14040-1-brgl@bgdev.pl>
From:   Dipen Patel <dipenp@nvidia.com>
In-Reply-To: <20230911094443.14040-1-brgl@bgdev.pl>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dC8vRXMzNXhnZUdrVUNUU1pRZGxZMEFmekc5TWRJTGpOVGNXZzFxRDNzaUdm?=
 =?utf-8?B?Y2gxc0tGUjV3YzBoa0tQdWFQdWlmMzcrdnFrNzQ3dUlpTnZybmRlNlVLeC9a?=
 =?utf-8?B?ei9zRnRSY3dRKzhKSTFubUdEYUNUUGxXVGxXbUhpSnEwTGlUdmhwVkw0L0JF?=
 =?utf-8?B?S2xJQ3RvUDRUdk13Q0huVW5GcTR4WHVSMlBVN1d2dVdtRVA2WWR2VnViMnNP?=
 =?utf-8?B?bzB2TFgzbEZnUEZKeHBDaVVySmdXQm9Kc2t0M293VUlQNlA5cmNTYUxQMCt0?=
 =?utf-8?B?YjM4VUs5NEZQb3QvTm5NZ2FBeWxYL2crZE1QYmo2bndObkF0MlMzdFJRRkxV?=
 =?utf-8?B?Q2QwYWRiU0UyZzBWbWRldmtPenBHNjJuZDBGWDFjWHVDL2V5ZDJxUUpnTHJa?=
 =?utf-8?B?Sy8rbW4xZ1l3bDhWK2JMbTQvYUNoZ2FiOUJzN2xYZGZSakdtS29FbzhYZ0pi?=
 =?utf-8?B?bHVxWDdlak1sQ2xjQTZCNi9hOUdLbmZ0Q3lCYzJGQTFXMTgwTG5XMy9QWGRS?=
 =?utf-8?B?d0dEWUdDSzVWSzVvN2FJblB3dDdUdElvM0I2cENrTzJGVUkwTDRBRVEyRDA5?=
 =?utf-8?B?T0tpQWVQTk9kWG40RzFRQjQ0dSt0RlpjQ2QwS083eDFLem5RRE5GV3lMVk1a?=
 =?utf-8?B?YTAydmNWbzdlUFZUaTd4OVNqTzRtMDhNazVqNUpFdkFCbHllZmpjWXBTNS8r?=
 =?utf-8?B?MElKWjlzUDEySURtRk0xUnZ4WitRYnUzeWpzUzBaazFlRnBoWkI2RlVlcVhH?=
 =?utf-8?B?SVBiaE9QNmRXbng5Qnc4d1Z2bldiMjhHNkRsbzhNa1RRRWF0OWFFajRJY2cr?=
 =?utf-8?B?Y0xneWdOdTlnc01GOTNiNnJ6OTZWRlhibHNWNDY2WTVFQXV2V21SZVFpNTNy?=
 =?utf-8?B?L1M5UWtCWXpzTFcwMWhIYU9vc1RMMlNVTmZjNlZOWjZjejlWNlo2c0c5WFcw?=
 =?utf-8?B?VmdGOTFaY0ZzbFg1MFVJN3Y3VmJNaEttdnRma2RpTmUrMUNVcGpUcU9GVmhN?=
 =?utf-8?B?RjhzbHM1Y28xK3lYR0ZHdTlVbk04MVZDUzA4Q1VtWVQxTWhOMnJRRVFpZVZS?=
 =?utf-8?B?aG14UFpwVHUxQ24vMHVlRWdtUGhSQ0Myd0dkRUZnT1VRejJFNnZ6MzNuMjBj?=
 =?utf-8?B?dS82VFoxMFVrcUZlazR0VkFtUTdyUjI2NlZWTkFyTkhGdFRwTmdGd1V0dTd6?=
 =?utf-8?B?N0NYUWhNWlVVQjdzUWt1NkliazFjalJObmRaeUc5ZE9SeTZybzQ1R2RDVHJo?=
 =?utf-8?B?QkhYVXdQM2QwVlIrTThOelhzd0VtV3l3TG5RVEhJYmhFZXlVdWM5bjY4bVJ2?=
 =?utf-8?B?Q05USUVvOWYzYm9hYWR1OE5CdDFlTUErNGkyemJySTVxMng0YlNQUGlNNk1o?=
 =?utf-8?B?TDNQWkorVE1DaW1WdkRQUXQzdG9wMkxmdisrNk43RzVyOWRkQkd5ZkJ1NzZM?=
 =?utf-8?B?Q1BTeFQ3dTJ3WThqcmpPNVJ5ejR6eVlPWi85RmZXMFB5MVlMMTNLS0FBQmYx?=
 =?utf-8?B?QlBMTjQ0aFlYSFlHK25UNDNLMU0yd2hQQksyZGtyaGxSakJYWHlyUktrUVBn?=
 =?utf-8?B?Rm5MbHFhMmx0aU45VnBxeWZRclJKSHhWVmttNjNwcFowOW44bkdscGFDT1Bv?=
 =?utf-8?B?Um1HSkVvQmdCYWlROVl1UnlrTmFpbUM1SVFTQWN6NjVMaEtBUjZVUUZwQkx1?=
 =?utf-8?B?d1AydmJoUndPWHhDTlhZc2dlamtGY1JqNnpyU25xZ0ppY0NrajNGNnhXTnAy?=
 =?utf-8?B?Uk9aUXVOTkRJaVMwejdESW1aYlNCM1lmQms4WXJlbk4vTDdYTEpneDhQays5?=
 =?utf-8?B?c2xodmVWVmxwV2EyRGlFQnRrKzJDR1dXaElydkYxYndnU0QxUFNvV2hYQ3h2?=
 =?utf-8?B?dXh2VGducEp4c0R6ZUlJZDM2VWg5cVNMUXhjQVNNbUF5aVBxdkxvNWdSUUMz?=
 =?utf-8?B?eGRYYkVvNlIzVyswdGg0WURvbzdNZ3hEV05aNnMwdllBQTROVUJiTFkyeWFP?=
 =?utf-8?B?d1N0OVQreVNmdEF2NUVGdlNxS3JudUw5UDhTWkZaSTZFbFdVcGM0c1B1Yy8y?=
 =?utf-8?B?MmQ0OWpPdmRDYmg2U1hQUkVzbyszdEloUkprOUxzOVB5aHgrUy83NzhtaTFM?=
 =?utf-8?Q?uiPjV/LDfXu8jpcwuxB2OBuGY?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: add3ce66-c105-422a-b5c2-08dbc13472f8
X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6607.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2023 21:38:41.6226
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jfzR9Z3HBn+GrRB8raPeyYakoFidMw0lqZsN/AJTIJ8YPb4lI0ygOQbjFd6UDaYqLD77hyMlIQwcPnsgqEB9NQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8881
X-Spam-Status: No, score=-4.1 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 29 Sep 2023 14:39:12 -0700 (PDT)

On 9/11/23 2:44 AM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> Using any of the GPIO interfaces using the global numberspace is
> deprecated. Make it clear in the comment.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> This was part of a wider series but since this is independent, I'm sending
> it separately.
> 
>  drivers/hte/hte-tegra194.c | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/hte/hte-tegra194.c b/drivers/hte/hte-tegra194.c
> index 6fe6897047ac..9fd3c00ff695 100644
> --- a/drivers/hte/hte-tegra194.c
> +++ b/drivers/hte/hte-tegra194.c
> @@ -407,12 +407,15 @@ static int tegra_hte_line_xlate(struct hte_chip *gc,
>  		return -EINVAL;
>  
>  	/*
> +	 * GPIO consumers can access GPIOs in two ways:
>  	 *
> -	 * There are two paths GPIO consumers can take as follows:
> -	 * 1) The consumer (gpiolib-cdev for example) which uses GPIO global
> -	 * number which gets assigned run time.
> -	 * 2) The consumer passing GPIO from the DT which is assigned
> -	 * statically for example by using TEGRA194_AON_GPIO gpio DT binding.
> +	 * 1) Using the global GPIO numberspace.
> +	 *
> +	 * This is the old, now DEPRECATED method and should not be used in
> +	 * new code. TODO: Check if tegra is even concerned by this.
This use case is to do namespace mapping from gpio subsystem to hte. Few doubts:
1. What does deprecate mean here? Does gpio subsys not use global space anymore?
2. If yes, what GPIO number is set when it comes from gpiolib-cdev, as based on that I may have to
reflect in the mapping, tegra194_aon_gpio_map for example.
> +	 *
> +	 * 2) Using GPIO descriptors that can be assigned to consumer devices
> +	 * using device-tree, ACPI or lookup tables.
>  	 *
>  	 * The code below addresses both the consumer use cases and maps into
>  	 * HTE/GTE namespace.