Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Fri, 29 Sep 2023 10:14:52 +0300
From:   Dan Carpenter <dan.carpenter@linaro.org>
To:     Deepak R Varma <drv@mailo.com>
Cc:     Bob Peterson <rpeterso@redhat.com>,
        Andreas Gruenbacher <agruenba@redhat.com>,
        gfs2@lists.linux.dev, linux-kernel@vger.kernel.org,
        linux-kernel-mentees@lists.linuxfoundation.org,
        Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH] gfs2: Set error on error path
Message-ID: <72de9c2e-7c60-4930-acfb-556a1f0fa4c4@kadam.mountain>
References: <ZRZrUMzweaJeEJuD@runicha.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZRZrUMzweaJeEJuD@runicha.com>
Precedence: bulk

On Fri, Sep 29, 2023 at 11:44:40AM +0530, Deepak R Varma wrote:
> Set the error variable inside the error path on failure. Saves
> unnecessary variable assignment during normal execution.
> 
> Signed-off-by: Deepak R Varma <drv@mailo.com>
> ---
>  fs/gfs2/bmap.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c
> index ef7017fb6951..93bd8ea34444 100644
> --- a/fs/gfs2/bmap.c
> +++ b/fs/gfs2/bmap.c
> @@ -162,9 +162,10 @@ int gfs2_unstuff_dinode(struct gfs2_inode *ip)
>  
>  	down_write(&ip->i_rw_mutex);
>  	page = grab_cache_page(inode->i_mapping, 0);
> -	error = -ENOMEM;
> -	if (!page)
> +	if (!page) {
> +		error = -ENOMEM;
>  		goto out;
> +	}

It used to be that the other way was faster?  I'm pretty sure the
compiler can figure it out these days.  Please don't randomly start
changing people's prefered style unless it's drivers/staging/ code.

regards,
dan carpenter