Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp59752rdb; Fri, 29 Sep 2023 16:48:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IET42avWR9kdWrI5tEnIOpGek692qfiQfEV7MKPKbX3ioYYNm8jRoKMNLgf/gtiA0QgVWJ1 X-Received: by 2002:a05:6a00:2d88:b0:68f:c078:b0b6 with SMTP id fb8-20020a056a002d8800b0068fc078b0b6mr6286417pfb.10.1696031331854; Fri, 29 Sep 2023 16:48:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696031331; cv=none; d=google.com; s=arc-20160816; b=grSu9GJWz2eBaOM/VNJcLeHYUZcCyHVpp8tWM+6PzzWrHGI0t9L58F5a/BBvPxK1bX 29doi6Div5gRCp5+4/6+rCPsTKwlJrH57Of6KXJN7DwwzSoCeRdP9R4lhmtwdappKlIp xhgVmWPu2QKiYZPKhHb1XIbkVOaR6CD2sIzkZHnxZ0fUeC105FH0OznoqXNyF4fypSmm n3AmRj0Lg5TeCbYYNIhwoyLU8Lpu3euPN27eFVkaNqyXltO+zXk3FdWtsGvf/Kg09ffq +0jtdb5n/xeMerqtsU5icxnWcvGTQC3H5HRiZaFqrAxBMQ3MzTyvueZB6tftj22ufFXy 4m2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Ym+ucW6MHQZimVVr4/aWJAbaMhbjuFeNaLImS0cTOp0=; fh=tRjSnD/n6wAkkpFki4zAOoCuA1rneAkv9xvzVJ5xAXU=; b=inUHACqCFZqBKDxjSbNTeULaVTGJa1N3yUgzFIJFCKYNq0gnyBtp4/kocqP8t7W1Y+ j3q0sOu6DfzGIa2Q/cyZ5n/w57I2BpG1aIgRjNn8LpOsRlIuQfk9wcE8I3GOkLlGFyPT q85ts3GjnqnhXPkrM1+KDLPjfkQGtwY2jCrlanntfV+ABdGJwcbOxrSiB9coQ5m1v3aK uC6sgs0nExun8CqarSLEIMP97PkXlAWA7TafZCHZkUCgqc2Wmf+e3D3KrcVAivQdVTf3 p86+F61QT4JvlEXQeC7cNXUWsg5DXIuLu66o9ANKEYcIcw2C+HmS3XU8sROSqiT20Sxq 6dzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="Ht4/tCNg"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id y35-20020a056a00182300b00690f191430csi23456220pfa.56.2023.09.29.16.48.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Sep 2023 16:48:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="Ht4/tCNg"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 5CC90807CEFB; Fri, 29 Sep 2023 12:34:21 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233327AbjI2TeF (ORCPT + 99 others); Fri, 29 Sep 2023 15:34:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233051AbjI2TeE (ORCPT ); Fri, 29 Sep 2023 15:34:04 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 913EB1B1 for ; Fri, 29 Sep 2023 12:34:02 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1c3f97f2239so130733145ad.0 for ; Fri, 29 Sep 2023 12:34:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1696016042; x=1696620842; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ym+ucW6MHQZimVVr4/aWJAbaMhbjuFeNaLImS0cTOp0=; b=Ht4/tCNgN1L3tVISKcmwPVO9AoScXv+MedUTFwXVzmbds2hWBrAjSFNgM8T5fMCf8J AJ7KvjpUO2PR1iH4upbwCJy5A05lVCzlhUPVbNJD+B6t4pQs879bEEt+UG9XXGvItIYW hXrMwPqATE9uohsuicBuVcOutF3V032+1LT5w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696016042; x=1696620842; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ym+ucW6MHQZimVVr4/aWJAbaMhbjuFeNaLImS0cTOp0=; b=fRQq8RSOlMZjtLwnJOa2XlvjXFpoaT/rsC1t4hmDIbd8e4k4p+UCOmCDAzJpBiIMdF HmrkGMzz0BM1SAzoKl6pKiZv6CeEndHjg6gQk+qhPGNUWIuzBjrsU4ugm24o0RSS65tt DdbMa0Bc9FwOC0V6ZVTPsCDwHj5hf3bPtHcBn+oKjRNy1sS9L/Kzo/ihYxP9zJwNtpvC 5MhRUTJpzBFRJUxA+dUK7xAPQpgTGH+BZnTPvcXqhIetJqNaF0bH/0m2TXNssSFI06jv ym6wxpvRveKwN5wmjUeZ6J0cUHHp9Nw0vMTOR8fwIOZVYXasFMX6DA8LhmKiOgBlBX1Q ReXQ== X-Gm-Message-State: AOJu0Yx5N3GCaFNFVOCiN3i7CX6YM2x7fmbPkTTfaUJ/KL/PRomJko8Y lxz8D8UqwrkYYUeCVbtHf7J5Qw== X-Received: by 2002:a17:902:d2ce:b0:1c3:ed30:ce0a with SMTP id n14-20020a170902d2ce00b001c3ed30ce0amr6082275plc.19.1696016042107; Fri, 29 Sep 2023 12:34:02 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id b5-20020a170902d50500b001b89a6164desm11405783plg.118.2023.09.29.12.34.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Sep 2023 12:34:01 -0700 (PDT) From: Kees Cook To: David Airlie , Kees Cook Cc: Emma Anholt , Evan Quan , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , "Pan, Xinhui" , Daniel Vetter , Xiaojian Du , Huang Rui , Kevin Wang , Hawking Zhang , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Chris Wilson , John Harrison , Andi Shyti , Matthew Brost , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , Bjorn Andersson , Ben Skeggs , Karol Herbst , Lyude Paul , Maxime Ripard , David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Zack Rusin , VMware Graphics Reviewers , Melissa Wen , Nathan Chancellor , Nick Desaulniers , Tom Rix , Le Ma , Lijo Lazar , Yifan Zhang , Prike Liang , Lang Yu , Tejas Upadhyay , Nirmoy Das , Andrzej Hajda , Neil Armstrong , Kuogee Hsieh , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org Subject: Re: [PATCH 0/9] drm: Annotate structs with __counted_by Date: Fri, 29 Sep 2023 12:33:24 -0700 Message-Id: <169601600138.3014939.8511343741428844249.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230922173110.work.084-kees@kernel.org> References: <20230922173110.work.084-kees@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 29 Sep 2023 12:34:21 -0700 (PDT) On Fri, 22 Sep 2023 10:32:05 -0700, Kees Cook wrote: > This is a batch of patches touching drm for preparing for the coming > implementation by GCC and Clang of the __counted_by attribute. Flexible > array members annotated with __counted_by can have their accesses > bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array > indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions). > > As found with Coccinelle[1], add __counted_by to structs that would > benefit from the annotation. > > [...] Since this got Acks, I figure I should carry it in my tree. Let me know if this should go via drm instead. Applied to for-next/hardening, thanks! [1/9] drm/amd/pm: Annotate struct smu10_voltage_dependency_table with __counted_by https://git.kernel.org/kees/c/a6046ac659d6 [2/9] drm/amdgpu/discovery: Annotate struct ip_hw_instance with __counted_by https://git.kernel.org/kees/c/4df33089b46f [3/9] drm/i915/selftests: Annotate struct perf_series with __counted_by https://git.kernel.org/kees/c/ffd3f823bdf6 [4/9] drm/msm/dpu: Annotate struct dpu_hw_intr with __counted_by https://git.kernel.org/kees/c/2de35a989b76 [5/9] drm/nouveau/pm: Annotate struct nvkm_perfdom with __counted_by https://git.kernel.org/kees/c/188aeb08bfaa [6/9] drm/vc4: Annotate struct vc4_perfmon with __counted_by https://git.kernel.org/kees/c/59a54dc896c3 [7/9] drm/virtio: Annotate struct virtio_gpu_object_array with __counted_by https://git.kernel.org/kees/c/5cd476de33af [8/9] drm/vmwgfx: Annotate struct vmw_surface_dirty with __counted_by https://git.kernel.org/kees/c/b426f2e5356a [9/9] drm/v3d: Annotate struct v3d_perfmon with __counted_by https://git.kernel.org/kees/c/dc662fa1b0e4 Take care, -- Kees Cook