Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <38ce7f36-a31f-8519-6a65-74d8d172ddf0@intel.com>
Date:   Fri, 29 Sep 2023 15:31:35 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v3 1/8] selftests: Add printf attribute to ksefltest
 prints
Content-Language: en-US
To:     Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
        Shuah Khan <shuah@kernel.org>
CC:     <ilpo.jarvinen@linux.intel.com>, <linux-kselftest@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <cover.1695373131.git.maciej.wieczor-retman@intel.com>
 <c6031eeffeb5d5e3b0b639f4b2aaf7fefd75fde2.1695373131.git.maciej.wieczor-retman@intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <c6031eeffeb5d5e3b0b639f4b2aaf7fefd75fde2.1695373131.git.maciej.wieczor-retman@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z1NVbnlkNUtqL0lWQ3k4NW44TnJucVVWZm1sQlQxdlRwQ2xFNlRHRTM4N05O?=
 =?utf-8?B?THcrUVE2cUNNVzhzUHpnSHJTd0xCWUxmQXR4WnRPUXhyaThrNkRLUVdRRmIv?=
 =?utf-8?B?ZzNwY0VTb1MwTDBKYkk3dWhJcEtnMVlDWUppNm40Y2U1R3NLdVV4Wmd6ZzR1?=
 =?utf-8?B?Q28wcVJVbmVTM1QrNXgxK1UzUFMvMkRGd3llR05HY0dFdlVCZ2VTN1Y1b2ls?=
 =?utf-8?B?bEdWMkxTZ0NHbXdLYWRXaS9tS2xDR2h3S1RiU2cvMWxBOUxLeUREVk14V3ht?=
 =?utf-8?B?OUV6V05PMjVDL2JYd0tjMUVKVUl6d29tNC9rYlBGRDJHVTZpbEI5ZmlzRXpq?=
 =?utf-8?B?ZW5SNHdXVUJpcVBwb25PTEZTVlVxaUpJb3lyM29kUHpsbnM3c012S3JXT2RI?=
 =?utf-8?B?VURXWTVRS3d6cVBzVkpna2RER2FHZzVXbXI4Ty81RWE3dGozOTkrbDZDRkgv?=
 =?utf-8?B?c3hQSTg4dmdrWXlYZGtMMGkyTFdlc3UrUE13dmpVMTVyUUhJcG00c1l0ekY0?=
 =?utf-8?B?KzUyano3WmdqMFNZQktKNlcvNXRJQzJBTFFnUnkyQlFaSjBUSmN1V3gzVldt?=
 =?utf-8?B?RWo2bzc5OGpOOUw0cXd4RTB0NUs4ejhqckw0RU13empOWGxzdHdXSXR5UFpq?=
 =?utf-8?B?VkdhUjRMWTNuRW93VG02T2tYZWpReU9FSHNJdnQyZ1FnU2daVEU4M2xMazI3?=
 =?utf-8?B?QjdNRjNoMjlXMFppakY2emV0YW1BSDZQOWNCaVJqSG01T2h2ME9rM2VMYXg0?=
 =?utf-8?B?YU5NOEgzcTRrTHlTYkErRkY1QS9zUWRYU0NOWStGTjY2b1Q1UTV4WkhEZ1NV?=
 =?utf-8?B?dnRZN3BpOEdxZ0s3Y3BLZEJ4SnhmT1U0Sk40WUdYTG1yMkwrWXdLU3h2SmhL?=
 =?utf-8?B?cHlQUWhQTUx6YitmWFl6Rklqdk9uT24zVUNxQ1JxK0pQZUhDemNIWEVRaVpX?=
 =?utf-8?B?Z0hCOU8zREtNUlhFR0ZXRGc4TUV3OGs4SEFib3kxWjZPNDE3ZmlsT1dCTlVh?=
 =?utf-8?B?dXJTVFF0UHp6aHdNek45a2hxUVlMSWI0REpnL2loS0xmVHBjM3Y2ZU9hMnJp?=
 =?utf-8?B?OGt5N2hUdHd0MllCb2c1YWdsVFNoK1FIVGord3hZcm1nbGhTRjg5elJsZERN?=
 =?utf-8?B?YUF0RU1MTlE5b3NWWnBxWEFxVktQUkxPKzR3WmhoZmd0ZU16cWtJTWJIeUI1?=
 =?utf-8?B?RnVNblhQZEFMdExPRkRncEphWkdxUWp5OE0zN2llMjB4RmMrTGNZY0VsdG1n?=
 =?utf-8?B?YnFyWCtnNUZSOS85MENON0JNdzZpdHhwcGxmbG1HVFE2R0UvazN4NmVENFRy?=
 =?utf-8?B?MG1LLyt1aGlNc2FzWkdxVWhtL1paaVNLb2Y2WXBGZ0dybk5QbC93Z3lXZVE4?=
 =?utf-8?B?aFpRQXZZTTYrTmg1NmVBY3J5ZklYWEo1dkRGUTZOSm9xR3pZOTVHblgrQ2lj?=
 =?utf-8?B?ZkxjUm55NWE0aUE0YU0yeTBBNzNQTUx6LzZpODFhMUNIU0NQKzNJSjBFZFo2?=
 =?utf-8?B?enJiQWJ5M2owZWtBMDBuNjdsbmRWM3U0L2hKQmE1eEo5TDRqcmpiTFJFTGVL?=
 =?utf-8?B?M1cxdzFCZlNxZzhBQzVQb2VjTUtjMSs1RUU3MXRLK2x6OVZMNE02dTRCaTVL?=
 =?utf-8?B?UWkrWmJkcng5Z3NRYVB0UE9QZXlIZzNHZjNENStDMW1lM1l3Y1VmUU9PdEp3?=
 =?utf-8?B?NCt6UlZnTlZpQkhtbWRIY2tPa0pnbE5MTkNobFNrNTY2MUdZVzJKeWh6cHl4?=
 =?utf-8?B?OGZpUWkrd25RL3hZSS9oMXNSVjQ2QVRwcnVxcVlpUjcrcVhIZkV6M3ZsYkNB?=
 =?utf-8?B?QmdER2t2QVlBaVdFUnN1czY1aTRnQ2Z0bE9uamI5L01nOUJsWk95eTNFTk50?=
 =?utf-8?B?ekc2WmhiQXZ2QkhRK0kyOVZpSzRHc1pUMlZSOTBYZlJEcmJNUXNDSkp0cksy?=
 =?utf-8?B?YWtiMlRRMWFER3MwQlBOeVlGd3FmMTNyeC9aRlNqc1pVT3d0YjhxM1pXQUIx?=
 =?utf-8?B?eFNzQkpxL0RTcHM4Z21xeHRMTGVOd2MzNGx1dWZ3dWNDRklDMEhpNkxhUzBq?=
 =?utf-8?B?cW1TazRNT1lHVTN3aUFxRnZ3bTE4THZRZmN3eDVTamhONndHbkZvQnE3UUZY?=
 =?utf-8?B?RDQzMTJwbHNHcXBuUjBNaVB5QzFGcHlCN2dUM0taR0kvVk5lN0lkQzV6NzFP?=
 =?utf-8?B?NEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4aa9e858-9af3-43f2-63c6-08dbc13bd8aa
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2023 22:31:38.8239
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9p5ZmeVSl8zdeL8Ox9E/oHCVA4dB5CK2DND+EdfAOXSyxvQmy55574aUPnKcQwHmQ5RHQx7GWTtvU+0s5/sIBngVijYUG+a7d6MQLxEmbpo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4763
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.1 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 29 Sep 2023 15:31:54 -0700 (PDT)

Hi Maciej,

In subject: ksefltest -> kselftest

On 9/22/2023 2:06 AM, Maciej Wieczor-Retman wrote:
> Kselftest header defines multiple variadic functions that use printf
> along with other logic.
> 
> There is no format checking for the variadic functions that use
> printing inside kselftest.h. Because of this the compiler won't
> be able to catch instances of mismatched printf formats and debugging
> tests might be more difficult.
> 
> Add the common __printf attribute macro to kselftest.h.
> 
> Add __printf attribute to every function using formatted printing with
> variadic arguments.
> 
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>

With typo fixed:
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette