Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <41ad0c01-93f3-67eb-1695-43446d2eb438@intel.com>
Date:   Fri, 29 Sep 2023 10:19:45 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 3/3] cnic,bnx2,bnx2x: use UIO_MEM_DMA_COHERENT
Content-Language: en-US
To:     Chris Leech <cleech@redhat.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Christoph Hellwig <hch@lst.de>,
        Rasesh Mody <rmody@marvell.com>,
        Ariel Elior <aelior@marvell.com>,
        Sudarsana Kalluru <skalluru@marvell.com>,
        Manish Chopra <manishc@marvell.com>
CC:     Nilesh Javali <njavali@marvell.com>,
        Manish Rangankar <mrangankar@marvell.com>,
        Jerry Snitselaar <jsnitsel@redhat.com>,
        "John Meneghini" <jmeneghi@redhat.com>,
        Lee Duncan <lduncan@suse.com>,
        Mike Christie <michael.christie@oracle.com>,
        Hannes Reinecke <hare@kernel.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230929170023.1020032-1-cleech@redhat.com>
 <20230929170023.1020032-4-cleech@redhat.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20230929170023.1020032-4-cleech@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2lMeHE1VjRJeGFJUDh4bG1mVDNrM3dqVC91NktXNTcwNWMrS0xGZXFYTGZM?=
 =?utf-8?B?ZE9YTUFMVnpRRmViQTB2OWM0ZU13eXdMV21ZRXZjbzN6R0ZkZjM1cTJSY0Nt?=
 =?utf-8?B?dXF6c0l6QVJnNTVrbmRmaEZlWGFvRlN3UXMybDVzTlEza1Y0TnhoNFE0QUQ3?=
 =?utf-8?B?SXE3OTN6MUFDR1dEaklRUXFZTDJhaTlHclJEenBqWGw2N1FzTytTSllFS1ll?=
 =?utf-8?B?ek5NV3JtRmdiUTRVOFRzLzhlQ3VkMUtzVXlJbitlOHQ5R0FIeU1QTlNhbnVH?=
 =?utf-8?B?em1mWUZocXVpN3crL0IxWkQ0WmxpMWFYNnVpTzlTMlh1NzNkQmZoaFZwaWpv?=
 =?utf-8?B?UDFaTm9QbitscFRremlFL3NkT1hzT0NrL3VuNzdsOFFkRG5mNzdrZVhRbWxS?=
 =?utf-8?B?QXNqM1JHaElEU3hwT3Z2UVUyS3RUWGpVVGEraGZtVWhoQ1ZxL1poVXhsNGJM?=
 =?utf-8?B?VjRMbHJzNHZXMyt2aGt0WjVXRHBjelBJRGJ2Q3h3U0t5SGxjbW1zamNmSDMx?=
 =?utf-8?B?b1A1enVlNzF4TFdwWkNJaTdLaG1ydWJ4RkE4ajUxUkVSeENiK0ZFNGRxQWlX?=
 =?utf-8?B?dll0RHNlbm5ibGhwTVNTak5CZGtMZVNlUnEvYzlkak9DRng5K1V2dzl3U2dl?=
 =?utf-8?B?YWxmNzNuYVNKbzhoWXpOeldmRmdoQityQ3ZRemF5TmVObi9wVTVjRERPYU1r?=
 =?utf-8?B?NmVZMitZaHV1QjBlMVNSVEswcUNzcFpGYWVZQm1MWk9aTFlKSVBSTWt1RmFl?=
 =?utf-8?B?emZRdW9NQVl4ZWNiZGd6VG9FdzNiQUhjT2M4K0cwZXZpRFoxbTJwQ1ZOOHFv?=
 =?utf-8?B?RWJuS2hrMi9Fb2FNRUhjMHRvRVJFTkNnRkpTK1hGNDNGbW9vNkFVUzVFRDJJ?=
 =?utf-8?B?UnhOck1ESW5pSGVkTGZ2THV0RWhxS0ZFQ0NwZUxsM0tDcXowaUZiSjVhTzFH?=
 =?utf-8?B?eExnekt0YUxjQXlQcHZsdGdaZWJ6anVnam1CSGNNN3VWYy9LK2lncWNrZnRm?=
 =?utf-8?B?ckU2SkR0Y2lMUFBXT21EWWVUWlJGenJjM3ByNlVKZEM3LzA2bVo5U0FRVkt4?=
 =?utf-8?B?TEdJcHBQQ2s0QkRpZWlweGhmMmxua2ZaUU45aVR2WXo2OFAwdDNFTklnWGFt?=
 =?utf-8?B?emUvdWV6N1ZKWTk4UWdEOVIxdGdEYlJHOXFqM252cGt4bG85UVJOUUZGYXRH?=
 =?utf-8?B?N0dqTCs2bllTWjh5dHVkVkxjZVR0VGRKdnlGRXJPb3dRbUdMeSs3SXhPMkwx?=
 =?utf-8?B?bFFYMUJlZ0xLekJ6N0ZOc3NHZXlxb2Vnamx0eDYyTFNzSHJLS0RZdWJJYWwz?=
 =?utf-8?B?OTAzMXREV2hFbmVVOTJCRWxyNVlMV2cyZmpFVWVNd1A4MHdqNDlBWEZoaG4v?=
 =?utf-8?B?UWZSNjF3NUZjMWV4RmhNOEljaDZ2VG80ZkkyQ0RybDIxZld1T0REK3RHUUN3?=
 =?utf-8?B?MzlsYkFpbng3SVNsM3M2TzFVNVYvcjBZUTRKZ0dLdW8zVkxaRDlqZnpjek1D?=
 =?utf-8?B?SHdEUXFyVlVZbXRscFNOQzFycjBEOThnMFZWb0xLcnhLRUcyRTNvQzl1dkZG?=
 =?utf-8?B?NmhuMm44VDdDejRHSzJHZTh0MXFTeWRhT3BPOVdLU1B6RHdaVXdmRW5CMXZv?=
 =?utf-8?B?VDlYRmpZYnpLdWVPSFVYOTB1RUk4UXBBL0pKZnRnVUdFWllNTVBacjJhK0M0?=
 =?utf-8?B?WkRpRUdwTzNKVGVQNXQ4Q1VQTTdBZW92SWNqRTR3UmZqZGYwaUtsMzdjTysw?=
 =?utf-8?B?TmRDN2c0MVFaZGZNTktHRDBuZmNpaXB5ZFNDMTFZdGcxMVYrRUNBSHROMXhr?=
 =?utf-8?B?RkJTOHorVkhZVzNEblJmN25IQmw5cVJOK3Yvb3V0WGhDS1lEUmpTNzFYaUVu?=
 =?utf-8?B?bUVhSHlOOVF5T05xTGlwMmZjZGpLaHd6TkszS0hqdGNuVGROZjZXeDFsZVU5?=
 =?utf-8?B?MnFUWmp0VmcyVlhhcVNGUTJtZk96QTFBdjJWR1dRSkw4Ulk5bXMwcGxteElP?=
 =?utf-8?B?TTlySSsrTCtrV0Z4b3Jnem5oN3FMUGNtWHNmNmlPQlRGQWp2YzhWUjBaUlBG?=
 =?utf-8?B?Wm15bkZDWFRwWFdIaXh0bktiQkVsK1FGbEUwZ3JWUzlXTmRraGt5M1JldDJO?=
 =?utf-8?B?eFhtbXJwMW9hTE5FM3BXTVJSYmMwMG5Cbi95T1hiOStKWTEzbk9kUXdITTNy?=
 =?utf-8?B?dGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 487240bd-5c84-4c5d-7ed0-08dbc1104871
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2023 17:19:48.3095
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YP5dYl2WvGescORXI41PTp83feo6Nn+VkbbOr56tVWM+B+djB7UYAoDlQfrIuk2rF7MwLsggR7FWDMM3+jQEoLMpa7ov5zYr2ibjVNxVYHw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB7078
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.1 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 29 Sep 2023 10:20:03 -0700 (PDT)


On 9/29/2023 10:00 AM, Chris Leech wrote:
> Make use of the new UIO_MEM_DMA_COHERENT type to properly handle mmap
> for dma_alloc_coherent buffers.
> 
> The cnic l2_ring and l2_buf mmaps have caused page refcount issues since
> the misuse of the __GFP_COMP flag was removed from their
> dma_alloc_coherent calls. Fix that by having the uio device use
> dma_mmap_coherent.
> 
> The bnx2 and bnx2x status block allocations are also dma_alloc_coherent,
> and should use dma_mmap_coherent. They didn't allocate multiple pages,
> but also didn't seem to work correctly with an iommu enabled.
> 
> Fixes: bb73955c0b1d ("cnic: don't pass bogus GFP_ flags to dma_alloc_coherent")
> Signed-off-by: Chris Leech <cleech@redhat.com>
> ---


Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>