Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp83777rdb; Fri, 29 Sep 2023 18:00:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHzJL+IMqx+Sk+jQedwXFVMaVPrWcyiQF6NNBppd1IKGkrYJe/7SbanzCTXKqJSQThunI3k X-Received: by 2002:a05:6808:188d:b0:3a7:1962:d7ff with SMTP id bi13-20020a056808188d00b003a71962d7ffmr5457806oib.57.1696035646613; Fri, 29 Sep 2023 18:00:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696035646; cv=none; d=google.com; s=arc-20160816; b=ibbBe2cq143gtgkIGbQqjFktOE1N4tJQpE+Ue6USqjHUc9HgWwqkBG7wzUV9/mdhBa NZEi3Hy0yYqPaA+woFE02nLFaqZS9S+Vp4jKmaWNk3QJtJLutBWmTi954w1gQeHYtNb7 PvNgFHmV+MFRbeZBQJA6/PonJYqjRS5mELJjahGoTQe0y2FdfU8lNjHi4IiLSaD/Cz1u JTPZ0LaWEv2M6uTdaTMPqRKgy+heqjEEGyX7fQ2oe548xCqfgVj1QPzrmAwj1M+szDXg 1PoBgzM1hFoWL1FnAWvtu38Ns/PvX8T0PhEvzln21uL+yQytc56nX+L06G4Px1tXheXO l6Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=ZVXBaUdZuWKwijDr+1t4ohaYkGxEB+hc3BtA9q2v7ZI=; fh=42XEGADkVne2dvOQPpURp5Q5VONQBrE4mxEXYtqY5WQ=; b=T1G+Ibid+M7b6ia+3aiigP7YrCEyHGG7xEo8Jldfj0moVyyaSZHYPbhi40ucSTkwwK A6w7UmG0OEDtlnKhA0CeT9c7RfX8Jbun9FjPcSMr2w8tJzNWGX+7I91pRo82jdKdryyL ZcmqEPzIb8ucHkIImM+/MOPvP3so6tU0DKSs5E0MJQfTNyrnpp/Hs2USkffYpzQHZeip QIVNYz+C7TH4hf/z8I0PWGbW6aiFB54dpTzeEE9l8Lw3VGh2OPrPf2KEp9qpMWkUO7sg 0rK6Hg+fOXj6W7zon5YEUKSJoLozHFqzhWAU1OsHm0weSvXOAvW6k3gwCBk6U5YwOsV9 2Q5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qe5t48Ex; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id u29-20020a63141d000000b00578acf1e8a3si21818355pgl.576.2023.09.29.18.00.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Sep 2023 18:00:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qe5t48Ex; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 94298869EAD9; Fri, 29 Sep 2023 04:37:19 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232912AbjI2LhN (ORCPT + 99 others); Fri, 29 Sep 2023 07:37:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229687AbjI2LhM (ORCPT ); Fri, 29 Sep 2023 07:37:12 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4105D94 for ; Fri, 29 Sep 2023 04:37:10 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-536071e79deso1256461a12.1 for ; Fri, 29 Sep 2023 04:37:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695987429; x=1696592229; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZVXBaUdZuWKwijDr+1t4ohaYkGxEB+hc3BtA9q2v7ZI=; b=qe5t48ExZtypK/sqfe7cP4Q1HWnZ2my7oY95CApe8I9zZvOgYf79nKh7rQfk6X/YR9 upjeCWC/673Iw90SdzLWzTug/BuA4RAuaae3vGyUQMlz0r5A973nzaWY2xpNKeCyEy7k gAxt7Mq7CJwx9GWSi4gq8Db1Bb/4a9WpHGsYLzus8HkT2joT2/J8PC+s1D2DE8GYqzKp mN54yYcE0ZVLEwUYI9TWyH/elcUv/6b2TCJjo/Ontenu5XA3p7J7eepJraWhT/t43rGe ypzMjjv/NQDYaZA4WOfKtettQZkkdD0GgF6XQt++SodrUfflCzJsEcyxw1NPWNnBPle3 3dEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695987429; x=1696592229; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZVXBaUdZuWKwijDr+1t4ohaYkGxEB+hc3BtA9q2v7ZI=; b=MkezHN77pdKv22WKG885CC3HVHWIHkHzTw1c0cYppiXeyICgslXTZvX0CS0rFapGfe RNIk6afuDylpR48TvbFIGqH5JWO4mjiL2Dey3r7422utNFCGah0nWAByHX1jok9vzeO/ WzOnaY4pcWpbQkuP3pfr8S04O918tpdpw+xt5ql3fK5su/nlefjCCrcpXnvecCgbcuAZ jHNeul0g3l+ILI+DzMhzONYAgENsfTU1UlEeMnxHT4xyKYdHQWm4aARqpXwyHetTUY+f 9Hg3lvDn/qS1TQug/D8AYd9aRIS7Pkp2orjHyYgbIoxjqeJjoIp3xblMD8NIdoJoKeMY Bp3g== X-Gm-Message-State: AOJu0YxrdhyGCRWY6ZZ/DeOodnZi7P1tclSbM6TWXSS3hU4ZJyVpJgDd tTkCuSESmP/yyX1Tbo02YPSqNgqWxGYGtYRyx8s= X-Received: by 2002:a05:6402:50c8:b0:536:169a:4ac3 with SMTP id h8-20020a05640250c800b00536169a4ac3mr3257371edb.8.1695987428732; Fri, 29 Sep 2023 04:37:08 -0700 (PDT) Received: from [192.168.33.189] (178235177217.dynamic-4-waw-k-1-1-0.vectranet.pl. [178.235.177.217]) by smtp.gmail.com with ESMTPSA id s16-20020a05640217d000b0053420e55616sm6595226edy.75.2023.09.29.04.37.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Sep 2023 04:37:08 -0700 (PDT) Message-ID: <0e760d7a-f855-4e45-ae6d-9ea376ed6860@linaro.org> Date: Fri, 29 Sep 2023 13:37:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] media: venus: core: Set up secure memory ranges for SC7280 Content-Language: en-US To: Luca Weiss , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , cros-qcom-dts-watchers@chromium.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20230929-sc7280-venus-pas-v1-0-9c6738cf157a@fairphone.com> <20230929-sc7280-venus-pas-v1-1-9c6738cf157a@fairphone.com> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <20230929-sc7280-venus-pas-v1-1-9c6738cf157a@fairphone.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 29 Sep 2023 04:37:19 -0700 (PDT) On 29.09.2023 10:38, Luca Weiss wrote: > Not all SC7280 devices ship with ChromeOS firmware. Other devices need > PAS for image authentication. That requires the predefined virtual > address ranges to be passed via scm calls. Define them to enable Venus > on non-CrOS SC7280 devices. > > Signed-off-by: Luca Weiss > --- The media tree (or at least venus) moves quite slugglishly.. But looks like applying just the DT patches (which I expect to get in first) results in a non-platform-killing: [ 25.851120] qcom-venus aa00000.video-codec: Adding to iommu group 11 [ 25.851618] qcom-venus aa00000.video-codec: non legacy binding [ 25.916562] qcom-venus aa00000.video-codec: invalid setting for UC_REGION [ 25.916569] qcom-venus aa00000.video-codec: failed to reset venus core [ 25.919000] qcom-venus: probe of aa00000.video-codec failed with error -22 So it should be okay either way. Reviewed-by: Konrad Dybcio Konrad