Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <01d3a02b-7104-efe2-15a9-b62f85772ddf@intel.com>
Date:   Fri, 29 Sep 2023 10:18:30 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 2/3] cnic,bnx2,bnx2x: page align uio mmap allocations
To:     Chris Leech <cleech@redhat.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Christoph Hellwig <hch@lst.de>,
        Rasesh Mody <rmody@marvell.com>,
        Ariel Elior <aelior@marvell.com>,
        Sudarsana Kalluru <skalluru@marvell.com>,
        Manish Chopra <manishc@marvell.com>
CC:     Nilesh Javali <njavali@marvell.com>,
        Manish Rangankar <mrangankar@marvell.com>,
        Jerry Snitselaar <jsnitsel@redhat.com>,
        "John Meneghini" <jmeneghi@redhat.com>,
        Lee Duncan <lduncan@suse.com>,
        Mike Christie <michael.christie@oracle.com>,
        Hannes Reinecke <hare@kernel.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230929170023.1020032-1-cleech@redhat.com>
 <20230929170023.1020032-3-cleech@redhat.com>
Content-Language: en-US
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20230929170023.1020032-3-cleech@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dW1xZGt0aUFkTUJKQktMNUxCOUl1M3ZVS2h0UWZwRlFHeVpkVy9RWWhFNENN?=
 =?utf-8?B?Y2RRSXJseHdjMkZsNlhhdXVVODBoenJkcUs2cUtpK0piUVRjSjVnV05TRHVn?=
 =?utf-8?B?T0JSdlNaeUx1c1hCRGt4TEJqS1V5d3hDckFhaDdXbWN5cEIrSmVrRjZRWVBo?=
 =?utf-8?B?ZjdBSkxqa3ZWSmlVQTRxSTJLNU1YOHFHRFlQcjJJYkdjbkt4ZWZWQjZaZ3J5?=
 =?utf-8?B?bUFIMWRDVVV4NEExZGNmLzdmdnJpZFhuT0RqY1V1MGkyY3djOVpHVzNMY2l5?=
 =?utf-8?B?MDdpM3BVeC90cCs0S3VjekVpNTBpQmtRdUhkdTlkRFJSbzMxRkhxWkRiYito?=
 =?utf-8?B?bno5RW5CNkhtcWVwbzZkOGxaQ29uNnhKclEyOWlTR0NtQXVTNjV5b3BCaG8r?=
 =?utf-8?B?TkdiVTNCQ0lEeEFwVFg5ak1HTVExRmZGUEhzNm9CazNyaEI0WktZam54S2lz?=
 =?utf-8?B?ckRSRG05alNWTHdmTi92ZlpNaXVHNTdqaFdIUC9OUGxhTDFQcmJPQ0RNVHZD?=
 =?utf-8?B?MWZZTnllRkRtc2ZjcDFMdnBSZFJSUG8rVmczbHg4eVFGZHYrak05OGFtSHNQ?=
 =?utf-8?B?V3U4Z2ptTjV5N2hmeThLZ00wTjk3Wm55YWJSRGI5eFNNUU8yOVM4NWdRajRJ?=
 =?utf-8?B?akM1RjJXcGZISmd5NjAzUEF1Q0VFOHVRSmtvV1Z2SzUxbkh4dWRlS29HK0F6?=
 =?utf-8?B?OElRTy8wQXUxNEVQQi9VaU1aSVg5bTRxQVErTU0yamorZTQ4RnJaUkRnTUtS?=
 =?utf-8?B?YlFDVzVTaXpYK1dVLzlvcFZhVkpiTU5EcGJQanBabENEbWV3RHJFNlVMU0Y4?=
 =?utf-8?B?emxNT2kzTUs4NnRKQ0N3WllGTi9IalliYUhYemEySzNFaUVQWU9PYVhwNlda?=
 =?utf-8?B?ekswQTBJa1h6UUZLcDBxRDkrYkhSUHhUL1BxU1FQa2grRGNDb2VITWRZYlgw?=
 =?utf-8?B?WjQ2cUtVb3lETUgzN1U4S2V6b3BLWFg4ZFF1TmxkNXVIV1JpTDNCVnFSWUpC?=
 =?utf-8?B?MEdzRnNNME5GdXY1MzNMQTByNVpvdktBUTBrUmk0RDB0VlZoaCtUZThZRUs4?=
 =?utf-8?B?bVZyMHZOczg4V1doU2JxNHpOQnkyb24yZ0h4Y3QxYXRQd0tCK1RhS3pNTXlU?=
 =?utf-8?B?dUVYclMzbldHbzdvVzdFeWp1MHJjdDVSS0tEVmpOb0pFQ3hlQ3EwZnFNcThj?=
 =?utf-8?B?VlZIMnBjREs0ZXFwdkFYWEVleWE3bHlrUGJoendWOFZkQUlHWjFTam1Ya2VP?=
 =?utf-8?B?OWsxZVViRmhxNUJ1SjRha3dPOVdkNnRRQnR6SVZtbmlQVTlrUSsxREJ2ckhW?=
 =?utf-8?B?eHd2c2l6T2JxeGVENEhJUWYwb2cyaEdCQS8yWnBqeHcwU1lBRER4b3MwTnQ0?=
 =?utf-8?B?blBLRXdnbFBwYzRpY1hOQkFlSnY5ZktOL3hkWTZ4YWszYUhBcVAxS0xiSTFS?=
 =?utf-8?B?YitQZXg4N29kb3VxKzZNRFVqL003S0NuN1FaSGFrVEk3WHA1YmxkdGNydDNH?=
 =?utf-8?B?T1RwTVpFWXF5YjB4N3pLN3JTSEFBcWJja0xBZmdhSHVJeGU2dVQ5REUyZGc5?=
 =?utf-8?B?NUlXd0pXbk1KaDZxdmhObGg3SE9ydHMweFZKT0owUzlYWTBUc1J5SUFuUWJB?=
 =?utf-8?B?NEplcFN1YzVTa2RTc2dYTVJ2T0FCbFhsM3JzbUltWkNtZDhmTi9wU3lRZ1g5?=
 =?utf-8?B?UFh6T29jODZYZWFLOHd4aVhwc0J1MXFwV2hhUkYzLzhEV2o4VjFRU09EZDlp?=
 =?utf-8?B?bDk4UGxmdlFCcmNZQ2FvUXNjSmZLZHNCS3ZGOHZtOTV2Qy9PaGV4STM2VWVN?=
 =?utf-8?B?eDN5dndxZmpLR25hTlJqWmYrcGxxQS9oOGxla0NwREoyemhTczIwYWhydE5z?=
 =?utf-8?B?V1FaWXlPSVFOUm9objh6cGRZYXFxWDNUc05oTDVlc0lERVR3QVdLYnJ1cE5a?=
 =?utf-8?B?N3hEVkVySXhiQlJHcHlTaVYzMmlDSU8vS2U3VmpiSXNyTGZNYytDT2lMd0hO?=
 =?utf-8?B?UU81Y0x0TkVQd3RWUWpLNW5RQUNJaUdDRkxkTFJ1QmEzNkZqUVlDS0ZEYS9y?=
 =?utf-8?B?amxvM1A0Q3d6d21YeGVKa1R2ZW8vb3hPUXdoVVhJb016NzcvT2JNeUFoeTRw?=
 =?utf-8?B?LzB2ejNVenE4SW9FQjFoNzF5Y3JQMktwM1RrRVh0djRRb2FKN1Mwdkl5TUVY?=
 =?utf-8?B?T3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b3a7ed42-cb79-453f-9eda-08dbc110223a
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2023 17:18:44.2054
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1dErCdMDmqX1wMxTfpKRSelVbp71V3zLR95w3JfZz1QqyYV7zrBoNQZmIXOV2GL9AWKEiUJpgW3ooYjEAhtBuhD2Ui5Ze9rkUFDYsvCPkU8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB7078
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 29 Sep 2023 10:18:59 -0700 (PDT)


On 9/29/2023 10:00 AM, Chris Leech wrote:
> Allocations in these drivers that will be mmaped through a uio device
> should be made in multiples of PAGE_SIZE to avoid exposing additional
> kernel memory unintentionally.
> 
> Signed-off-by: Chris Leech <cleech@redhat.com>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>