Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
From:   D Scott Phillips <scott@os.amperecomputing.com>
To:     linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Bjorn Helgaas <helgaas@kernel.org>
Cc:     linux-kernel@vger.kernel.org, Len Brown <lenb@kernel.org>,
        Darren Hart <darren@os.amperecomputing.com>,
        patches@amperecomputing.com
Subject: [PATCH v2 1/2] PCI: acpiphp: Allow built-in attention drivers
Date:   Fri, 29 Sep 2023 17:20:35 -0700
Message-ID: <20230930002036.6491-1-scott@os.amperecomputing.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RxXA6rdtVzza6CX3NsRZhsq+HQeucyNQ24+U//TSzo0PFAXAXRyaSO3Tygu6?=
 =?us-ascii?Q?8p4KSuSKMfaS0DDAx7LtHZ8pSIn3OqoD7GLsE1k1RMArOnR0uowG2d9zhxP0?=
 =?us-ascii?Q?YUO+69MKHKI9Q9aeE/jCiCl49cid8CDX7qfo5p2JIQUQrzCrV77D88CXxKly?=
 =?us-ascii?Q?rJQwmiVHoDXu0Dpg2NlJpNDlpRP1sVEkFhUBelatbyPyFCavWZWdaGmM98td?=
 =?us-ascii?Q?gmIzujTMpFLqb85sxqZQXxBNmZrYeJ0hmTV9EFGqUtPSPZIvnk0UCBH5upgq?=
 =?us-ascii?Q?upfQcXfIydFFIX5t/Ta9stXRTYS1WW6lVB2Y9tc8wxh/VfLBLa1DMr0YQq7m?=
 =?us-ascii?Q?BJQ81pZWr8A6/jF9m/gUeIsRJkqup7jDyrxutTR0m3ImH5M2G9JpHYHYHkL8?=
 =?us-ascii?Q?3H93Stss73q6+/7h528H80rbG9T8MGgetUsA/UM40ntI7iail70BtULDW/pC?=
 =?us-ascii?Q?e1NqlkP5DcMvQ8PV+2/cWqUzjje1vkus8/UL4j/PG9PD3CT6hpXwhtiec0On?=
 =?us-ascii?Q?X+HIUKhHo3WErfwRbT+hGVSVEeaVM88SiqRxd1rh9WYaJtXC+oKM9K2R/ng/?=
 =?us-ascii?Q?ZOQ4umD67tQXZSvUankgEOjlBVjdpAc1UwUmwftZ/RCieDlOBjQ+bB/siUp4?=
 =?us-ascii?Q?05QaAKw8M4WVOmxk+cZKGa+YycWIUfnHbAC9YB1Z93aJbr0uXkdHufGNfAlg?=
 =?us-ascii?Q?RL7M/RRUjUYPnViOK7MVPd66Gcmw1YkqIrw+oBC5YSPTsBmZuH433Z2O73vm?=
 =?us-ascii?Q?R8AzusHdVi0h0VEBDFNDcw/L7OHghV97+cdF0NJWWSTJ977tFq6B68YEqqMM?=
 =?us-ascii?Q?zk3iaM3bW3HLciUYANi05SNVtriAN5njF47NMvrP2vUeDnxidrNFI2Iw2S4S?=
 =?us-ascii?Q?kgL7Fex91Y9D3y9oJpkBcitSGziT6IBQKRNtwia5EWxuGHdQlz6Nr8Nmw5i1?=
 =?us-ascii?Q?AYsN8TmXLqOBS+Stri7lMmSg0jjuxgZrzwgGZcFiSD5Cb64V3DgIHlkxIYc+?=
 =?us-ascii?Q?wrk4X0hhpw2/66HZBLKT7H8BVMP5krl5XU6sYmGQOg4XJPMCdD3Zn47q7Tsa?=
 =?us-ascii?Q?4AzLHznDKHLQFJO7nLCIuA3M0uDkWvdM8Z0Vc1EWsdf5MALRmR+ktG85V6AN?=
 =?us-ascii?Q?1FWvbF2R2MLtVaZPy/emW6iQ3sJerFmiuAGDr0nO3ccu7bXuMup9JNVa2lgt?=
 =?us-ascii?Q?W/aPirhkoOg6ydhFbKsjvN5aLxhT+sBZcNHMmw6RtEb7iyMjpSmlj51+xJ1+?=
 =?us-ascii?Q?ZlJezDFy46QVnzAC6canePGBV31w8xL4OYfgVaT9Sscr4EAdUejah8VJB2vM?=
 =?us-ascii?Q?1p50+JmcPo4/FHuyqesk87z9x37RC+DJYLA+M4pnY6k3wTrlf7+2L2BTI1Rp?=
 =?us-ascii?Q?L6zlhDTjCnLoklLAlFOppFgDiMZKBRN9jfxTRjM7dIq9aWM6XJfrtkBaq/q7?=
 =?us-ascii?Q?WsvuTL7epuzlsec7eth88zdT9OwL+lBlVn6awQFkvjWw6TE7Rz3gUJhTn4Ar?=
 =?us-ascii?Q?CfgiqvHT3NCLxshCNpUxAPndJTcQ+e1LTeTGD5xaLKNleNKZXCLSp/hwR/zA?=
 =?us-ascii?Q?bf0F0ULTbjkNKBryBIPtfFLuXlu1bdqo1LA+GkZYw+vAQ3LeqC3Z+vGCQyyw?=
 =?us-ascii?Q?yw0i1/aUusSF9UfI7CNT+C0=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b3b86ef-1511-4106-f3bf-08dbc14b13c0
X-MS-Exchange-CrossTenant-AuthSource: MWHPR0101MB2893.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2023 00:20:40.3450
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OBVUcF+exLBrJ+Q8Q9stLjpABHb+A9mIdfoZDapwrpdeD/B7j5CQNvg+pXRd9ohs9eij4/Ytvvvp2PO1S4Owxi/5DzvT3f8Vo7TLMemfaJEMbHTdsSclFLnqhPljFga7
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR01MB7553
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 29 Sep 2023 17:21:01 -0700 (PDT)

Starting from the introduction of the attention callback in acpiphp, a
non-zero struct module *owner field has been required in
acpiphp_register_attention(). Then intent seemed to be that the core code
could then hold a refcount on the module while invoking a callback.

This check accidentally precludes the possiblity of attention callbacks to
drivers which are built-in.

Remove the check on `struct module *owner` in acpiphp_register_attention()
so that attention callbacks can also be registered from built-in drivers.

Signed-off-by: D Scott Phillips <scott@os.amperecomputing.com>
---
Changes since v1:
- new patch in the series

 drivers/pci/hotplug/acpiphp_core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pci/hotplug/acpiphp_core.c b/drivers/pci/hotplug/acpiphp_core.c
index c02257f4b61c4..9dad14e80bcf2 100644
--- a/drivers/pci/hotplug/acpiphp_core.c
+++ b/drivers/pci/hotplug/acpiphp_core.c
@@ -78,8 +78,7 @@ int acpiphp_register_attention(struct acpiphp_attention_info *info)
 {
 	int retval = -EINVAL;
 
-	if (info && info->owner && info->set_attn &&
-			info->get_attn && !attention_info) {
+	if (info && info->set_attn && info->get_attn && !attention_info) {
 		retval = 0;
 		attention_info = info;
 	}
-- 
2.41.0