Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <c01f684c-8b4d-1032-5e32-d9fa910d473e@intel.com>
Date:   Fri, 29 Sep 2023 10:56:33 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH net v2] net/mlx5: fix calling mlx5_cmd_init() before DMA
 mask is set
Content-Language: en-US
To:     Niklas Schnelle <schnelle@linux.ibm.com>,
        Saeed Mahameed <saeedm@nvidia.com>,
        Leon Romanovsky <leon@kernel.org>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Matthew Rosato <mjrosato@linux.ibm.com>,
        Joerg Roedel <joro@8bytes.org>,
        Robin Murphy <robin.murphy@arm.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Shay Drory <shayd@nvidia.com>,
        Moshe Shemesh <moshe@nvidia.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>
CC:     <linux-s390@vger.kernel.org>, <netdev@vger.kernel.org>,
        <linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230929-mlx5_init_fix-v2-1-51ed2094c9d8@linux.ibm.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20230929-mlx5_init_fix-v2-1-51ed2094c9d8@linux.ibm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OGI0MC81UUdTMDJnRnZkMlFPMzBnM0Fkb05wRlVIaVFNUS9OVUxTblFuVmdj?=
 =?utf-8?B?SlB4alhkVks3OG5aR2NMY3FaVWFIWCsrNEtiWFVVQjRVSEg0Ujk4M01XcGp0?=
 =?utf-8?B?R2FwWTRFOExFcTZWeUNJaVMxNWpyYUlJUzgwN0Jha2w5cmZkYVpEVU1EUUJ6?=
 =?utf-8?B?aUlZSDZkK1U2VnVRWGlFMEZtUzhMc1dWcks2SmlOZ1h4Qk05ZW5sVzVtZTNN?=
 =?utf-8?B?Umc0UGJ5UDU1Uk04RUhkcnZUYXk0aktoT0ZwSzFyd0pyK1BseWtuY3pyckVR?=
 =?utf-8?B?UWVzOXAvVi81K05VTUd3d0laNHFLaEt0b2hxTDdnTEtkVDMyN3pUZXFneC8x?=
 =?utf-8?B?ODYxKytTcEIxWStYRTJkaUVIb2laU2xaTGNxWkdQZHdZbnF5cWZEVVVrSVU4?=
 =?utf-8?B?QmVYWHBuVnd0bjdTUWhSUTdzM3hhaytIUDF4eHZSVFA2dURmZXRtbHBua0lN?=
 =?utf-8?B?dTFpbzU1SUxUc3prTHZHZEI4STRCWTFlWWJFdUlsUnlqaFpIQzZTNU5pUFVy?=
 =?utf-8?B?K0tSRHJMUXZMSURIeVllV0czN0RKc2F1bjM2R3M4TW1mSGRCaDFqOVZaUE5O?=
 =?utf-8?B?Tkxyb3JrVWw5MHBnNmRFd2hKSS9JOGRldlBoQUVweUFYVXVTbStsNHozZ0Vv?=
 =?utf-8?B?TmVGZ0VVUm5LdUdiZkFsdXN5b0RCbzcyUHIvOVo2a2VONmJheGM2VnJzaWhE?=
 =?utf-8?B?YUZNd1JNYWhFaEgvMHF1SGR3MVA2TFh1eDIyUXYzeGorYXhjT0hUTFJhR2dZ?=
 =?utf-8?B?QmZxNitaVXFKOUJFOGV5WGJZS0tSWjJTL3FGZTRmTGpGVkZFSy9xK2hnOFVF?=
 =?utf-8?B?UDlob2VteHpYLzdFWFphcHVOVlRHNEE5NVF0ZEQyb2VHV0FMWHdkWmp4UmFi?=
 =?utf-8?B?QWdSVzY0cG9sczZIdEFhQklkdE84aGRZeHMzdFZYTVBHUEdMMXlkdndVSy9m?=
 =?utf-8?B?R3g3a1lULyt0MERJODRaektpSHNia0J3cTRXellid016dDhCUGhZTndyTkNX?=
 =?utf-8?B?aW9sMUp6Qk15VFFDTlBBcWI3RWxZL0FOd0RUaEVsWE5pN0lEVVY4ZjUwWnlr?=
 =?utf-8?B?MVFJd2Z6dE1WUlVPYzRCNkhtaXdUZjc3Uk5Ha2EwdUV3Z2NDSk9oQWFHTjBO?=
 =?utf-8?B?TmpjTEc4eEUrS3EyYkp1eWZaeWFndmxGM1diQ2xqYmZkSVQvMDJjSTQzRGpq?=
 =?utf-8?B?NDNKQnQ3dnVuZEloa2xUR2k0NWZlcGRNTUdwY3lSK2JRcWxqY0x4SC9KOEhw?=
 =?utf-8?B?enM4SXY3WVordmNHQmdxNkZmM2lsY3RiK3VQcG9oZ2xHTnZzdDNodmlSYkxi?=
 =?utf-8?B?YnBpL3dySU5sSlRqYSt5c09Oc1hjd2pBUnRUTEM1ZEx6RlVJTVIrQ2RQTGZn?=
 =?utf-8?B?UWxuYytSR0NpaGZUNlJ4cTBDcVVRS1AyZW90OXREUjNlOVFwTS9mSDc2NUZ1?=
 =?utf-8?B?ZytXSGh3VXdkTkhTWkk1aFQxYTFvY1lGS2kydzNORjluNWtkNG9oRDF0TDdu?=
 =?utf-8?B?VE8wZDZsaVFQSHh1VTJSR1dib3g1c2dZSGZBeDRnaGNyQnJGVU82ZDRhQU53?=
 =?utf-8?B?UDBXTnFGU1FPNXBtdDlyd2krNnZFQ3R5emUwYUhCc1JaSlVQSE1rOUhSaUFj?=
 =?utf-8?B?b3RseXg1MXVzM3dxcnhwS00rOHRmRkJ5aEkvSUFVNGVScEw5YTBma3RoQmw0?=
 =?utf-8?B?cW5EclZqdlMvVmhxUEV2ckN6TkVUMFlwaTRqVElUd1ZzbUVNKzdBOFZod2ov?=
 =?utf-8?B?OHN5RFB0cytDTTlmTnU2WnpCZHlYa250NGlyRDJ0STNmVzBXb2dKbnluRkhF?=
 =?utf-8?B?b01aMW80NVRaYkc1ZmpKMVNaRDFWa3h6WXprZ1BXVHpwR004bXZkWGR5ZENT?=
 =?utf-8?B?MUdpY3JqRE9COWVtMytmNnp6Um5vTy9NcXQvUUl0dEsvaDJLVERneWxSd2I1?=
 =?utf-8?B?ZEJXNDdwVU54NGZENmkxd3kyRjFwTG5JL1BMYmc1cExFM0x2VGFvZEMwYTNY?=
 =?utf-8?B?MjJSRmJRUUN5bzB2cTZoZmxEU1padDRRVjhTc0VxcnJacmVRWlVBZWlhVnFw?=
 =?utf-8?B?TFhvWjZLUXBzWU1hRk9qUS9Da0N3UFBnSms5TkpXY2cxREk2c1QwbTFBbkZI?=
 =?utf-8?B?Tk5RU01VSjZJWUJ2ZEttQXlXNnJNaktEaTEyWXk1RG9RTFFvQldHdlE0bjhh?=
 =?utf-8?B?bGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cc568815-c9eb-4862-7899-08dbc1156d2d
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2023 17:56:37.4755
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FZiIEdX8ekzmp4TsblluzVABZsLHWifevLAsDxBcdcNWJNzhf/gmNIhzoIMy0guDPhyDlGq+/49X7Hv0nCOzdc3dLdb6+RrIsAyHCegGxaU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4984
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.1 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 29 Sep 2023 13:09:32 -0700 (PDT)


On 9/29/2023 5:15 AM, Niklas Schnelle wrote:
> Since commit 06cd555f73ca ("net/mlx5: split mlx5_cmd_init() to probe and
> reload routines") mlx5_cmd_init() is called in mlx5_mdev_init() which is
> called in probe_one() before mlx5_pci_init(). This is a problem because
> mlx5_pci_init() is where the DMA and coherent mask is set but
> mlx5_cmd_init() already does a dma_alloc_coherent(). Thus a DMA
> allocation is done during probe before the correct mask is set. This
> causes probe to fail initialization of the cmdif SW structs on s390x
> after that is converted to the common dma-iommu code. This is because on
> s390x DMA addresses below 4 GiB are reserved on current machines and
> unlike the old s390x specific DMA API implementation common code
> enforces DMA masks.
> 
> Fix this by moving set_dma_caps() out of mlx5_pci_init() and into
> probe_one() before mlx5_mdev_init(). To match the overall naming scheme
> rename it to mlx5_dma_init().
> 
> Link: https://lore.kernel.org/linux-iommu/cfc9e9128ed5571d2e36421e347301057662a09e.camel@linux.ibm.com/
> Fixes: 06cd555f73ca ("net/mlx5: split mlx5_cmd_init() to probe and reload routines")
> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
> ---
> Note: I ran into this while testing the linked series for converting
> s390x to use dma-iommu. The existing s390x specific DMA API
> implementation doesn't respect DMA masks and is thus not affected
> despite of course also only supporting DMA addresses above 4 GiB.
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>