Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp140367rdb; Fri, 29 Sep 2023 21:16:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGXrTmo6q1Mv+5d6yYqyLq42GjyekDMVRsgUW7kUWBDNbNCwhDJLJybOj4wzeiu/wuGj98D X-Received: by 2002:aca:170f:0:b0:3a7:1e98:80ad with SMTP id j15-20020aca170f000000b003a71e9880admr5667289oii.9.1696047403445; Fri, 29 Sep 2023 21:16:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696047403; cv=none; d=google.com; s=arc-20160816; b=oy3MX/VtSfd8SPofiaSn7wYQETbV980hj9cg98NWBsxRVHkTMlaFPYubWzL4jVoJVL FDAlHl6QGYPIzrphLeoScIiP08bT1sgiwqEN6iwRyvuCA2iYEF4WVl1bRLkko4ABTuaw sv0LNLfIFaJf1DUoFGw+RBg70F7NOJm/PCMVAXSBUXPPSAN5uKtKJjtGTbRYA8ps52BP LwJoljy0X3doIKj1GlP1YyuIGOxctbjDXvuveat0Pde9qPNlMRLMKURONy1MwobT1xS4 puHey4B3JhADUo9x3l34l7nYD/adz9kbvKVr1d8lRKBm+c+WZgY8P77lbP37fn5kd71o ZxuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=0XNfTrzi672XAwZhbUqUONDNkdEIxKx4yalZBquNodc=; fh=ptkWKGWlQNIik+BEoFpIdNhogIbzLH4KDmABrVZ+/f0=; b=X23pvAyaMi3p6QNlG7N2vN8mStSRxDWwByoNzGY6m0LGMO0FGMULat+3wU6TUHnBLe hPmAN8FU92VrCEh2ZjChqYm31bwIaTKmGkXXl17GYHoBdE2y5hVT9Z9tJnNt8oMrCWn7 RdzqrnZWdmyqs71vnuAFyRpZpond+GvTXUCFNZHQC+G3yLcq00tUqTCHnE0bS+JcOpKR VCuwhReGGaEjAPc6aGNh/uWmmLUfuQIk4I0Fe9/6VuXddwDZZsqiwyvDtm7HxJDdjcmL WYqRSTNmJ/7EkV9HqCaqUxkRgBGMIqMA0M1LmL3wDzy428kYdfF/MnNEAsnKp8uqUH3q PsWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="MSTxC/8j"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id j73-20020a638b4c000000b0057823b96685si21903355pge.681.2023.09.29.21.16.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Sep 2023 21:16:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="MSTxC/8j"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 2B8CD82848E6; Fri, 29 Sep 2023 13:44:16 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233735AbjI2Unj (ORCPT + 99 others); Fri, 29 Sep 2023 16:43:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233602AbjI2Unh (ORCPT ); Fri, 29 Sep 2023 16:43:37 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D6961B0; Fri, 29 Sep 2023 13:43:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696020215; x=1727556215; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=k35CTLxwYNMJbh/KVFe+2nbeQOog2WQUMF7Mb5YVfcw=; b=MSTxC/8jy7Wx5WcqAW3dxFbwzZcElwJfPd/RAy3oYSshDHcM8G5UvPxm CuCSdTFXOAxeqIqVRGRvp0Os4QZbTqLOBU5l5UIQWApE7PPlpv76BYRDS bzzS6crDQkx2lE5khDScKii/JlWPO1Sr6XA79SrVySO+MVeWiIm3TEoeu So6h89lKTdabRRkLLfUPYq/31fYkovfGd8J51gRA6LnsDj9fRrrLDJpgN qUDopfVoJfKo4LDzJuEm9OiJRZDrZ+A/fN2lwF6tGb7KbCnZvoRsd5OSk F7cJw7hcZ1N2m1Agx5i1fzHNg0Nf5i3Q1y2Qn+JS1YQwht4nJi1ZGO812 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10848"; a="386237611" X-IronPort-AV: E=Sophos;i="6.03,188,1694761200"; d="scan'208";a="386237611" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2023 13:06:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10848"; a="815695986" X-IronPort-AV: E=Sophos;i="6.03,188,1694761200"; d="scan'208";a="815695986" Received: from agluck-desk3.sc.intel.com (HELO agluck-desk3) ([172.25.222.74]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2023 13:06:15 -0700 Date: Fri, 29 Sep 2023 13:06:13 -0700 From: Tony Luck To: Peter Newman Cc: Fenghua Yu , Reinette Chatre , Jonathan Corbet , Shuah Khan , x86@kernel.org, Shaopeng Tan , James Morse , Jamie Iles , Babu Moger , Randy Dunlap , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, patches@lists.linux.dev Subject: Re: [PATCH v6 4/8] x86/resctrl: Split the rdt_domain and rdt_hw_domain structures Message-ID: References: <20230829234426.64421-1-tony.luck@intel.com> <20230928191350.205703-1-tony.luck@intel.com> <20230928191350.205703-5-tony.luck@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 29 Sep 2023 13:44:16 -0700 (PDT) On Fri, Sep 29, 2023 at 03:44:54PM +0200, Peter Newman wrote: > Hi Tony, > > On Thu, Sep 28, 2023 at 9:14 PM Tony Luck wrote: > > /** > > - * struct rdt_hw_domain - Arch private attributes of a set of CPUs that share > > - * a resource > > + * struct rdt_hw_ctrl_domain - Arch private attributes of a set of CPUs that share > > + * a resource for a control function > > wrapped line not quite aligned anymore Fixed > > > * @d_resctrl: Properties exposed to the resctrl file system > > * @ctrl_val: array of cache or mem ctrl values (indexed by CLOSID) > > + * > > + * Members of this structure are accessed via helpers that provide abstraction. > > + */ > > +struct rdt_hw_ctrl_domain { > > + struct rdt_ctrl_domain d_resctrl; > > + u32 *ctrl_val; > > +}; > > + > > +/** > > + * struct rdt_hw_mon_domain - Arch private attributes of a set of CPUs that share > > + * a resource for a monitor function > > wrapped line not quite aligned anymore Fixed > > > > -- > > 2.41.0 > > > > Reviewed-by: Peter Newman Thanks -Tony