Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <4358da86-1347-cb20-b19b-88982d1f8e20@intel.com>
Date:   Fri, 29 Sep 2023 13:30:22 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v3 0/4] x86/resctrl: Non-contiguous bitmasks in Intel CAT
Content-Language: en-US
To:     Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
        <fenghua.yu@intel.com>, <tglx@linutronix.de>, <mingo@redhat.com>,
        <bp@alien8.de>, <dave.hansen@linux.intel.com>, <corbet@lwn.net>
CC:     <x86@kernel.org>, <hpa@zytor.com>, <linux-kernel@vger.kernel.org>,
        <linux-doc@vger.kernel.org>, <ilpo.jarvinen@linux.intel.com>
References: <cover.1695977733.git.maciej.wieczor-retman@intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <cover.1695977733.git.maciej.wieczor-retman@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3ZZUGZKdmR3c2xHRzlRN24rS3YvQ3RmWmNwUU82UWYxY1ZFNWdHcHM1MjFz?=
 =?utf-8?B?NFVqT1E1TUtxcGhBVHBuOVE3SHUxalZZRWh0MkF2RElMTjkrbi9mM3FMRWxE?=
 =?utf-8?B?YnNweXVsbThUQUk0R2hVMXFDSlhCdno5Z21wbFZJcjZLZzlvejJMWklOU05G?=
 =?utf-8?B?L2NuMFNHRW9US1ZRS2ViVTZ3Z2EzQUtQOWpXelo4b2hLOEJVbXFiYjJwbnda?=
 =?utf-8?B?QTd3cFpJL1k3bmZKcHdTYUw0S3dGRDMyTE11eloyNDZ0clRRS29hamRjS1gr?=
 =?utf-8?B?NVVGUXNScHpLc29veTBRRzZpc0V2eW8zS0ZYRVdCZ01kOWdXME53YzNadjVn?=
 =?utf-8?B?QzRPc1F6S3RFdU1MRlI2My9rekJDeGRHSFYrdHpLeHVrVmxQUzRxa1hUN2tp?=
 =?utf-8?B?ZmxNTnNBKzNqUDVhUHlCdktaNTNZdDVTNlBzL0NlYTZ5cUcvUjBUYno4UFpU?=
 =?utf-8?B?NEJqSVgrL3FCZGZDVE5HSHFXcDI1eG1nY2Z3M3J3TFVkSldibmluRkhDZWUy?=
 =?utf-8?B?WWRmb1pnYzE2dFpUaUNBZ0lxRjJBVVQ0MWtTRjlsNHVYTkZQZVZWVDUybFp2?=
 =?utf-8?B?cW5rQjlVZFo5T3o5bE1sTkFpcm5JZ3NsWVdpMXV5V2VPZURHRHhYUy9FUElk?=
 =?utf-8?B?cEQyRkJpYWRGcmk0TSs0Q0JwbGE2SFZ4aVZ1dnVhOTJQdm9xdXhINzFvbTh4?=
 =?utf-8?B?SDNlTzdDYytqL2JCTGtpRjJrQ2dmVVVZU0xEVXVhZlVKeW12S3pxSnFtQS9q?=
 =?utf-8?B?K3p6aGZyNldJVlRHRUp2UHZYcWtVbk5weEtWWElyVkJjRXJabVNXekRKRzI2?=
 =?utf-8?B?SDhJVnBINERWUEhnRkh1NHg5MjBlSmtWaDcvN3RlVElFOUFoWGY0b2ZTRDdP?=
 =?utf-8?B?cnd5ajQ4NFA2WmhaV0dDei81SGNRNE1acFYrNlRGL2loRDZQYVRoOStVNkJD?=
 =?utf-8?B?ckdhWnZQZUNZakxnSHg1T0V0bCsrc0o0Ri9PbThyVUdoSi9Bd0VpdVdpeGJL?=
 =?utf-8?B?akFBb2JyZ2drZDkrMGU4a1FObFk2QzBUUTFkUi9GakZ6STA5cXhzbkhTN2Qx?=
 =?utf-8?B?eXdpNWNHMkhpaW5PSFlMcU1kWTdjd1NjU3Q4TVVYNzBHb1RXNzVWWFIzWnIy?=
 =?utf-8?B?WUlMVkFRQ3NobGF5Qm1sZUFRYlVqV1ZSUXBDRGlXcnRhcTZaWHZ0cHEvZGx2?=
 =?utf-8?B?ZzlhZmVGeCtQa2RlSXJ0QXRFcFlmdjhZa2RzWW5rcjZ6NWlESjQxalhmUlVO?=
 =?utf-8?B?Nm95SkZzYUE4NnJpcHhtMk4wSmEra1FJWTNzQ21uSDkvZXoxV043aHZ4UU93?=
 =?utf-8?B?OVoraDJueEhOZVo1SG9ybkpBQndtYVRxeXRISGhWZDQvRVpvM0hNRE1QWDlv?=
 =?utf-8?B?QjF5S1F0Q0QwSGdJL3QwanZ6TW9iL3AxSFg0UHloQ2s2bEQvR0RvUTBpcW54?=
 =?utf-8?B?cHJKMUhNT0FaRzRLZTA3WW9QOWFnUlVqMXpmTXhzaWZpSGFvK2gyVE10WDFo?=
 =?utf-8?B?UElSb1YyOVJlR0J5NXM2MFJCRVFadEtLeWozeHpIVmgyN1R5QkxRWGpNa1d3?=
 =?utf-8?B?cWFydnRGL2ltUHlycGdZcDErK05VbmtocEVHbmVQZndrV0FPY1RkWDRiVVdy?=
 =?utf-8?B?UCtzYXhKVUZ2UVVvWWdxaVhvdURUVnZySUhpdHYxT3FqSmplZFM3Z1B0US84?=
 =?utf-8?B?WUpIcFR3cGUxQWVLenFwR3g0RnNaUW5YTTVmaXB5SU9hN3JWMElkMi8ybFg2?=
 =?utf-8?B?VW5VZkQ3Q2xsQWlMSStsTC9ldWwyY24xZGhLS3E5MzQ3RGhadG9sVlhSOXBw?=
 =?utf-8?B?Y2tnVm12a2JsUTJjRm1FdDVzWmN1cmUybDZTNGVUeWJaa3ZmSjF1Q1hBTitt?=
 =?utf-8?B?Ynd3dmpYUW0vM0Q1eGJrS1NzSEo5Y2ZBd3cxa2V6VEtDU1RuQzhUVkNkelFU?=
 =?utf-8?B?U2owM2hNbDNFUEJlc21YeU1WQ1d2Q0JiL1RacGYyaWk3TEVaY1FkRGg3dlM5?=
 =?utf-8?B?UlAxS3pCTThUazUvWVpDRStTRUd2cmFPRi9BakxtQlRSTWJES3IvWUtxR1lq?=
 =?utf-8?B?UkcvSnRXRXY1Y3VRaERnREZXNjFzbXNHV0xZUHBvSUpkOGNkS2lIdFIwdDMv?=
 =?utf-8?B?ZUdndEQ5UmxoRWxpaGFCUzJNTlRRTVZjWk15ZkFIbFZtTFQ2TXRqRWZ3TWVX?=
 =?utf-8?B?NUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5de63d30-ffd3-4fce-db0e-08dbc12ae95d
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2023 20:30:25.2542
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HN0AGg7RuhmcbUOoIFrSqgIA0KzyKobb8vKdfOjULsd0as9PcrutixNyGCj+DAc/IyO/kHrAnYsGCBUpx0t7YjdTEKIoNR5o+fIAF1wAav4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR11MB7981
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.1 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 29 Sep 2023 13:41:08 -0700 (PDT)

Hi Maciej,

On 9/29/2023 2:00 AM, Maciej Wieczor-Retman wrote:
> Add kernel support for detecting if non-contiguous 1s in Cache
> Allocation Technology (CAT) are supported by the hardware. Also add a
> new resctrl FS file to output this information to the userspace.
> Keep the hardcoded value for Haswell CPUs only since they do not have
> CPUID enumeration support for Cache allocation.

This series looks good to me. 

I do have one comment that applies to all patches: Could you please
take a look at the "Ordering of commit tags" section within
Documentation/process/maintainer-tip.rst and apply it to all patches
in this series?

With that done you can add:
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Thank you.

Reinette