Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <3b99e6d9-2bc3-d0a4-fd2d-515f26bf39bd@gmx.net>
Date:   Sat, 30 Sep 2023 12:10:39 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v12 0/6] staging: vc04_services: vchiq: Register devices
 with a custom bus_type
To:     Umang Jain <umang.jain@ideasonboard.com>,
        linux-staging@lists.linux.dev,
        linux-arm-kernel@lists.infradead.org,
        linux-rpi-kernel@lists.infradead.org, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Stefan Wahren <stefan.wahren@i2se.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Adrien Thierry <athierry@redhat.com>,
        Dan Carpenter <error27@gmail.com>,
        Dave Stevenson <dave.stevenson@raspberrypi.com>,
        Kieran Bingham <kieran.bingham@ideasonboard.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>
References: <20230923143200.268063-1-umang.jain@ideasonboard.com>
Content-Language: en-US
From:   Stefan Wahren <wahrenst@gmx.net>
In-Reply-To: <20230923143200.268063-1-umang.jain@ideasonboard.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
UI-OutboundReport: notjunk:1;M01:P0:F9wAkd3r6Ec=;1M0aqMuBvuF99wv47dwfuLX7Qks
 LyCv72m6ulR09k3M3oAOs29TGKrlRmPXqq9WCSdYnU99AjAO0FRwdm/3hgwLSDG0gwtmNsNUa
 wL7u1iuqL6SnjueqdI/+fHvbngjJmnkMov6ly5KP7TTBKem+F3XgHGT3/U0AregUY3JKmqyUX
 DCTcbNeTkiDDK16j5V4DspptYD6C/ydIp5UrzEcSysoAp2+ujxnd7XH8VUVZXB/jBBYrwD066
 sG4PUW3zsoi4hc8NwHfsExTwOHb/S6S7BYcg6txrKFwfQ1SitofQtcfSwUADODEOlCaJ9W48Y
 0v96CvLPDcHpz7Aa0fuKlGFvWjyF9RQJmFc6Q51iFtnuuBH4dSNSYdx6MmPCtMK9KimWmjNl6
 a5ZGwTb7NxFs86WFdx1BN94uLaVvdxh67jQc3wTSdoZVH5JwVoGbEBueRLAAcb+vJmoYji7zW
 JiT/z04hMl8XnvDvdstsXsQDUP6OKVha0d/3bBS+U/nbFF2x6MFFuJmqIsjaWGKVS+zJ5QjFW
 AfsT8eefzdC996ICid832G+nl/x2j8q34+msyq/Z8tK6faKDrFwcgC8FMrUIpLls895ch9TC8
 ukjeXZ1Rf/hUnkl30a8chuTvKg3HuffOqbLmZEx4zT5f0Gn/tE7K7KuCK/0cSEXbs/QGReKBt
 /NSodhuOkPoyeatQclTklsp5HP1LKJ0QVRBkZjmuMLMyIEMuKney0+/PHpspKVfj3g3XVFx+r
 UOr2wAUVZBlGR+2I0JROEm+1pRiKnxV4Vl2qq0yI2YKi+7bIpocKho2zhIs2/FAa3dRNktaw3
 isUtJXRf0DC9QtMPRbwucannn63LIwb07pjo8rxKMPdskBIcDPGCFwmIUF8ktgvziQW5vPcdG
 0fr6ui4uE39KY9OEEK6tZ4M7z2QGkUZydwv4R615SYdMtaIalN8zHxKG2N+GX29uShhKdV3vA
 Y5V9Z/4gCCQbo720dOmF6lh845o=
Precedence: bulk


Am 23.09.23 um 16:31 schrieb Umang Jain:
> The patch series added a new bus type vchiq_bus_type and registers
> child devices in order to move them away from using platform
> device/driver.
>
> Tested on RPi-3-b with media tree master branch.
>
> Patch 1/6 and 2/6 adds explicit DMA mask to bcm2835-camera
> and bcm2835-audio respectively to avoid regression when moving
> to away from platform device/driver model.
>
> Patch 3/6 and 4/6 adds a new bus_type and registers them to vchiq
> interface
>
> Patch 5/6 and 6/6 moves the bcm2835-camera and bcm2835-audio
> to the new bus respectively
>
> Patch 5/5 removes a platform registeration helper which is no
> longer required.
>
> Changes in v12:
> - Add initial two patches to set DMA Mask explicitly to avoid regression
> - fixup vchiq_device.c bad squash in v11
> - Rename vchiq_device.[ch] to vchiq_bus.[ch]
> - Fix memory leak if device cannot be registered
> - Make vchiq_bus_type_match() use bool values
> - vchiq_register_child() helper removal folded in 6/6
>    instead of creating extra patch.

The whole series is

Reviewed-by: Stefan Wahren <wahrenst@gmx.net>