Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp331620rdb; Sat, 30 Sep 2023 06:19:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE/1euEHHaDQF6fHFsT4o4Y26n2wMBu62TM9wYgKSNwh1tW0wuekB7nNsIXpVz226oHKN5C X-Received: by 2002:a92:c5c1:0:b0:345:d58d:9ae5 with SMTP id s1-20020a92c5c1000000b00345d58d9ae5mr6659973ilt.7.1696079956528; Sat, 30 Sep 2023 06:19:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696079956; cv=none; d=google.com; s=arc-20160816; b=YMlg3IpAD8xMA1Z9RX9GaFJk+Bzz4a8RjT+uQgyBEeUNxyUSq0ATuexr7c/oGfEMd8 yaa4bI8vTlc9nSlsNxP/E5TndETlqlzU4wmFEXG1aXPRua48lHSPksSkdI4VTo41V1Fx ePjnbMXHa5ISAaupZAs6A1Fd8TDB8YWjd6/q++MSlTLlZiC1fR0tKO4q7no9GaN4EWqa KjRP/1y6ZOE7UzfWTGc2jh2fogSU7EHdd4pKr84lnr4R562nhK+7CdbI1h9JsDnue2o1 qIf7xSCqZwvkSFqZjteMhEo1s2oKk+88s6ormZ0RDuC2U/9LQs2O07srUsGGNQqMUNbb TfXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ZNBXJ8TTdtjTtLIw3ySSzPSKgoDf8/I61n07F030KGE=; fh=gmN2oeoOLutXe9dKoeUY43S1khJMtEmyTsBKCPf2mIo=; b=ZdxuxNjZMaX1oE/jkZV+johBSM/Sk4JunMLC4ekrW0tp9KJbJDOipgKWQxIKCd4erA a7tfX+cLIAIAHRVlTVnmfVzhDpR187kUjSOwWlVu462/7G/wApC34s+kS7JS/9xUFrw9 c6IgD8ab5i9q1c/l42B+xDzR5Gqn+Uzfu/TL4V13+Byn+lu8Ly3yrUt28unw+7K1mbS+ oA+Z/g4u3XQ5RXvPSOWavWdGowFxG+wggEfG3kz68bM343XSBQi20g1d552I5wKYQRkZ +T6/itWGkUqds3UiRAsHXhqm5FqGsVF9sF1LPrwKKh/Z4x/GmBBj+gKy1aU1M7UBT+nE 17Ug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="prjRe/hp"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id h11-20020a65480b000000b00584a5cd69basi1722988pgs.177.2023.09.30.06.19.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Sep 2023 06:19:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="prjRe/hp"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 8D4A2823FAE4; Sat, 30 Sep 2023 06:19:15 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234102AbjI3NTN (ORCPT + 99 others); Sat, 30 Sep 2023 09:19:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230516AbjI3NTN (ORCPT ); Sat, 30 Sep 2023 09:19:13 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 041A6E6 for ; Sat, 30 Sep 2023 06:19:08 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A41F3C433C8; Sat, 30 Sep 2023 13:19:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696079947; bh=TkJccJDta5ELpn2APXWKrpLmjnFVEgfNbXdHwnS1A48=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=prjRe/hp5ipBDD2VrPfn7Y262AKGszVcJxK1PYvUyF55UjcL9DBoaauzrNri8P8j9 FLAgxmAxBLxiC/wGxLLlcCa8ZQYCKKu71ysKk7vZdukPFg9c28C3UGbcwI7bVKJCMx jcIvGhaPTBydQL2n9niLuJTHP//SHlUTAxLxy0ymYcQbPnbb4Q7bmJWoSKIwhsJ5HA xfp/bsRIFyMzTOL1axA/8DRMKM+7TD1eFyPFYVRZI23wlhd+NtabSELBw1sENEuRMs odu6X7ueSEpUu2W44HurRkb8KmnvhbdFnmQ43YIOxX7KhkycqgcWi42cxc+sbwJFH7 IMKKuH77KCG6g== Date: Sat, 30 Sep 2023 15:19:03 +0200 From: Simon Horman To: Jeremy Cline Cc: Krzysztof Kozlowski , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Lin Ma , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+c1d0a03d305972dbbe14@syzkaller.appspotmail.com Subject: Re: [PATCH v2 net] net: nfc: llcp: Add lock when modifying device list Message-ID: <20230930131903.GA92317@kernel.org> References: <20230925192351.40744-1-jeremy@jcline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230925192351.40744-1-jeremy@jcline.org> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Sat, 30 Sep 2023 06:19:15 -0700 (PDT) On Mon, Sep 25, 2023 at 03:23:51PM -0400, Jeremy Cline wrote: > The device list needs its associated lock held when modifying it, or the > list could become corrupted, as syzbot discovered. > > Reported-and-tested-by: syzbot+c1d0a03d305972dbbe14@syzkaller.appspotmail.com > Closes: https://syzkaller.appspot.com/bug?extid=c1d0a03d305972dbbe14 > Fixes: 6709d4b7bc2e ("net: nfc: Fix use-after-free caused by nfc_llcp_find_local") > Signed-off-by: Jeremy Cline Reviewed-by: Simon Horman