Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Sat, 30 Sep 2023 17:04:04 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Ivan Mikhaylov <fr0st61te@gmail.com>
Cc:     Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: adc: provide max34408/9 device tree
 binding document
Message-ID: <20230930170404.515395b1@jic23-huawei>
In-Reply-To: <f8735a6d81d485eb8e822e4fd55a00269ae688c2.camel@gmail.com>
References: <20230917211143.7094-1-fr0st61te@gmail.com>
        <20230917211143.7094-2-fr0st61te@gmail.com>
        <20230924135359.6404a867@jic23-huawei>
        <f8735a6d81d485eb8e822e4fd55a00269ae688c2.camel@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, 25 Sep 2023 19:48:39 +0300
Ivan Mikhaylov <fr0st61te@gmail.com> wrote:

> On Sun, 2023-09-24 at 13:53 +0100, Jonathan Cameron wrote:
> > On Mon, 18 Sep 2023 00:11:42 +0300
> > Ivan Mikhaylov <fr0st61te@gmail.com> wrote:
> >  =20
> > > The i2c driver with Rsense option for current monitoring.
> > >=20
> > > Signed-off-by: Ivan Mikhaylov <fr0st61te@gmail.com> =20
> >=20
> > Hi Ivan,
> >=20
> > Welcome to IIO!
> >=20
> > Looks good, but there are a few things I'd add to make this describe
> > the device
> > a little more fully and flexibly.=C2=A0 Ideally we want a binding to fu=
lly
> > describe
> > a device, even if the particular driver for Linux doesn't use all the
> > features.
> > Some are easy though such as enabling regulators (that are probably
> > turned on
> > already on your board)
> >=20
> > Thanks,
> >=20
> > Jonathan
> >  =20
> > > ---
> > > =C2=A0.../bindings/iio/adc/maxim,max34408.yaml=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0 | 63
> > > +++++++++++++++++++
> > > =C2=A01 file changed, 63 insertions(+)
> > > =C2=A0create mode 100644
> > > Documentation/devicetree/bindings/iio/adc/maxim,max34408.yaml
> > >=20
> > > diff --git
> > > a/Documentation/devicetree/bindings/iio/adc/maxim,max34408.yaml
> > > b/Documentation/devicetree/bindings/iio/adc/maxim,max34408.yaml
> > > new file mode 100644
> > > index 000000000000..ae7c6ddb13d8
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/iio/adc/maxim,max34408.yaml
> > > @@ -0,0 +1,63 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/iio/adc/maxim,max34408.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Two- and four-channel current monitors with overcurrent
> > > control.
> > > +
> > > +maintainers:
> > > +=C2=A0 - Ivan Mikhaylov <fr0st61te@gmail.com>
> > > +
> > > +description: |
> > > +=C2=A0 The MAX34408/MAX34409 are two- and four-channel current monit=
ors
> > > that are
> > > +=C2=A0 configured and monitored with a standard I2C/SMBus serial
> > > interface. Each
> > > +=C2=A0 unidirectional current sensor offers precision high-side
> > > operation with a
> > > +=C2=A0 low full-scale sense voltage. The devices automatically seque=
nce
> > > through
> > > +=C2=A0 two or four channels and collect the current-sense samples and
> > > average them
> > > +=C2=A0 to reduce the effect of impulse noise. The raw ADC samples are
> > > compared to
> > > +=C2=A0 user-programmable digital thresholds to indicate overcurrent
> > > conditions.
> > > +=C2=A0 Overcurrent conditions trigger a hardware output to provide an
> > > immediate
> > > +=C2=A0 indication to shut down any necessary external circuitry.
> > > +
> > > +=C2=A0 Specifications about the devices can be found at:
> > > +=C2=A0
> > > https://www.analog.com/media/en/technical-documentation/data-sheets/M=
AX34408-MAX34409.pdf
> > > +
> > > +properties:
> > > +=C2=A0 compatible:
> > > +=C2=A0=C2=A0=C2=A0 enum:
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - maxim,max34408
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - maxim,max34409
> > > +
> > > +=C2=A0 reg:
> > > +=C2=A0=C2=A0=C2=A0 maxItems: 1
> > > +
> > > +=C2=A0 interrupts:
> > > +=C2=A0=C2=A0=C2=A0 maxItems: 1
> > > +
> > > +=C2=A0 maxim,rsense-val-micro-ohms: =20
> > From the datasheet you link, it looks like this could be different
> > for
> > the inputs? =20
>=20
> Hi Jonathan, "maxim,input1-rsense-val-micro-ohms", "maxim,input2-
> rsense-val-micro-ohms" and etc would be better?

Sorry, missed this during the week (too many emails at work!)

Anyhow, I'd have suggested an array, but a better suggestion was
made anyway in reply to your v2.