Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp483023rdb; Sat, 30 Sep 2023 12:16:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG1ztbTSk8uSHu8Mf5ZTrASq04XwzqIPwuU0QAyetDtVEBGa0IZSJuc3CeC04Y/WK/W64/1 X-Received: by 2002:a05:6358:2794:b0:143:8984:4ffa with SMTP id l20-20020a056358279400b0014389844ffamr8076982rwb.26.1696101401731; Sat, 30 Sep 2023 12:16:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696101401; cv=none; d=google.com; s=arc-20160816; b=cS5ROJ73YKcNkJiv14SiJgBCHfLlaKci/29DWlBDqTKPNSIkx+N85yDIK7Y+YEyky0 FAGdX6wwAf/VCg0vT7MuPp1o1ETvrufK0kK5URjeQx4TIEDphxCWngaiAls+noa5JCld DtY2wnHDsyMJxbeE7NG8SU0NqCpkgOzCf6j8qjm8aA+E66kqXG5lE6QJ3zVloGDZ2f7b 3Z64w82q2ivIOG3iwN72srIf4m0kbVp9K2YQknOUf5c4/C/r4fz5HJfkaXNpSkjMLtxM oVVCum1LdsXsnyNxRstLa1vCkxrD/leYOHTYNW4Y07Ms9DH738pw3sW/a8347XpTH0Oa E0ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=uEGwm1gu9BypWNEYQ5UW+A6PBfFm0x9wxQyKLCc/IdM=; fh=HCzElfjdAw79VJwTPuLT/8QZsv7MtPddOgpBiXtV6sA=; b=y61fG9piAWm9W2fwvYo8ez1RHYzMV+MRfGTypVCkG7PG28Cv1goBIja3PTSJufU6BO LhkC3GFbE7/3XXeyCgy6E4Jysr/kTl9l4PQJ2XKpCFhP8DNpxI9tkwHsEVxSbAHLGGWC cdAF4Sqr3nz9x8lltICmu9iqVX2pUiKKOsUd9trNN2nic3GW9qHdkvqaRV+EFNr/2tbs 4iCh9krW8mgVSaXAoz/VkNrfBBM9KFYdIt4Q5exuCYaU5Gw+n9twifW3qtqiFds/A7hh b1EWyVhsedFjkDmgqUmeh2r1j9yBJV8VqMWGC9g7c/NvBb9/oyR19pSgahP2ZIpn3s7z qe7g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id g18-20020a631112000000b00578b9064636si23529360pgl.242.2023.09.30.12.16.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Sep 2023 12:16:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 51B1780A8525; Sat, 30 Sep 2023 12:16:03 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234755AbjI3TPg (ORCPT + 99 others); Sat, 30 Sep 2023 15:15:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234695AbjI3TPd (ORCPT ); Sat, 30 Sep 2023 15:15:33 -0400 Received: from hosting.gsystem.sk (hosting.gsystem.sk [212.5.213.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 81732E3 for ; Sat, 30 Sep 2023 12:15:30 -0700 (PDT) Received: from gsql.ggedos.sk (off-20.infotel.telecom.sk [212.5.213.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by hosting.gsystem.sk (Postfix) with ESMTPSA id CC42D7A00BF; Sat, 30 Sep 2023 21:15:27 +0200 (CEST) From: Ondrej Zary To: Damien Le Moal , Sudip Mukherjee Cc: Christoph Hellwig , Sergey Shtylyov , Jens Axboe , Tim Waugh , linux-block@vger.kernel.org, linux-parport@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] pata_parport: fix pata_parport_devchk Date: Sat, 30 Sep 2023 21:15:08 +0200 Message-Id: <20230930191511.24994-2-linux@zary.sk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20230930191511.24994-1-linux@zary.sk> References: <20230930191511.24994-1-linux@zary.sk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sat, 30 Sep 2023 12:16:03 -0700 (PDT) There's a 'x' missing in 0x55 in pata_parport_devchk(), causing the detection to always fail. Fix it. Signed-off-by: Ondrej Zary --- drivers/ata/pata_parport/pata_parport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_parport/pata_parport.c b/drivers/ata/pata_parport/pata_parport.c index 1af64d435d3c..258d189f42e5 100644 --- a/drivers/ata/pata_parport/pata_parport.c +++ b/drivers/ata/pata_parport/pata_parport.c @@ -64,7 +64,7 @@ static bool pata_parport_devchk(struct ata_port *ap, unsigned int device) pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 0xaa); pi->proto->write_regr(pi, 0, ATA_REG_LBAL, 0x55); - pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 055); + pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 0x55); pi->proto->write_regr(pi, 0, ATA_REG_LBAL, 0xaa); nsect = pi->proto->read_regr(pi, 0, ATA_REG_NSECT); -- Ondrej Zary