Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Sat, 30 Sep 2023 22:18:26 +0200
From:   Sebastian Reichel <sre@kernel.org>
To:     Mario Limonciello <mario.limonciello@amd.com>
Cc:     amd-gfx@lists.freedesktop.org,
        Alex Deucher <alexander.deucher@amd.com>,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jun.ma2@amd.com
Subject: Re: [PATCH 2/3] power: supply: Don't count 'unknown' scope power
 supplies
Message-ID: <20230930201826.biy27esyw4ttxt4p@mercury.elektranox.org>
References: <20230926225955.386553-1-mario.limonciello@amd.com>
 <20230926225955.386553-3-mario.limonciello@amd.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="4p2i5gnoe5rlcwny"
Content-Disposition: inline
In-Reply-To: <20230926225955.386553-3-mario.limonciello@amd.com>
Precedence: bulk


--4p2i5gnoe5rlcwny
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Sep 26, 2023 at 05:59:54PM -0500, Mario Limonciello wrote:
> On some systems AMD Navi3x dGPU triggers RAS errors on startup; but
> only if the amdgpu kernel module is not part of the initramfs.
> This is because the hardware is not properly programmed for the
> AC/DC state of the system when it is loaded later in boot.

I don't understand the last sentence. As far as I can see
i2c_dw_pci_probe() either does not registers UCSI at all or
with the dGPU properties (and thus scope) set.

> The AC/DC state of the system is incorrect specifically when UCSI power
> supplies have been initialized.  These power supplies are marked as
> POWER_SUPPLY_SCOPE_UNKNOWN scope. As they're 'offline' the power
> supply count is increased but the resultant return value is
> power_supply_is_system_supplied() 0.
>=20
> To fix this look explicitly for `POWER_SUPPLY_SCOPE_SYSTEM` power
> supplies before incrementing the count. If no system power supply
> is found then the system is assumed to be on AC.
>=20
> Cc: stable@vger.kernel.org
> Tested-by: David Perry <David.Perry@amd.com>
> Fixes: 95339f40a8b6 ("power: supply: Fix logic checking if system is runn=
ing from battery")
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---

This effectively fully disables supply detection for UCSI, because
it is never set to POWER_SUPPLY_SCOPE_SYSTEM. Please fix the amdgpu
init part instead.

-- Sebastian

>  drivers/power/supply/power_supply_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/power/supply/power_supply_core.c b/drivers/power/sup=
ply/power_supply_core.c
> index d325e6dbc770..3de6e6d00815 100644
> --- a/drivers/power/supply/power_supply_core.c
> +++ b/drivers/power/supply/power_supply_core.c
> @@ -349,7 +349,7 @@ static int __power_supply_is_system_supplied(struct d=
evice *dev, void *data)
>  	unsigned int *count =3D data;
> =20
>  	if (!psy->desc->get_property(psy, POWER_SUPPLY_PROP_SCOPE, &ret))
> -		if (ret.intval =3D=3D POWER_SUPPLY_SCOPE_DEVICE)
> +		if (ret.intval !=3D POWER_SUPPLY_SCOPE_SYSTEM)
>  			return 0;
> =20
>  	(*count)++;
> --=20
> 2.34.1
>=20

--4p2i5gnoe5rlcwny
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmUYgocACgkQ2O7X88g7
+pq7lA//a6K7B++DJWK3qkFLkvZrvZfxhxBV7WbHyZ/uCAaUihZnq2ItQVwlZlRE
W4NvbCAtY4ifJhEaf+kpFSVF6xF2LEr0sw6Z6tsa822T+w+icl/+23elZwrJzuG5
xA66zaamIYkyVeirbMo/FW8YokslGc+LPzzl2VlPiv2YjupS0+US48HON00gFc8t
OsGo9CAqbpXRMe9GZAtun0oVni/pMV3NZp9U1RVdfepE7GPuHQEQKxSjQnbf92/k
hbgTNAA1ehb0I60YbCyyeoFkJvGVA5FMxmetlFQ5oR7Idb6AHhvU3Qs4jhFApC1Q
yqX5tn2ieZS8gzhhUj0YPvFjJ8qXqDX6TKnjeUzcy3FzF1lZg5WiVqkVtFEHTClK
cWPfr0MpMEDgnvcKWs9TJQb4cUNB1te5slrip86Goh0Au/RlL5cSsQDhx5U+vsCc
Tz9S+lgkqUDTzmQ7/ecjZwiihXb49Uq4bLRm9ir9vNkOJNFCnoum6UboVh/UbROJ
qN7HKK/HPdSlCdfNwfRsJMBj7q7uQj8SZZSRyGKA3k7BFiu2VmG0poM+nbK1gye7
Q0qHZSZo+UrdUqWEhS0zMDz/udJwCZvfrIxAo1DKwEyPwNNOynVmAMEtOGASUiV8
zxIHpH/ys1uLHSRop1O66W3uNxF+I1k6dljKdSIWxemE0CJo8bc=
=skRU
-----END PGP SIGNATURE-----

--4p2i5gnoe5rlcwny--