Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Sat, 30 Sep 2023 14:18:32 -0700
From:   Richard Cochran <richardcochran@gmail.com>
To:     Mahesh Bandewar <maheshb@google.com>
Cc:     Netdev <netdev@vger.kernel.org>,
        Linux <linux-kernel@vger.kernel.org>,
        David Miller <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Don Hatchett <hatch@google.com>,
        Yuliang Li <yuliangli@google.com>,
        Mahesh Bandewar <mahesh@bandewar.net>
Subject: Re: [PATCH 2/4] ptp: add ptp_gettimex64any() support
Message-ID: <ZRiQqLYpzJGbiqYX@hoboy.vegasvil.org>
References: <20230929023740.1611161-1-maheshb@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230929023740.1611161-1-maheshb@google.com>
Precedence: bulk

On Thu, Sep 28, 2023 at 07:37:40PM -0700, Mahesh Bandewar wrote:

> diff --git a/include/uapi/linux/ptp_clock.h b/include/uapi/linux/ptp_clock.h
> index 05cc35fc94ac..1f1e98966cff 100644
> --- a/include/uapi/linux/ptp_clock.h
> +++ b/include/uapi/linux/ptp_clock.h
> @@ -69,6 +69,14 @@
>   */
>  #define PTP_PEROUT_V1_VALID_FLAGS	(0)
>  
> +enum ptp_ts_types {
> +	PTP_TS_CYCLES = 0,
> +	PTP_TS_REAL,
> +	PTP_TS_MONO,
> +	PTP_TS_RAW,
> +	PTP_TS_MAX,
> +};

There is no need for a new set of enumerated values.  Why not use the
existing clockid_t ?

Thanks,
Richard