Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Sat, 30 Sep 2023 21:45:40 +0200
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Jakob Hauser <jahau@rocketmail.com>
Cc:     Marion & Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Lee Jones <lee@kernel.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Yang Yingliang <yangyingliang@huawei.com>,
        Stephan Gerhold <stephan@gerhold.net>,
        Raymond Hackley <raymondhackley@protonmail.com>,
        Henrik Grimler <henrik@grimler.se>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 3/5] power: supply: rt5033_charger: fix missing unlock
Message-ID: <20230930194540.szci6qlut5ecodpa@mercury.elektranox.org>
References: <cover.1695844349.git.jahau@rocketmail.com>
 <e437e728317b6a2a860f7812f64a98146a27965e.1695844349.git.jahau@rocketmail.com>
 <89351ef6-ab81-c679-4432-cc44de9a91f1@wanadoo.fr>
 <24162857-6863-d9eb-7fdf-e6c119e252d1@rocketmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="i2mxvavpm3tig5z5"
Content-Disposition: inline
In-Reply-To: <24162857-6863-d9eb-7fdf-e6c119e252d1@rocketmail.com>
Precedence: bulk


--i2mxvavpm3tig5z5
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, Sep 28, 2023 at 09:46:33PM +0200, Jakob Hauser wrote:
> On 28.09.23 07:23, Marion & Christophe JAILLET wrote:
> > Ok, but why not already in patch #1?
>=20
> Thanks for your hints about the missing "unlock"s. And sorry for causing =
you
> extra work by having the fix in a separate patch.
>=20
> The patch you refer to ("power: supply: rt5033_charger: Add cable detecti=
on
> and USB OTG supply") has its own history. It was already applied once,
> showed up in linux-next, caused some issues, was therefore removed again.=
 In
> the meantime, some fixes were provided by different contributors.

Since the commit has been dropped, please merge the fixes into the
patch. E.g. patch #1 does not make any sense on its own.

> This series actually tries to apply that patch again, accompanied by two
> fixes =E2=80=93 and two additional clean-up patches. I added the fixes pa=
tches
> as-is, also to credit the contributors.

You can use Co-developed-by tag for that.

> Possibly the cover sheet of the series was a bit too thin about that
> history.
>=20
> Kind regards,
> Jakob

Patches 4-5 look fine to me, but do not apply without 1-3. For 1-3 I
did not check them in detail. Please merge them first, since it's
quite hard to read in the current state.

Thanks,

-- Sebastian

--i2mxvavpm3tig5z5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmUYetoACgkQ2O7X88g7
+ppjzRAAqQYV7WWR3ahCHvFo8pWEWJ4xetIyHA9FUQ3UArpMJYI2/3WlrymChj97
caDn7XDA5wvt18FLVkZMmLW9mPGhxDBUcmJHFyrKfkkQYjtXCgdeKSUNWA9lKqZa
cRmPVLmAARAlB6nK5P22cTnIXBvpHSJvP5wA4BS3kt7CIeqbYqZBUSwTeB3GhJLJ
nu46CoAfYxIN0aZMqK2KJLjI4/qWltnnl1gegCtyI7/f+42ELQ+9OzdCCNVHJjdW
vRN07zFeuqoVt/9XS1mo9fkOsITIgAKmtFdeGrzv0jqRt00x/GfWsn1xH0i4JZnJ
ef5jO5DCyxVbDCjs50NcpdGuIn5ujIjFs/qY48uFIhfL6lI/NNpkr57hLwrAhCi2
BZSIQa0UU1DxEeszc3K4Alrhu4He+xU+xQB2Ieogr5IP/1wAaGgfWbnVlmXsj6IZ
mGNQPvtNWDEQOSD0zg9YirZEWi9ZsVNrIJkY8q8YUVsjR5aScqk7rKtZIp+eHxKx
0coHkta6vaqL8tuJZYdKwOazHckLO1Mhu9K2on3hkduRt1VYTCH17pv0rJB2rtT0
4RHnmvLmAIBqrlxw01wjkHYnqPmLLo5Xk1q0/0R5yGwKprCSSnOAxTD1NQcMpU1x
V+anAa1F74A/7qL77+SIrvDNS4oOtMWy0hCivsRRqdFS6N/O94U=
=tYmM
-----END PGP SIGNATURE-----

--i2mxvavpm3tig5z5--