Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp735678rdb; Sun, 1 Oct 2023 03:22:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHBvB/WjXYqab0M3184SwJbDxF48MYj5E2ti1l6DOv4gI2jX6etZANgpk/YtJB2JDpYEtnw X-Received: by 2002:a17:90a:3d42:b0:277:66be:f3ad with SMTP id o2-20020a17090a3d4200b0027766bef3admr13619361pjf.11.1696155752482; Sun, 01 Oct 2023 03:22:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696155752; cv=none; d=google.com; s=arc-20160816; b=TZYllr6dW+zph7E/COaCmJCkO7v1Wbf94xI+hqc3LSz24EsKVXsyjKwVPamccsYAlc sxnN/z1etbBS2hUv5h150GMoggrNDRu4o81Ni3oOEY/87LaCvEsWeYLE2R/fsGANEYOS OY1NAuUnq+JbN2/4A2wGiqBB8sLJfVru80Map3KQaEocv4VXTSDqW1yqaG0Kxn86AknC Lr1Eo75x3XnevMHGpMGWW2sr3Rvtz7Udka3aIQ7UgXTh7wRaFuLPEPBM/LDUPmAJGI37 zqIEanPm7lh1ypjXZCkRBSSmY9zOMpgYaeD715uJcau8XyhKIjTZV2IzJ8Z/ChQc0BzF MuEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=6T3CIVfxQmnI0WYr2r937m+RqdB87tHw76E0io9TFa8=; fh=o7QeJI7aItyXxODE9dQ80VLdtMdTSx4nZ/QP2iPXCl8=; b=EzntlQCAdZ4w19f1juJeMxVSCCqgv0qsDhKeXvi+XVXZ8aq4+W1Qy/+SyNghKN4Q+H 5g6enNR/3x1NnsbWaLStBXU+81nL+MXeBhP+Ay97+iBB/7TMARXD5yd77F/fcYFllnuR HiPolmqrjELnC+aQeZS6jnUOAV0NF6yUpA9faIcyZ2xA5WfgbIPCFfc4+65/lb7NeUxB ejnfbhN/wsUeT+oD1fKj5dpHjqA2Jvphk7l1YRCJ0oE/Kiyl8W0ba9ZRlcqgt8TK7FMn FNY1CxFTMdqcXIcICHGuSiiUsP8tyC5PZPsG7iO/AOISB1KUaSqQm/+i7OrOCveBbV/K GOuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=aXtbdmGL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id z22-20020a17090ad79600b00274c8c95bdesi5229781pju.46.2023.10.01.03.22.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Oct 2023 03:22:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=aXtbdmGL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 8A7D2806C455; Sun, 1 Oct 2023 02:17:40 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234698AbjJAJRe (ORCPT + 99 others); Sun, 1 Oct 2023 05:17:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234641AbjJAJRd (ORCPT ); Sun, 1 Oct 2023 05:17:33 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABCFBAC; Sun, 1 Oct 2023 02:17:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696151852; x=1727687852; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=oCG7jOCcU3wYWkbsh+OYQxwNNnSBA4Q4h2ZKv3nOzPc=; b=aXtbdmGLtkeGyjApW/PIsk2xTx/vX1GH/cOUVyE6Vuy5AhV6TTcdEYgf 9Dn0BOXqQhTGtQHCUI0fzD2NODr5oxsx4RBWg9dLhWvlvVJPZKuWEQnxz wu5IxQ0nRyzt9miK6BAJ/oIRd1uhOHsddlAVFOZJPC/TbqcQhosXzCgZB cl+gagjWGZsZbhiBqsztiDnPSrwQWFnMtTS+JURali5FDXdlh3j5x66IB qPVg61tlTTpPdkYR04CgNXcLelk5UZc7iu+0flYb4R3lExASdgioGRgbI /Hi91i2Wl4hTc4Ku2niq8p6hGjVKY6k4a1PkhBse+UllWWWZa7wFwt/wu A==; X-IronPort-AV: E=McAfee;i="6600,9927,10849"; a="4084909" X-IronPort-AV: E=Sophos;i="6.03,191,1694761200"; d="scan'208";a="4084909" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2023 02:17:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10849"; a="924002428" X-IronPort-AV: E=Sophos;i="6.03,191,1694761200"; d="scan'208";a="924002428" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2023 02:17:28 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC0) (envelope-from ) id 1qmsZp-00000001rVH-16dD; Sun, 01 Oct 2023 12:17:25 +0300 Date: Sun, 1 Oct 2023 12:17:24 +0300 From: Andy Shevchenko To: Hans de Goede Cc: Bartosz Golaszewski , Mika Westerberg , Linus Walleij , Daniel Scally , Mark Gross , linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH v2 0/5] platform/x86: int3472: don't use gpiod_toggle_active_low() Message-ID: References: <20230926145943.42814-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sun, 01 Oct 2023 02:17:40 -0700 (PDT) On Thu, Sep 28, 2023 at 02:40:03PM +0200, Hans de Goede wrote: > Hi All, > > Here is a v2 of Bartosz' "don't use gpiod_toggle_active_low()" series. > > New in v2: > - Rework to deal with ACPI path vs gpiod_lookup.key differences: > acpi_get_handle(path) -> acpi_fetch_acpi_dev(handle) -> acpi_dev_name(adev) Code-wise LGTM, Reviewed-by: Andy Shevchenko But please fix tags here and there... -- With Best Regards, Andy Shevchenko