Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp759489rdb; Sun, 1 Oct 2023 04:37:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFYY6dJ5s38yfzpECPKcgtPyvBTsb/TYVDDwbU+dDpOpIXq4qpzK/POkGIQ5mT3/CIOq1OL X-Received: by 2002:a17:90a:bb82:b0:277:3569:29fb with SMTP id v2-20020a17090abb8200b00277356929fbmr13722757pjr.11.1696160225201; Sun, 01 Oct 2023 04:37:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696160225; cv=none; d=google.com; s=arc-20160816; b=qj7xjTNanZN6iw79h4Nq5wzNVHQNp3Yl4fLQ/QBpm2hatgrmC87RGQx5pob5/Qy5Ko 1sGlII1AKWCdoiWNFJxen/nYPnKj41leObqoHdLW1VIpgDWQF1bvI6z/6NnOGkClwwe9 ISfmOx7NrXQW7RLIgNH0Lg5x+qNLAH/yHEoRg308Nmh/3PIxdqoRuXkSyr6d2qsOUByF DlRgbkMeEdx6jc/fHzYPnUul8jGI8TAfjYBBwv2me+NhZoMbkOtm2+w/3T1LZfDefGWS qOoY9mrDadpbzkGwgi2JRSwBBwogG+38G6mxHX7pjPsNUB+GyV2GKwxtJxMFeqBY18jc TofA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=PG/KGQwjNs4ZGok8oyh2dsgysSfsoypjzGlRd9hacr0=; fh=ub/3czFYlLOFoQIuyaB9NQlS4j9ww5CYGaJ0/JMOgEQ=; b=mr2hnahH0y1ByegqWd6jDKONJ/uIo/WfGgG2mkR5sc52f2xEL3kqeHb7wBdEz66yIH u1qZrbWez8Kanj8SePg2DrTyu6ysS3+plfpRz1BRKgt00xhyBuFBu9iKCEmLnaWj6bdq c9jqagce0bH84ZgOpCeeitlVNJiluzkTIXK/OoB+6JkIK4q2XV6+K1FzB+Wf31kv9dvZ ZRxHURWhus7BfGnXJx2zliTq8vmT3FjmNSkFdbxoECZx5J3xF8/scphhPD2J+KPHN6c2 DWbYhTfCBKgGy9kCTFfWaj+CgbTI8q1yUywgy81Q8IbHEpvlIwuT29Rq0IvLUwGjZBXz XAvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=f5JndhUw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id f5-20020a17090ab94500b00274c6997c25si5294456pjw.110.2023.10.01.04.37.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Oct 2023 04:37:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=f5JndhUw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id E7C868246971; Sat, 30 Sep 2023 23:07:47 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234329AbjJAGHb (ORCPT + 99 others); Sun, 1 Oct 2023 02:07:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233612AbjJAGHa (ORCPT ); Sun, 1 Oct 2023 02:07:30 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 890C6D3; Sat, 30 Sep 2023 23:07:28 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4E93C433C8; Sun, 1 Oct 2023 06:07:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696140448; bh=HVu55sj8diVEf0YD7PLaNXoZSow64mVKxB6UDNxUVbU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f5JndhUwISOai3W73L76bzvRwg46SINIy30ZohMcdf2KhyXeqlCr+h0dzVtCpPqUw a83j2KMErhppxh2mHOXHKHP6pp/fjrOpkby+HvGO4zoBzJxQMOqJiZ0KLLvsAqc0x7 J4js6k0JClsUvvOCzD/WzYnCHXSuTPbuN13wjZN4= Date: Sun, 1 Oct 2023 08:07:25 +0200 From: Greg KH To: Abhinav Cc: shuah@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH] Added missing TARGETS in kselftest top level Makefile Message-ID: <2023100135-stiffen-depress-8121@gregkh> References: <20230930194106.1379527-1-singhabhinav9051571833@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230930194106.1379527-1-singhabhinav9051571833@gmail.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Sat, 30 Sep 2023 23:07:48 -0700 (PDT) On Sun, Oct 01, 2023 at 01:11:06AM +0530, Abhinav wrote: > Some TARGETS were missing in selftests top level Makefile.Added those. > Signed-off-by: Abhinav You need a blank line here please. Also, why make this change, you are saying what you did, but not why? Have you tested to verify that these targets were actually missing and needed to be added? If so, for what reason? thanks, greg k-h