Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp779320rdb; Sun, 1 Oct 2023 05:23:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEgPuJn3lk3GYvhZsOhvExk7ko4Pg5yE08UUSnSGoq5feRudHYWlutqOE+lA0V7t3Wxaasx X-Received: by 2002:a05:6a20:734a:b0:14d:4ab5:5e34 with SMTP id v10-20020a056a20734a00b0014d4ab55e34mr8218531pzc.51.1696162991689; Sun, 01 Oct 2023 05:23:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696162991; cv=none; d=google.com; s=arc-20160816; b=sYivefgsVYzDxbnhfCOlUWNHuHpHyerENJ2xw6+920tlnHdyusAg0qx95hW3VWCE30 org6g3IfYIXJ/hyaO3VCdO9mpY3txvXTjnGvsgh2rhQVgZM/i+6ONbR9/qmppoJmY0it eHfmfS5dDUSO+MucnWI8G2/LYxtYR8qz7GtA28OirsRwN/8eiTRBunCOf1eNFTbn3pGL dYYGrmT1K6jYoC4+zppd2qiXrhB4vqCXXPHZK4N98XLkyTmYfZHPsg0G/JuLz1t8OXm7 /etsOVFFUynUB+swh+DkOsRTstKBrNRxVlOde/zh2OdxpdJdyyg7t2ke2XxWBMEjZkEU iMBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=sZ7+UnJnER0ls1vHQjaLCpKm4E1e0tmUTpEI5M03pjU=; fh=9X4NRy2Om8pBMDZwTDDMWWOq9JUj1HYOE9bwpsR/7YI=; b=Q7eWtuiwZpr8rG07tqvj5QLAmnMlnauF4WdXb1hQda5UVVu3UKDC+fs6s4VAcdPzW+ +VdWeer/JEhQO5/YKCbNunAE/S0Us/s7IgjhpaJOwt+JfJ7OJ+fTUrexi/sm9jQ86nyS j85sfs5sL6obMbRkuRlIJh5SWby+pREv4aVe8XVifGxQ7U6GHa5QPd0+uMSHg2ApGQGM i7/pywU3oVptzep4LEhKA5WvljrWZj85SuAJAcyufvW9UGLySTvVqHCSeNEI7mMRVqKV Wbkr+lDP9II1OtzlVm+xsLkz30z5OJZie3cVKTss39h0vatEOg0caBXvhpVsGkxupIKZ Lv3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=vKQ6iWk3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id kx14-20020a170902f94e00b001c71f14ba7fsi11792601plb.247.2023.10.01.05.23.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Oct 2023 05:23:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=vKQ6iWk3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 7431B8025876; Sun, 1 Oct 2023 05:23:10 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234938AbjJAMXF (ORCPT + 99 others); Sun, 1 Oct 2023 08:23:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234941AbjJAMXE (ORCPT ); Sun, 1 Oct 2023 08:23:04 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2753A99; Sun, 1 Oct 2023 05:23:02 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49C31C433C7; Sun, 1 Oct 2023 12:22:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696162981; bh=OkfmSReXJWH65GTbJ8/OWhwdpJ6O+HTlW6xaMfOmcAY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vKQ6iWk3LDBQwoOkyswRFnrviy9ScHi2U9OPc1p7MlgpAmDJ5Go6j112CRQJbYShA YpfsbY1ryvRkN+fEPJW3/jOEqCD/XcmFrzIQ33SOvx156KY+22zx6iuS3Vowlgqndx ak4yZK2CUk3lIYCFflWdgxLMdjJ3lm8pw1nvfZxUsgTyCInrkVvvlIX/eGtikikVrh ov3bpgO+Ygp08rWcMeG1/aKJA4ky3so4pOYtbFybWb8UshcnJv/AokHnWnEUGz0Lug 5zrvk1FC2oFPISMBkb4s7mYhbpfcVqnxdvRqy2bZpw0B0DPMCVE4UW4G89836fL89d /Qh8nAVOvQhYQ== Date: Sun, 1 Oct 2023 14:22:57 +0200 From: Simon Horman To: Markus Schneider-Pargmann Cc: Marc Kleine-Budde , Chandrasekar Ramakrishnan , Wolfgang Grandegger , Vincent MAILHOL , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Julien Panis , Judith Mendez Subject: Re: [PATCH v6 02/14] can: m_can: Move hrtimer init to m_can_class_register Message-ID: <20231001122257.GK92317@kernel.org> References: <20230929141304.3934380-1-msp@baylibre.com> <20230929141304.3934380-3-msp@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230929141304.3934380-3-msp@baylibre.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Sun, 01 Oct 2023 05:23:10 -0700 (PDT) On Fri, Sep 29, 2023 at 04:12:52PM +0200, Markus Schneider-Pargmann wrote: > The hrtimer_init() is called in m_can_plat_probe() and the hrtimer > function is set in m_can_class_register(). For readability it is better > to keep these two together in m_can_class_register(). > > Cc: Judith Mendez > Signed-off-by: Markus Schneider-Pargmann Reviewed-by: Simon Horman