Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp780006rdb; Sun, 1 Oct 2023 05:25:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEW5eTqcKKY+KnJy5VD4wgrn/jm4bdqcEANJIaN3rm6fngZG+XCTz6QQIsNiz0eJFu9PPPF X-Received: by 2002:a05:6a00:368f:b0:68f:a92a:8509 with SMTP id dw15-20020a056a00368f00b0068fa92a8509mr12092619pfb.7.1696163104955; Sun, 01 Oct 2023 05:25:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696163104; cv=none; d=google.com; s=arc-20160816; b=0x5g0guupLunPBNAKcf2nnXAFUKyYMg2If74QmzYPcGQ4KgmY6CN2d++Zg/fqc80Yt gE5rfJfQumcrMBrh9aaHwXZo2cEcYA9alaxOXt2MWKsYJmEiR6MbXO/CD3t6LQPzRQRV 5nnQs7c6gv1dXFdk189fypu1nfwMcptVOw83g9PV3akZ8Ieb6ym1nNpVE1qmcmohJs/Z 2w/2+9e/jQey1C+qywCtu5JsSV5bH+xpbd92vTA7JBARgjAxqv3/jwdkLGeEKIVqdOub QuipuPf5zd+Kob/w0ZmAcEu4v/Ju4OUSA7an++NMhus4G9piSmw4zvOvMCoXRlwThB+n 9W0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=eUOPpVcFjqWjcaZvetmHSX3/3YZOnI/wo6V9NE31YdE=; fh=9X4NRy2Om8pBMDZwTDDMWWOq9JUj1HYOE9bwpsR/7YI=; b=tgmDKXdvJNpn2Mc695mlqv9G8BtPPZoYN5XbZvpTLnAY9erU8QwwVaYuyJnSBJN8U+ sGI5Xn2yyUI2UKxPXQqjqHMRYPyfM8sPlRTEiWIiLMl3GO+i+RYXddBckOOp5TmdinjM E0dJyPOcagb09hv4o7pnJibgXTX6bqtAyQaI/nf8fokXP64cOMwm0K/j6z/VZWrpSa4n T3J5wQ/JqzL4mw95X6F9yW3xHFvY5O2aMMLiQtKunDzOpIXqghw+f1x3QuSi+p4QesbX rv+D5ptrYa3gT7e+Ik7I9w2l1JorMyp42+TiX5k9utlw3aKpPlD9LuA+2J4Z0wlyTZIS WPbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="LU/VU39M"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id x33-20020a634861000000b0057047d68837si25220243pgk.869.2023.10.01.05.25.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Oct 2023 05:25:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="LU/VU39M"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 6555980295F4; Sun, 1 Oct 2023 05:25:02 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234953AbjJAMYz (ORCPT + 99 others); Sun, 1 Oct 2023 08:24:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234931AbjJAMYy (ORCPT ); Sun, 1 Oct 2023 08:24:54 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B0ED9E; Sun, 1 Oct 2023 05:24:52 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D041C433C7; Sun, 1 Oct 2023 12:24:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696163091; bh=60Jvv/Pm2PQ/Yz/ve2h3Ch8pPQyPw2+hMP/ocOFmqxM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LU/VU39MeIZafsdLU1IGGQOSAP1F4b2/uUhGtdrafCRP27AbfZ+wYnWgjGressAuk ZxszmyylMKtxWOYoD82cfsq3hg7g/sO4eyBF+4DIiocOH0T2NpTf05++AA+Nll2K9g 486xbmG81EFLJUFX4+6oL/1kUBwueeG3X9TvoiZZu424PX4ZsxaL/+USQflUXQ7bvM XY5o/qz+N9O/x8oONtzmVFi4OlYb1DcD+IubgWbGNn81uqbMv+Wf8V5BCBip8OT4As ESPUI6LZKh82yDPR8a002qHif70K023W846IggV/eKKqVWclFWTNMZf0S9iQX0olkB iamK58LXFAWFw== Date: Sun, 1 Oct 2023 14:24:47 +0200 From: Simon Horman To: Markus Schneider-Pargmann Cc: Marc Kleine-Budde , Chandrasekar Ramakrishnan , Wolfgang Grandegger , Vincent MAILHOL , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Julien Panis , Judith Mendez Subject: Re: [PATCH v6 07/14] can: m_can: Add tx coalescing ethtool support Message-ID: <20231001122447.GO92317@kernel.org> References: <20230929141304.3934380-1-msp@baylibre.com> <20230929141304.3934380-8-msp@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230929141304.3934380-8-msp@baylibre.com> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sun, 01 Oct 2023 05:25:02 -0700 (PDT) On Fri, Sep 29, 2023 at 04:12:57PM +0200, Markus Schneider-Pargmann wrote: > Add TX support to get/set functions for ethtool coalescing. > tx-frames-irq and tx-usecs-irq can only be set/unset together. > tx-frames-irq needs to be less than TXE and TXB. > > As rx and tx share the same timer, rx-usecs-irq and tx-usecs-irq can be > enabled/disabled individually but they need to have the same value if > enabled. > > Polling is excluded from TX irq coalescing. > > Signed-off-by: Markus Schneider-Pargmann Reviewed-by: Simon Horman