Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Sun, 1 Oct 2023 13:34:23 +0300
From:   Ido Schimmel <idosch@nvidia.com>
To:     Kees Cook <keescook@chromium.org>
Cc:     Petr Machata <petrm@nvidia.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH 4/5] mlxsw: spectrum_router: Annotate struct
 mlxsw_sp_nexthop_group_info with __counted_by
Message-ID: <ZRlLL7gvrQRC5Ci+@shredder>
References: <20230929180611.work.870-kees@kernel.org>
 <20230929180746.3005922-4-keescook@chromium.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230929180746.3005922-4-keescook@chromium.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OsBOBaM1C9Q3YVi55QFScqsNZU6VA9wIOwLOPp2V9FYTYdKA6L6aLNtgQptq?=
 =?us-ascii?Q?icl0hpQPVYv06hcFV4xJfiqiltunnSrWICrlGOg5Teva4NKvnmpBP8yHbMXa?=
 =?us-ascii?Q?QTK/hoSKlxRm64f3QMoaS2xyLyt9MJS/e8/KRetS7g6DdLqu8sdQkEbz94mF?=
 =?us-ascii?Q?uX5Iq0yIMpe2SJIe6HlWj7h6CRUi5g8nqWjP2hlz57k1N9cPA7WTlbOKK1UZ?=
 =?us-ascii?Q?mkkdVxUUWTVA8fA4LwJGo1atraCDeZ1wJ+cL8TDnFF7VQam1A47zIjAHZMnB?=
 =?us-ascii?Q?MZLvU0cdlV9d/X7xNAHg+jc9MuoluiTU5RpNpQLfXo9a6CqWWH+zrBP7GCAT?=
 =?us-ascii?Q?nqNgjsbWBHEPnNf8XoeArtbfz5TDOFTVHVbZQqHP+wyvL6pbVE5xd7mW3aYo?=
 =?us-ascii?Q?RKpFTJmfK4odiU+E7ceaM1OEi/1znZLFJ2SKpttj7TAMVeiqMZfHhAHC2zW7?=
 =?us-ascii?Q?0+LbpSw2anEyIK62olPGoiZ2eB8ZtNnvRhc3clW+VpZRjrZ/pN47n7tK+mje?=
 =?us-ascii?Q?pXAbe49CLeiaUJSa4zLac5+0oSDnA1W0Lgg4tJWusbrCCTmaKi9XyMbFmkww?=
 =?us-ascii?Q?9XxWaifv4+UQD9gcawbTWM5b+OaYtrkXP8evwCMnIdA23AvV7D8Pm/52Nd/Y?=
 =?us-ascii?Q?6ljVI9C6I4Zdx09FUdfmTA2xHMWqYUlp0Rdr/V8O1hANHit8h4NJVTh50HHW?=
 =?us-ascii?Q?z7YlhBYg0Ij7p5b8+08XOEhJSzreIjy+bk1NtCkKwPsdXql2ff7Y/AjF5MKn?=
 =?us-ascii?Q?o/7G/jZf7XdJ/kk7Gtr6eahC6YsHgafKy45QBjbH4RErLpNZInGjk2gPdSy6?=
 =?us-ascii?Q?wy/kG6wet0qHIxwX5Ohzx8EApiYYg72sqCnDAentqY2SYEf0GtBNp5Ssn557?=
 =?us-ascii?Q?YPhRmJqNIwrzGo2eAab5Nj/ZpDQ821iiBFrQmGvdwwSFozDMcf/mBmXcNhwH?=
 =?us-ascii?Q?XGK2H5b81zhJ8WeZo+XfK78R/CrP7+RaBSpC8GOjp/AeRKZngEPKdFHvLQbx?=
 =?us-ascii?Q?FN2N8VF7RHGZI3TxQl63D7P5YQgjvJwCQTg2K0D50w1dG5hEVZpQXR9c/nRp?=
 =?us-ascii?Q?QK+5IfgCQP0QRo1ol2CVG+NsTHTM0yJ29/nsAgus9nA8mHmPP0lDdUMN4tKv?=
 =?us-ascii?Q?HAsvNLiStXgQYMUXvLQfY042lt1YQJ5Ytmbfi8cNBBHCQT/EP2U8xyWlocAs?=
 =?us-ascii?Q?ONVHFB+vawGVuDQdWHXojYRefE56VMPHDO+3PRcfngDOD/S7ZjlS4/foE2RG?=
 =?us-ascii?Q?xQeRryc1YZ1NiFt4G/2lHLtoxwK8d2dPYB4cfJ5oXjAyOSXcF2R8sShevBQt?=
 =?us-ascii?Q?mC7Pw44AOAjjVqX1wLdBENzU2WinH8pLSDsOCCaBUq3x+HeEl85IZs+WqwTF?=
 =?us-ascii?Q?PuF/9VZ6wBM7qImMUCQsQc4LpNobpT8DXTf8xrkxRsLc6hajHEu47BSGvk+z?=
 =?us-ascii?Q?Y//pKO0OCw+UGeHVyWeOWa0muFDUwONUUOK96n535+Lz0sfm6kSavfLh5Il0?=
 =?us-ascii?Q?OX75jn/S/zCBa2UStwI1+WE26+9PlLduYCyHCjO81cgjdPhA7F0FyNX9DKZ0?=
 =?us-ascii?Q?MBRSQrIVgOcXLjuQqTbG6495uwDZC9wO7MwY79SE?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 22f8a873-fc27-482d-252e-08dbc269fe78
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6179.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2023 10:34:30.2131
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UHDHvQaKTCuf1CMBdX2YM6TTMHt5ZCsucYNfJpiHXcxGFCPMlWeQthUXaPcUEL9OLIM/lHYI/qnzVg2eCOSj+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6266
X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sun, 01 Oct 2023 03:34:54 -0700 (PDT)

On Fri, Sep 29, 2023 at 11:07:43AM -0700, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
> 
> As found with Coccinelle[1], add __counted_by for struct mlxsw_sp_nexthop_group_info.
> 
> [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
> 
> Cc: Ido Schimmel <idosch@nvidia.com>
> Cc: Petr Machata <petrm@nvidia.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Kees Cook <keescook@chromium.org>

Reviewed-by: Ido Schimmel <idosch@nvidia.com>