Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <15d382c5-ad09-4532-ab30-7b19e8786d00@solid-run.com>
Date:   Sun, 1 Oct 2023 12:21:57 +0200
User-Agent: Mozilla Thunderbird
From:   Josua Mayer <josua@solid-run.com>
Subject: Re: [PATCH v5 4/4] arm64: dts: freescale: Add support for LX2162 SoM
 & Clearfog Board
To:     Shawn Guo <shawnguo@kernel.org>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Li Yang <leoyang.li@nxp.com>,
        Philippe Schenker <philippe.schenker@toradex.com>,
        Fabio Estevam <festevam@denx.de>,
        Aishwarya Kothari <aishwarya.kothari@toradex.com>,
        Marco Felsch <m.felsch@pengutronix.de>,
        Tim Harvey <tharvey@gateworks.com>,
        Frieder Schrempf <frieder.schrempf@kontron.de>,
        Marek Vasut <marex@denx.de>,
        Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        Alexander Stein <alexander.stein@ew.tq-group.com>
References: <20230818111016.11271-1-josua@solid-run.com>
 <20230818111016.11271-5-josua@solid-run.com> <20230924135111.GJ7231@dragon>
Content-Language: en-US
In-Reply-To: <20230924135111.GJ7231@dragon>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WEJpN3pJWWp1UkZXTjE4ZzFKblY0TSt0ajhqQ2VzejlpUUpYM2o4Y0Vzd0pp?=
 =?utf-8?B?dGtaQVVpTzlXbEg1VVk4OUxZSEx0aEhtSVRaa2EwZUwyc1k4V24vMHVOdktW?=
 =?utf-8?B?UUZaeWpBYUNoZEQ5T29WTDNxZXlhbWc3d1JzeDc4SGo5M3F4VW1lVFdsQXhQ?=
 =?utf-8?B?NjB6ZXdIb0dPY3F2bUtqazJ5MHJUeUk0OFJaRGUyRGNrcXovT1FrbFJ2ZDRj?=
 =?utf-8?B?UVRZai9Odi92MlF1K3djZHZJeEdnS1BCR0t5dkFJc2VaY0RWNzVOUnBHdVVB?=
 =?utf-8?B?SFZPazVjOTNoT08wV3Y3MFVlTmc1ZlBuSFViY0VneDRwU0VpQ05TbVFLekpz?=
 =?utf-8?B?MlFFNUNoVUNxcHVMY3JtS01EWUhvaEhCU3JmT0lUUEd0alVNclBRNmFCWkVE?=
 =?utf-8?B?b21TVTRSSVduZ1h0Vk1XejNaa2l2SS9EaUc5Z3BLSkF5TVlYNzJKcWlZZElz?=
 =?utf-8?B?Slp6VG9panRKelZicXdCa2dSZXNaZ0tEV3lNdVdjMTFwU2RPNFh0L3YwUnh5?=
 =?utf-8?B?K2V6MzBpU09Fb1F1L0d5S00rRVJpbWFqV1U4N0dhRVNBNmxabkpPbmlhODZj?=
 =?utf-8?B?OW9KQzBTVGEzZDlBZnk2YjhGRzlxR2ljOWVkN1dlQXgxVTdrUUtaSXNEVnRL?=
 =?utf-8?B?eU51RE1IVzlwN1g0dk5iQml6RzlUUUFoS1MwM0MvZFdZUzk4N2N3ZXViUlI2?=
 =?utf-8?B?WU9hbU9UdHQ2NjlaNmtTMGNpb3ErcEhZeWQ2RDh1ZUdwVk9DSVJiazVmWjVZ?=
 =?utf-8?B?SEtQRXRCdmpxL0N5REFwSSs3RXBzaUlKWVg0c0IxZEI2ZUN4MmlVaGJOQzhp?=
 =?utf-8?B?R3Z3Rlo2YVAzMk9RWDJ1MUVjVXJWSmNRZVNVMmdsZzhhSFUzRDBZc2pHbmxh?=
 =?utf-8?B?Q1pRU2x0MlJiTHZPRXVOem9vME9yNVIzdzhGSld0UE5rWDIwcENBc1RYRTZF?=
 =?utf-8?B?cldGQmY1Mi9rYUI4aXVnMXBudytmUW9NVDZVVTZmeDhMNWVnUXJJS2gySDNV?=
 =?utf-8?B?M0JBR0IrUFFiMUlnSW84Rnc5NnV6YWZ2ZkJSQnFpUm5aTiszRGR1WGhvSzFP?=
 =?utf-8?B?S1MwRnNvNjNaeFRQVTd6R3FnZVhFc1hiYlhWV1o3ZW5DS0U0eFJyQXFFYVln?=
 =?utf-8?B?ZEFkc1cwM2tPL0h0VkpKTnd5VUhHWWlvVnhId2tLT0xEem1obnRwMTJFVTVm?=
 =?utf-8?B?V3NyOWpUeUcvTFo3c2ViMFE2ZDBONnBIR2k2MzVkcXNXNXRjbVJVQzllcklv?=
 =?utf-8?B?UlNTdW9DZmM5MEhCbEEvdFdML2hTdVQzT3dnL1gwdEFrWHkrZUMvQi81OXZ1?=
 =?utf-8?B?UjE0bHNlMUtzZG1yL1UydGJ3c1JuSXcyQllxb0ozTzlnUmlaaHBEUGh1Tjht?=
 =?utf-8?B?aEdDeU41bXgzUVJna0RrYzVrWU52QXUwNy8yaXh1dWpmS0plSXpnOE9lODBi?=
 =?utf-8?B?ZVFQcnY3Z2VFUGZoYXVuOEN6OUMxSFRUZmtSREJSNk9SZW5iRCtsQlhwTW12?=
 =?utf-8?B?MkZzcGJmMTZmdGdad0dLaysxdStjeXdkV28wczM4b0Z3cHphVkp1L1NMVGtI?=
 =?utf-8?B?cHR0TDVETW56OHh0M2M4d3FvcUxFdWtkWVpBZlREV0tIOFl2WERFZy9DYTVV?=
 =?utf-8?B?YXdXK0liNXgrY1BKZHlONXFzYlhmWHA0c0FDMis0Ujl2WXhCSHhBUlRWb3NH?=
 =?utf-8?B?a0JMcjRPSW16U0RuL1U3cGxGYS9jMkI1dEw0YW54YVhMTTluUHBrNFNDWWhF?=
 =?utf-8?B?ZDlzQlRqR2NyZTVjU1VtbGdwd0xaZmxrUXovd3dUajU2aW0zOGZhYkR4SUZJ?=
 =?utf-8?B?V3dKNTJGL0l0amI0TVJIeWt5a0poREV3czFaTDVidmJQWEtDNElLR01kRWx6?=
 =?utf-8?B?VSsxKzNkQm9paVNkV3B3MEdUV1hzRFNoQmk0SXdmOURveHpEMjJvazQwbmtu?=
 =?utf-8?B?eHppUGRsM2dBcEJQOXE1VmV2SGlJQlVGVmlweDREUVNtRHJIQXlqRldjb3dI?=
 =?utf-8?B?MXdHcFV4KzVsV2dJQWxEV3MzSE9ZbXFzUnVuUnlxVnVtNUZNWVJZbHBweGdv?=
 =?utf-8?B?ZEE0VldSMWxuYkZ6ZHF3b29mdVRIa3h5RFFRVGhIeG9XYURjN3ZSbHBmWk5m?=
 =?utf-8?Q?m6qh63bLsWXbipqATCccIBLbO?=
X-OriginatorOrg: solid-run.com
X-MS-Exchange-CrossTenant-Network-Message-Id: da8e6d47-1fe7-415b-1cd3-08dbc26840f5
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8963.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2023 10:22:02.8310
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: a4a8aaf3-fd27-4e27-add2-604707ce5b82
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NABt0csFRWVY87Z0e5g6/AaDye+CT4McywH8+lRD7T5myNyBEr7hSlYFX//Jd0j0tzxIsSbYWTws780oDem+pg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8714
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sun, 01 Oct 2023 03:22:32 -0700 (PDT)

Hi Shawn,

Thank you for the review.

@all - some of you have received this email including HTML,
this is attempted resend as plain text ...

Am 24.09.23 um 15:51 schrieb Shawn Guo:
> On Fri, Aug 18, 2023 at 01:10:16PM +0200, Josua Mayer wrote:
>> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
>> index a750be13ace8..9448d2effd8a 100644
>> --- a/arch/arm64/boot/dts/freescale/Makefile
>> +++ b/arch/arm64/boot/dts/freescale/Makefile
>> @@ -34,6 +34,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-honeycomb.dtb
>>   dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-qds.dtb
>>   dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb
>>   dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb
>> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-clearfog.dtb
> Out of alphabetical order.
Ack.
>> +
>> +		led_sfp_at: led-sfp-at {
>> +			gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>; /* PROC_IRQ5 */
>> +			default-state = "off";
>> +		};
> Have a newline between nodes.
Ack.
>> +&i2c2 {
> This label node seems out of alphabetical order.
Ack.
>> +&esdhc1 {
>> +	status = "okay";
>> +	bus-width = <8>;
>> +	mmc-hs200-1_8v;
>> +	mmc-hs400-1_8v;
> We usually have 'status' be the last property.

You are not the first to notice this, but somehow in each version I 
forgot about changing it :(.
v6 will for sure put this status property in last place!

> Shawn

sincerely
Josua Mayer