Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
From:   "Liam R. Howlett" <Liam.Howlett@oracle.com>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        "Liam R. Howlett" <Liam.Howlett@oracle.com>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Matthew Wilcox <willy@infradead.org>
Subject: [PATCH] radix tree test suite: Fix allocation calculation in kmem_cache_alloc_bulk()
Date:   Fri, 29 Sep 2023 16:13:59 -0400
Message-Id: <20230929201359.2857583-1-Liam.Howlett@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VpuOaITcY1Owg9ur19wF3DBkK4y9aUP4GqFf9oa7iUl4jzDLJ5Oxto81640u?=
 =?us-ascii?Q?RjUHn0KQ9uCBmnzbcRxUkjC8yPjrGLqpp2OJbt16xGZllsCR5j1huej/bs1B?=
 =?us-ascii?Q?W5qpJewtwNVXN9zvLPPJmVO9Rw99SdC1uP/3ExHYmYbzV0p1gJw2B16U+FqT?=
 =?us-ascii?Q?K+HDC7GsGx06cvFrY7qbvcvtnKNvejfpzB8u5y+4vNQVLSzIDLEbK9LeCvQa?=
 =?us-ascii?Q?s0YAvfbZtLxj7v2hZViADLU8uVFgE8Mblgsb5q7uWRLyMKyuwwNwAhd5K+iZ?=
 =?us-ascii?Q?Un481vWmGm9KMle/B618ANX00zaUj+tw5tCnubOGL43+8C8bJmKxgxlGPsab?=
 =?us-ascii?Q?Ry4iuDA1d0K7k2kfqKssv84gNgChFE5pJhTbVQdpZAYY1607cnzDmAtBu78r?=
 =?us-ascii?Q?yZCuPrYqZXZZc9b5CMU3rGZXkoHlQzr/9+74v1S7h5AvxlewgI2By2j5ktQ7?=
 =?us-ascii?Q?cfFaO4qamIDXe4YuDDu6UFOzETVfBjg+68VwSEaR15keXl65IuXCMIcpYJ0s?=
 =?us-ascii?Q?JvcV8u5SeNhypoMA+8wkhGtT1GUB6v7SXHc9mmohR3pCUBUQEBTuifi2wPzT?=
 =?us-ascii?Q?nEhu54bdv1ug20tYOy528jrej+hZ45PWfCQqTEH69/hu134PptQWn00xDgqS?=
 =?us-ascii?Q?1F0an/Xc6QPk8zhy5rhMKhfUgxE7cpHV4bSfrMWAz6vFAGGNd3vaO7P22HOc?=
 =?us-ascii?Q?voI1pvfzTBgRkvG3XSgLmz00LNCVcTJoCgUih+GyPajYt1w/62KBstShgFII?=
 =?us-ascii?Q?MxyzXvOhyk0GpIxn+PXPYrOVV6bymqfCI3ucBTkbFFy7pJwpgp0qr5VkFz/H?=
 =?us-ascii?Q?rd2YDTPRYjHv8tRoKbi3EFdDaqB0vxzpa2NK1/ykZOTgfzP07JRAxKOZaSlv?=
 =?us-ascii?Q?KiBV3s2k0/AQZ0aF9m/3gb/xzo0HYC23PQTcsnKI/FAU3BdiSHNEuqagm5jo?=
 =?us-ascii?Q?GasZ+SNxB7XV1qDqVShvZYJpDtqxenAsR5C86HNI3Qfz+nGHf96WcZMRl15C?=
 =?us-ascii?Q?mC7F1HT3XKUL7N9lsRWxUvliGI4yprViffS1qYh/Rb2/4h71k2LJ/e57pNGX?=
 =?us-ascii?Q?anbscRhMm47VHJHPXzvPzgvc6TYg28/fQTR62xVI0twi0IG/YtUTiscxLtoc?=
 =?us-ascii?Q?sbYbgK1ebeaEev3T7O4AX1NtiMLHGVid7NpfhCmgpZq+XuUxN1yGZrKGfAfH?=
 =?us-ascii?Q?UVClENR5CT5nLS+bjGrOPntG6CEtEC8cKfGKuu9qLXV+cj6+dy4YZLrpT5XT?=
 =?us-ascii?Q?rCaIdGVbYkrFQkqvL7jFZuaqu4/tL8VMbCFqJuz3myqZjxPBSVTp5aFxOrQq?=
 =?us-ascii?Q?ar4tIDCLsf7qzv1wr3ysXsJn6kfvPpNOtM0EmrMPCYcF6NXcU24emXzoILqT?=
 =?us-ascii?Q?mvtrosAPPLJqFUbP4TKsZN0h8UibBzLVLxjdmRvVPnFOe9eUGay25BSr7sdu?=
 =?us-ascii?Q?Vu1sqXMAiLF5AWHaArtip1BHgvji/+BHRSv+y08IZTPQFtlRJ0XqYRUUOEO1?=
 =?us-ascii?Q?t8aWk558xltol1i5djKvro7lOcnf644qI6GBzkaOsidBph7IjVCL9glY3Cf8?=
 =?us-ascii?Q?QfxECD/1DOsAbybVU2Nrh9W72gN+eGTbduIL9cccxKDMZufkjwbqQTQ6mADI?=
 =?us-ascii?Q?1Q=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ZuiyQFtZSuXKCl68s1USKsJg4AzakQKqN6zHhYc17DNFKUO0D4+NKuK6WgzusqiXhkDqSVy9SF9hr1gJmrj9A59D2HbTBQxRrv40kqB2nvOWq3qDEQ1FV2IVMht/+1AXS7KAhOTb5P21sIBkznToHHZJwT7mm1IvqTM0Zjg3JKu1h3AQn4WXVOAvII1FbHHausQcm31+9UjlJ0GgtyTIsr5J4k2jl9f9NGjMbWs/OyTEkJFVQbe/F1cRFhxCZ7Ma7RFppKCX5eeaG0xJc0dlx5huBtmuF3CMsfn8Hf5OOmX1SbIUI10ZAcaBiGjyxCqvQyvzONenYTvi4G7skAPCVriCVsna1l6QID/5wgCD8ELdA+POacHs0/aR0j0eHwZ7BB5rpY1XLS5eNL84oZ8eUaeNq+cgjXVGVNgqv816vfF/1z0FgKXfSQYj/MMYwPXT3NsvrP6oi+KdkribkDDuu9JSbKuqB6wBxweepqDPHYIhQmAA8PJ5Xr9d0UaBd72qWpIY/T38RyKgl1dRjO3CwWCaMAm1F02/A/xSZPwTJ2RyhZ4mMCtKRZudolOPpGg0BJbzAOy9eNGmoo+gC47U0LuFSODg9hf2qHXj3Wo2nvst9TgB2rTO0SFPxxeGwDa5j0xO2sXESylLvEinMU48Wh7OR7Qg+tQwJbNJdldYo4hoxNwnsCSNRW5mRe1yyNs/UkBAKilImZWqX5Uxqa7wCLVcndG8w25d13FmokqIp0/49cHwyChE0FGBzOIaGNsjQ8+/yMk/nLplK1Yb90v/IZqgdavzldT5td611BznghXT//Yp1y61RBrmfT22hlMsYcS1ArauOob+EMhD6Ch1aw9xFjZbbuMxzmzjdRSAZNme09MKKgHzDLlRlsw6jY5He37kd4JtYwGdL9989MJSF/qbWf2B08woI2NO1w3BMNc=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 767f9c9d-e0cf-4b60-10f2-08dbc128a96b
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2023 20:14:18.9176
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Mnsk4G3g3/DAipFqLoL8+j9C2TXRbaP+3JD9M7e2npjwyMR13tMd/0agPM8lPFSGhbcLSGG4Ymeud0M6noY0Jw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7632
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-09-29_19,2023-09-28_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 mlxscore=0
 spamscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000
 definitions=main-2309290173
X-Proofpoint-ORIG-GUID: ORhiWVTHclDtpXVZQG68CrNiLGf32f_k
X-Proofpoint-GUID: ORhiWVTHclDtpXVZQG68CrNiLGf32f_k
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 29 Sep 2023 13:15:13 -0700 (PDT)

The bulk allocation is iterating through an array and storing enough
memory for the entire bulk allocation instead of a single array entry.
Only allocate an array element of the size set in the kmem_cache.

Fixes: cc86e0c2f306 ("radix tree test suite: add support for slab bulk APIs")
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
 tools/testing/radix-tree/linux.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/radix-tree/linux.c b/tools/testing/radix-tree/linux.c
index d587a558997f..61fe2601cb3a 100644
--- a/tools/testing/radix-tree/linux.c
+++ b/tools/testing/radix-tree/linux.c
@@ -165,9 +165,9 @@ int kmem_cache_alloc_bulk(struct kmem_cache *cachep, gfp_t gfp, size_t size,
 		for (i = 0; i < size; i++) {
 			if (cachep->align) {
 				posix_memalign(&p[i], cachep->align,
-					       cachep->size * size);
+					       cachep->size);
 			} else {
-				p[i] = malloc(cachep->size * size);
+				p[i] = malloc(cachep->size);
 			}
 			if (cachep->ctor)
 				cachep->ctor(p[i]);
-- 
2.40.1