Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Sun, 1 Oct 2023 12:25:58 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Geert Uytterhoeven <geert+renesas@glider.be>
Cc:     Wentong Wu <wentong.wu@intel.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: ipu-bridge: Add missing acpi_dev_put() in
 ipu_bridge_get_ivsc_acpi_dev()
Message-ID: <ZRk7JrCxUhgJ/zhf@smile.fi.intel.com>
References: <0e8fa862e2d3da5897d0f895322d469e7d5aa052.1695979848.git.geert+renesas@glider.be>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0e8fa862e2d3da5897d0f895322d469e7d5aa052.1695979848.git.geert+renesas@glider.be>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Fri, Sep 29, 2023 at 11:31:33AM +0200, Geert Uytterhoeven wrote:
> In ipu_bridge_get_ivsc_acpi_dev(), the "ivsc_adev" acpi_device pointer
> from the outer loop is handed over to the caller, which takes proper
> care of its reference count.
> However, the "consumer" acpi_device pointer from the inner loop is lost,
> without decrementing its reference count.
> 
> Fix this by adding the missing call to acpi_dev_put().

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko