Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Sun, 1 Oct 2023 11:53:22 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Alexey Kardashevskiy <aik@amd.com>
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org,
        Ingo Molnar <mingo@redhat.com>,
        Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH kernel v2] x86/compressed/64: reduce #VC nesting for
 intercepted CPUID for SEV-SNP guest
Message-ID: <20231001095322.GAZRlBkle6JC2rfM6u@fat_crate.local>
References: <20230926040526.957240-1-aik@amd.com>
 <20230930071759.GAZRfLpz38AAITSZzW@fat_crate.local>
 <e009f70e-32fc-404a-8560-f059b8999895@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <e009f70e-32fc-404a-8560-f059b8999895@amd.com>
Precedence: bulk

On Sun, Oct 01, 2023 at 08:40:30PM +1100, Alexey Kardashevskiy wrote:
> Ingo says different, who wins? :)

I do: a function gives you type checking - a macro doesn't.

> > Then, it should be defined only in sev-shared.c for now.
> 
> sev-shared.c makes me sad. Including .c is not ... nice,

There's a point in doing things this way.

> I would avoid adding stuff to it at any cost.

Care to give a technical argument why or is it just general sadness?
Because I don't care about non-technical sentiments.

> > Furthermore, it should not be called "rdmsr" or so but something like
> > 
> > ghcb_prot_read_msr()
> > 
> > or so to denote that it is using the GHCB protocol to read the MSR. I'm
> > sure it'll gain more users with time.
> 
> What is "prot" going to signify?

"... or so to denote that it is using the GHCB protocol..."
					       ^^^^^^^^

it is right there.

> And what about Tom's "x86/sev: Fix SNP CPUID requests to the hypervisor",
> are you taking that one or I have to repost this one and the Tom's patch?

Yes, use this branch:

https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/log/?h=tip-x86-urgent

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette