Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Sun, 1 Oct 2023 13:35:56 +0300
From:   Ido Schimmel <idosch@nvidia.com>
To:     Kees Cook <keescook@chromium.org>
Cc:     Petr Machata <petrm@nvidia.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH 5/5] mlxsw: spectrum_span: Annotate struct mlxsw_sp_span
 with __counted_by
Message-ID: <ZRlLjD1hEYRWZunt@shredder>
References: <20230929180611.work.870-kees@kernel.org>
 <20230929180746.3005922-5-keescook@chromium.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230929180746.3005922-5-keescook@chromium.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JXjhssXrRXgMjM7PnHFyy2SOPxIw+NP1uJI1aiSnrxojy3AOCXuIaObtaVIx?=
 =?us-ascii?Q?mN/dO8Mn072LaqX56/CiN/JiJaDuyykSwQWyyvszBO6WzVLvWGXcz6F3jO3c?=
 =?us-ascii?Q?zRAI/4jzX4Wp52lyuVBUwWp7Shz+MjdwTuOEMWjhQL3/86Gq6g3pHFDRWTp6?=
 =?us-ascii?Q?vaDeYufOkK5QrcmUM+oeiOQsTLx6hSzli3rQodWKxC64tzpDV46Gp15vjcr0?=
 =?us-ascii?Q?Rg66PhaA9e3APsgeCebVM5Pbm51CKLLuYY7+TT5c2b9NjTpQpjxlCxd6Duho?=
 =?us-ascii?Q?1FrMq2za2hiXtY87j2NQK4iaqOvZQRqh0pnWvQ7MV1dCWnWjRHup/Ful/y7d?=
 =?us-ascii?Q?UlRbItu4hSYUimxdlgDyB5UBpPwsnC6LkEyfYURNWIT2P+Meo5XsNx44soo7?=
 =?us-ascii?Q?Y81WzJo3nTN9BFZfQ8oucfMbqmC7gnBtvelchmBcmy+DcUHJTBekFAw7QwSt?=
 =?us-ascii?Q?X624ut2KC6G5wqZzASPRxplfmpTsQmgUH/gD84Mc/O45CjyIdcahezsM8MVv?=
 =?us-ascii?Q?IraON5aeq/lmgDAdtzZsl/ykhQt7aia3ZGkWfX2f9EYhpPuJRt/SGIJ8N6T/?=
 =?us-ascii?Q?uYsqgX61MneZpKxMOwdY/0Dkex3tSPTxAM2T/lKrXNlQ7LvXFRJiXWlCk7b8?=
 =?us-ascii?Q?FzXgIvMjxADo7hn1tZWg2XdKPiZJ4Vd33W+Mh7prCFul7GTSr+6c6oQAZsu1?=
 =?us-ascii?Q?4OW92KxeOQM7Kjo+zqoG9/JsBo2cN13LIKysD0VxXpXFOz0XjLwafGuYKrTn?=
 =?us-ascii?Q?e+usVTJdw2of0Er2g78Hht0nWt0sUbAq8VgJr6i3CLEdb2OK9yRpxorVj4my?=
 =?us-ascii?Q?AVtSeRrH+NBM7RuS/53PGI/ka6CwmB6MDezOj8uJJy7c3WB+KO0f0v9N8tmS?=
 =?us-ascii?Q?F3bZgXAHhukZvZS4mkD9B4gHbqeUrL+70FWuOoyWXKMgQUzw9CTSfZVggUv0?=
 =?us-ascii?Q?lJ+SP6rAgqqy/0wDLqfuRPG3+K6GCraEjDrT+mIDJNgjWBYnPVKqctjLzIny?=
 =?us-ascii?Q?uZC8R5Z4/2fgpADdwNc8uqQdqJUQL9yUAzK67UAU5vy2SF5LF6nEi5zswuB6?=
 =?us-ascii?Q?DTpTeSF39q0hMRYM1NrSpCdx7pZhGgzVepvlcYuerP5/UVbZXb35MORstnfh?=
 =?us-ascii?Q?9mH0zZx74EMxizWrrjv50lEOuDE0dXxdIPTxJ/h2qxSxhIZBavr7AMRqwEhd?=
 =?us-ascii?Q?pVWzw3jfB4KMaHEewXmRFLfo6NNiAxv52/asGOMa56LhEIj8AgD1Ayviqpb9?=
 =?us-ascii?Q?O29oe9BiOOVlumyZrlYWpqKeI6ZRTn7cPPVfdl1OZ5XlJAq8a1DXtn2/Q+ys?=
 =?us-ascii?Q?O7HKoBCPer36wni1Kkdiu6wlagIumzbnFWUQzwbT36Jyuc8LLPk6EljM5jLr?=
 =?us-ascii?Q?uiZDHRzM+j20JxV2VZNIg0tSIZeL2Omvofs+SeU/N7SeataOTUdnd0kxIGGN?=
 =?us-ascii?Q?nbNTsbYNe152Fhk2cVhUUbccWk+Rh1W/9/8h+brNAK9iLH+52MMdtX6uUYLW?=
 =?us-ascii?Q?ZIe5avjOprhu07j+cSBgbRCQ9q6TrRoRNwd/ZVn3JrgCKT19bFN4kyLqaABg?=
 =?us-ascii?Q?Gh4nZsuB8VxYgBeTw8FLBeHN4jR50Kl02DpKsJZt?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d195d662-3988-4e08-3445-08dbc26a35b9
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6179.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2023 10:36:02.7617
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2SxmjCsV5idDYZ82eNUK3P9Gi0E5ZxlVFS98YQfegrJR/Q/vmP/kdsyGgtYA0k+gN9ApiYb3fesLGf68s2ZHXw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7836
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sun, 01 Oct 2023 03:36:23 -0700 (PDT)

On Fri, Sep 29, 2023 at 11:07:44AM -0700, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
> 
> As found with Coccinelle[1], add __counted_by for struct mlxsw_sp_span.
> 
> [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
> 
> Cc: Ido Schimmel <idosch@nvidia.com>
> Cc: Petr Machata <petrm@nvidia.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Kees Cook <keescook@chromium.org>

Reviewed-by: Ido Schimmel <idosch@nvidia.com>

Thanks for taking care of that