Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Sun, 1 Oct 2023 13:32:37 +0300
From:   Ido Schimmel <idosch@nvidia.com>
To:     Kees Cook <keescook@chromium.org>
Cc:     Petr Machata <petrm@nvidia.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH 1/5] mlxsw: Annotate struct mlxsw_linecards with
 __counted_by
Message-ID: <ZRlKxeF2T6AOnWm2@shredder>
References: <20230929180611.work.870-kees@kernel.org>
 <20230929180746.3005922-1-keescook@chromium.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230929180746.3005922-1-keescook@chromium.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?h7n6zT0yQspueOVE4cyC5sDXvIVM1sv1FyJ7n3dX7J/VaB/N2ksPIgI9czBg?=
 =?us-ascii?Q?4/8E2nAtaF6NNfq2R1EHPFi/R/+VoaHeH7ikFok8fnABm8BU1jGGBGDy4ljN?=
 =?us-ascii?Q?OHB1XFQIGh1qDIzA2nM/qeJIT8uyDfbdzo46DtYjFCn8fXZNf4pXlEahzB/n?=
 =?us-ascii?Q?hjPlk0A2vrkJafyz9Vr4zYGn3wUBgv4hg4nQN5yOcfYHmODtZoBDGuEJEdZY?=
 =?us-ascii?Q?vQO4+PJrMKinca/ODQIXB7ItsyP7xiGAPRj2ZgrDl3ak7Pxo+1VJzHxmRN8e?=
 =?us-ascii?Q?C50AqBOxOAzVbTVcvzA6wXajgvncUTn9v93levX12PjJao++WCaubfLcQlPE?=
 =?us-ascii?Q?d4RcUxvCyDWplF0Z/C1LSb3yhDlToykErkR9DfKMc/mE1xvBELBFPrkC/4JH?=
 =?us-ascii?Q?7o9BgUkt1OU0w4/pP1DR2FFbvPA12oYAmvZU0voU98WqhA+Y6FyfiJjfpBgJ?=
 =?us-ascii?Q?k5algsyBD2znbDydZCjESdAet7vYIAN0HAFqF5KL17yCxt7rHZn37mIqyfxK?=
 =?us-ascii?Q?XkkdPC1AIdUgdHxNZDTNJcvtapEsH+7/ScqJZ9okwLGPnIApKTK3mVuXqBNF?=
 =?us-ascii?Q?TRk1X5kJ0jyKv3jw5yeTLSaNE0W84Bvx+8Al5nzIiYOvl5apkuUwKYdbrTDR?=
 =?us-ascii?Q?047gCPB7b9ZC4yhfZZMVRff+wToTnCkHWDaEc3jlOlqt3XHP+LMloauej6jN?=
 =?us-ascii?Q?T+LHh78nA5HB9UkWJRKVrFAsQjmHbv38+NQ+mrN8+pXYM6/AozmReCatXLuy?=
 =?us-ascii?Q?W0RiuBJTiYERSHsSH/CgXagg3ItbT25MMyJ8DiCQwNCwIzGWOcGqXXw0BapP?=
 =?us-ascii?Q?UrGp6Hzca2MSM9wkGBA5eWzlRIPMdvPHSuxxr9OJKVozp653LgBSlGkmpn2L?=
 =?us-ascii?Q?PttKyfCm+t6PNUY9UGgY45otHV/gEQZC4JuHYJpao6Aj5TYtf6EG5GNgjubI?=
 =?us-ascii?Q?QMxX6aD4vIKfwA+DQziv7CP7VDNdYrVirHP2tCNU1/JzbSJTd5bCW9vKQ+Iv?=
 =?us-ascii?Q?L2MEy3nAoZfRIH/xqskLf/acagt/nIMDr357VKzrfMJw8qelChCFw4cKLW+u?=
 =?us-ascii?Q?CoFV2uXmaNWk6a3xoqCkDFi+2t10TMIKQNQ/ij3Lsa+NQQahnGBnYknfSFuO?=
 =?us-ascii?Q?88RL2BKDF3GmD37cAQGgN2Mc5SaqdWA68e+xueMfzv8iEBIPClt5VA5nNstr?=
 =?us-ascii?Q?mv8kKSEI+XgE8X+qDJBFUSm1A2x0FwrTu7hxogIZUSlR6TGSvO5H4zcWrJgS?=
 =?us-ascii?Q?3wDAiPxOwlypZ2S5p9l6U81pd5m7OqXPIfj+m7GYEq2q1krdW12U7AhjDpUr?=
 =?us-ascii?Q?0+j1aVclo4CF1cGu+SZLXjOqJqvDBwm4ujmgTLoyxsuahRjoaDuYbAxNjiz5?=
 =?us-ascii?Q?0VpVmaJjrIFuLzS5BEhoJacJGWZpIaTqIZM97YoZQto4sOHHXwxzrux3uiyJ?=
 =?us-ascii?Q?WCdOuT6aSP2Qy0oh7lLjPyovVJPniZHKcd503/eJ+HPHmhxaIZKASTO08NPs?=
 =?us-ascii?Q?ERY11U99Ba928XE1hO6Tc7GVH7HQfVqiDGFw7la1NpA+FMhIPON1woFx5uuo?=
 =?us-ascii?Q?Hjht+7DMkdTbcCc6J79DyErCND30AaVHJ0TAznUH?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 08842954-c57c-4d01-a5b8-08dbc269bee1
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6179.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2023 10:32:43.6438
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lI16VG70bbCJTCOucYMza4wzCRJ+SxR9QBoGiyJggaEfMGDcA6lLCV3MAb2o2h4Jce1xcvzEB08SeZHaboG7FA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6266
X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Sun, 01 Oct 2023 03:32:56 -0700 (PDT)

On Fri, Sep 29, 2023 at 11:07:40AM -0700, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
> 
> As found with Coccinelle[1], add __counted_by for struct mlxsw_linecards.
> 
> [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
> 
> Cc: Ido Schimmel <idosch@nvidia.com>
> Cc: Petr Machata <petrm@nvidia.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Kees Cook <keescook@chromium.org>

Reviewed-by: Ido Schimmel <idosch@nvidia.com>