Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Sun, 1 Oct 2023 13:33:53 +0300
From:   Ido Schimmel <idosch@nvidia.com>
To:     Kees Cook <keescook@chromium.org>
Cc:     Petr Machata <petrm@nvidia.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH 3/5] mlxsw: spectrum: Annotate struct
 mlxsw_sp_counter_pool with __counted_by
Message-ID: <ZRlLEX8DvxFUdR6y@shredder>
References: <20230929180611.work.870-kees@kernel.org>
 <20230929180746.3005922-3-keescook@chromium.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230929180746.3005922-3-keescook@chromium.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dKrlMPhlxn3YxMnsur1c9IMYbKYGpPTt7HWKNr4AeLqxcmYGd4Slbj3qaoJi?=
 =?us-ascii?Q?Ism/4IAupqj5SHS1/pPeXxzfwx5+9Fa8trDwIMJNhS1QAN86RbiUhfAoSz8e?=
 =?us-ascii?Q?BQaNy5XBZgNhMePGZkvRGiWGY6gTz8FM5p6fi/S1ndwU2uTuKy32ovxNMXUX?=
 =?us-ascii?Q?l6fdEySvrKXCQHVnrROXBlO3pXOgEF0py4Pm0ShUcnNh3wUt2pcvzAwKxl0F?=
 =?us-ascii?Q?r1G3nmWAcs/JztuiecgIbmpXETh5CEFYkMPpQSRYgFBeGVZMXdce710REhqz?=
 =?us-ascii?Q?aSKASF48kq4zF7Ojv8Fpp0BTWjIQ/f/MPqtzR9EUrcXIHA2bNh/+UH4cWrv2?=
 =?us-ascii?Q?rcXBy5Ptmh+ydI6IQkq6Wk/jsSEUz1XZoUEecW3QZnL3XMAQrf5wi7PtI9FC?=
 =?us-ascii?Q?j5qsUEQvGERsbsgj5yysqP4atn0nmvhB6iIaaPVbbtclh1uIZL/CZE9JxCI0?=
 =?us-ascii?Q?swOwFQP77SnKmwS80AqG1dU/7tih4jdHx+5EJt8ws3GlQvZvTIW7650UnJPx?=
 =?us-ascii?Q?8qFl73QAs3p7VxPsq4XGaJfZInbxQbv6U86ANNu9hPq2pUvHFZ8UxlWK6WD8?=
 =?us-ascii?Q?G+bXBAuLqxTXpi038lfr2p3j9a6H0MeaHx1A9sBVEWoQ0QkrJHJO1M8lMvAs?=
 =?us-ascii?Q?6+kFDRS2LjBl6GvSUVPj7u5MFruOixIZ58qkAmCbIBeHtW9umkgt1l4QPGuJ?=
 =?us-ascii?Q?/aYM1QzjFwXCu+XqsdjpcZ8i5OIRo5Tz8I7nY8TqgneLR64OmfnfY07z5XrA?=
 =?us-ascii?Q?4uNt34KZsIOdFDJzbK8DK0wdwPj+qVigCoZpNmiOaGw3MU2I0NEbINkCh/P8?=
 =?us-ascii?Q?YQCmYMOtVcSTzhcyGSmjZF9kPV/G/Vy240z5MThkG+CrWlkibPaqMzh25tHv?=
 =?us-ascii?Q?/+Oc+RUOEaAQqZeTaAbAlbpmOyAnS+vyqPav7epbV/rswPS05AQ1nTTsa153?=
 =?us-ascii?Q?7aIZ1ZZw9PwZV/ZNc9dwxftiW/mtrRnJHuJFNtRM9ZhigMFQvrqJ4rdgbDl4?=
 =?us-ascii?Q?xXdaOOOezmfgELdRlamJOmN7+DRfSQ+OZN77rYlQiN8EwnEhVifOj7Jb3lfL?=
 =?us-ascii?Q?HK1lBP6cza20P+IkP21ShqHoy+F8KAh5plFfQVsXNtds3k9ndL6/QqcUC8ng?=
 =?us-ascii?Q?T3EsWJnEunRcHjV2GtSdIFAKkZT7N8SDgD5dhbBcA0o4aJ5Ls9pS1rmfdDDz?=
 =?us-ascii?Q?895V33f+yyhpUkSYr/xjOVQ/a2cZ6AFiP122Zn0b7yCINSCQCeDHd7jaVGUm?=
 =?us-ascii?Q?+9uUEbhd/3mI/Lj+GVqyWsHEQvse4Y5oipg/ksIWrXhXGUwN2k3ZNeu1aGIq?=
 =?us-ascii?Q?3wEzIploVAx5Lw1eUjj12jc7kHBmF9xhyRAl9l0dkSx5WK+Ez+5ke6h58Nca?=
 =?us-ascii?Q?IR/asUkXwwLCvQ8dcUpP7cnZISCiBwaViccZ5fYMkijpaPlZgyHLm+lAVReE?=
 =?us-ascii?Q?6qwjlNuuoVZU5JBd5swjxP/bAc2U3korQ4YtA/HB5Z2/zAniJsyxho1koZAz?=
 =?us-ascii?Q?Q3nA4uPWZyQWElJKJrXS+kvL97hQxKcalK7W8qsmfcOH2dgwU736HOUkUEwm?=
 =?us-ascii?Q?Xb8Juv7BC5Xu4PKLXBJqP5prV9bgZpcDnDuuVaa7?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6246c01d-7a8d-465b-b188-08dbc269ebd8
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6179.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2023 10:33:58.9432
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hqP1icaOC9hEleUnsZ0jLxZW/q6eOvKzEO8513+OvXp2oDVashKb22OGyy+wsI93qB9lb7ivHo3/J1VsNjUZFA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6266
X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sun, 01 Oct 2023 03:34:04 -0700 (PDT)

On Fri, Sep 29, 2023 at 11:07:42AM -0700, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
> 
> As found with Coccinelle[1], add __counted_by for struct mlxsw_sp_counter_pool.
> 
> [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
> 
> Cc: Ido Schimmel <idosch@nvidia.com>
> Cc: Petr Machata <petrm@nvidia.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Kees Cook <keescook@chromium.org>

Reviewed-by: Ido Schimmel <idosch@nvidia.com>