Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp953963rdb; Sun, 1 Oct 2023 12:41:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEBcRp5addyb2Sn9nW0N2ZYb1LSJ/KMuR+NTBVoa4dQ8LNiNxJHeLqnyZBMSWlWsTjvjaYD X-Received: by 2002:a05:6a20:9382:b0:134:73f6:5832 with SMTP id x2-20020a056a20938200b0013473f65832mr15446409pzh.16.1696189294245; Sun, 01 Oct 2023 12:41:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696189294; cv=none; d=google.com; s=arc-20160816; b=TwakFoLP2CFR+Ts4B3jnUjva1lfVdio0EIz9504PNn9y2xyb+q+8/J4sCyJ5sVlcFE 8gxocCWRX+zrxFof1kZ0E7US6j0H5PUXUuKsAqIuI5j6yFhJYzjplPkJI8AbNO4kVLWh tyDimwfV+Nrl5ghT/6zkqDoZYj+cAVDq4TxurdNQBjFKbLCwbi7tlwrk9SJdlHFuJusm PPKv9EkdPsZ9fnGqpVEgxDMHvB64Cgdj0+eMMSO+ocmRQIxEFn8OCI4lsBdzzat1r/57 Ag7rG3NirASlKM/lv0WbUE499KAdk6Zmmzzt0aCMkNlPmOLHQOXCg9IaeIwz3mdLVJdN DJkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=F4mpp0HTqoMB98qe9eiYEXks5rNRdwSriBgWOGd0HtU=; fh=Sw1rtAM+hKyOoOQVYiiLzcdjc4spg79Z/tN6UmWUAKs=; b=X+Yhl945nyenDWqkIrEDPkxYPdv+3lGisf3gHhj/9YmU/Ydj327Alug5m9qtHK9spA EkyUcqm3rvb6dZgUQnWw5rWJXVqIkswtDu9cFlf/EXhzqYGCmMFJUy3zhiC59tCXm7ok p0tvSRAUpfvTu5JKhKta01gDunk2b6N/AhE2oOAVeeZwd+Ej224zZlh0gepqaeAJuwep Sd+PSGF4GERo8SWrSfcr54HHZgpCpgDsXw4WtRhAgtST9uHa+d2lyhE8clXveT4OnSkk sx5a941HLpVu6MQxm7ZVjDtT7g39GJBFiwL+udrEQP+7aT5JuX2o2oLDZxL2nbwdAjWH IiqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=HsxThKK5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id bd34-20020a056a0027a200b0068a685bf30fsi24938282pfb.271.2023.10.01.12.41.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Oct 2023 12:41:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=HsxThKK5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 6696C8135CDD; Sun, 1 Oct 2023 06:46:10 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235065AbjJANpi (ORCPT + 99 others); Sun, 1 Oct 2023 09:45:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235068AbjJANpg (ORCPT ); Sun, 1 Oct 2023 09:45:36 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDA78107 for ; Sun, 1 Oct 2023 06:45:30 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-9ae3d7eb7e0so470716366b.0 for ; Sun, 01 Oct 2023 06:45:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696167929; x=1696772729; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=F4mpp0HTqoMB98qe9eiYEXks5rNRdwSriBgWOGd0HtU=; b=HsxThKK5cuHz7Wwoe9bFRX6PmzcY0yvEXPv0GMqyoPCLMfv5o8VZO2W9/pzJUA4byo jQuD2AyCRhu6Uh6vq0VXubsi4nswpAvnRz0lj3E57I3PB4ITLrJsTjyUjJRwg+xkfdgt Zz0/+CWJAP/tMjdRbUvExn9Bovcn6G3mZKKvKxQtoe3e8zCWOev1yHVVU+2uiq/XsAfV 3uAcQclzXKUAc2y/9a73oBshEDDHT5y4bD1zXbRhSRr3a20Fakd8nCT5r24cjjXJqAG2 yzl9pyoMWgFGjYcfKiOHcSfMyLQutMrgvI8tQ5JaHEI5Q8W1Pz1u+TiMJqnJHyIo+pIG iR4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696167929; x=1696772729; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=F4mpp0HTqoMB98qe9eiYEXks5rNRdwSriBgWOGd0HtU=; b=kyoUajQp7oL2+B4yrEWOzQNOxp8AkqAAvNMdzaSpEagWnCHDNQoTFNQThUDe77JjGx JuzkPMUGPjn8wWQqxcUzzzh8WSdCWrl1iZzdxPHY9yTGNB0VHd2fvJcTG7eGT+pEbDHO 4KK8/LDtEzjFCHXAPXniICzCyyxBXiRWV5NJRBMgLJVgoGgzMllDzXTf2lbQGZ7yjWP1 W1mJUsS9FCssw44M6r/X+VeE5O1Rg5czOKTyzSDU5S2YSnVIkjxN6uGaGQZlXbrwrAKs 9DXFH03uQf1vmo2wlLiyZj+shnvIO6/sYisrAsK6eI2GeMh4n4ir8SslWTYDjHgK5NFO 2X+A== X-Gm-Message-State: AOJu0YyX4EqkDnrujizdGMjAYIM6BlNgPwL8lvydI81Ltto3m097gSjE qYPg7W87rmYqM30eHiSyrww= X-Received: by 2002:a17:906:2ce:b0:9ae:3f76:1091 with SMTP id 14-20020a17090602ce00b009ae3f761091mr6844214ejk.0.1696167928880; Sun, 01 Oct 2023 06:45:28 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p579356c7.dip0.t-ipconnect.de. [87.147.86.199]) by smtp.gmail.com with ESMTPSA id bn23-20020a170906c0d700b0099cd1c0cb21sm15429750ejb.129.2023.10.01.06.45.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Oct 2023 06:45:28 -0700 (PDT) Date: Sun, 1 Oct 2023 15:45:27 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 11/11] staging: rtl8192e: Remove r8192_private_handler _rtl92e_wx_force_reset() Message-ID: <8447643122088ff03dab65ac15e5e5199603008d.1696165351.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sun, 01 Oct 2023 06:46:10 -0700 (PDT) Remove r8192_private_handler _rtl92e_wx_force_reset() as driver does not reset. Remove dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 3 --- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 1 - drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 18 +----------------- 3 files changed, 1 insertion(+), 21 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index 2b91c481df93..c4688c273f4b 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -754,7 +754,6 @@ static void _rtl92e_init_priv_variable(struct net_device *dev) priv->rfa_txpowertrackingindex = 0; priv->rfc_txpowertrackingindex = 0; priv->cck_pwr_enl = 6; - priv->force_reset = false; memset(priv->rtllib->swcamtable, 0, sizeof(struct sw_cam_table) * 32); priv->rx_ctr = 0; priv->rtllib->wx_set_enc = 0; @@ -1130,8 +1129,6 @@ static void _rtl92e_watchdog_wq_cb(void *data) check_reset_cnt = 3; } spin_unlock_irqrestore(&priv->tx_lock, flags); - - priv->force_reset = false; } static void _rtl92e_watchdog_timer_cb(struct timer_list *t) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h index 0ebebb3c2c35..deb707dfa443 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -371,7 +371,6 @@ struct r8192_priv { u16 tx_counter; u16 rx_ctr; - bool force_reset; bool force_lps; }; diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c index 17e7fcc01f70..ec09066f2f32 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c @@ -141,19 +141,6 @@ static int _rtl92e_wx_set_rawtx(struct net_device *dev, return ret; } -static int _rtl92e_wx_force_reset(struct net_device *dev, - struct iw_request_info *info, - union iwreq_data *wrqu, char *extra) -{ - struct r8192_priv *priv = rtllib_priv(dev); - - mutex_lock(&priv->wx_mutex); - - priv->force_reset = *extra; - mutex_unlock(&priv->wx_mutex); - return 0; -} - static int _rtl92e_wx_adapter_power_status(struct net_device *dev, struct iw_request_info *info, union iwreq_data *wrqu, char *extra) @@ -1060,9 +1047,6 @@ static const struct iw_priv_args r8192_private_args[] = { }, { SIOCIWFIRSTPRIV + 0x2, IW_PRIV_TYPE_INT | IW_PRIV_SIZE_FIXED | 1, 0, "rawtx" - }, { - SIOCIWFIRSTPRIV + 0x3, - IW_PRIV_TYPE_INT | IW_PRIV_SIZE_FIXED | 1, 0, "forcereset" }, { SIOCIWFIRSTPRIV + 0x6, IW_PRIV_TYPE_INT | IW_PRIV_SIZE_FIXED | 1, IW_PRIV_TYPE_NONE, @@ -1089,7 +1073,7 @@ static iw_handler r8192_private_handler[] = { (iw_handler)_rtl92e_wx_set_debug, /*SIOCIWSECONDPRIV*/ (iw_handler)_rtl92e_wx_set_scan_type, (iw_handler)_rtl92e_wx_set_rawtx, - (iw_handler)_rtl92e_wx_force_reset, + (iw_handler)NULL, (iw_handler)NULL, (iw_handler)NULL, (iw_handler)_rtl92e_wx_adapter_power_status, -- 2.42.0