Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
From:   Neal Liu <neal_liu@aspeedtech.com>
To:     Corentin Labbe <clabbe@baylibre.com>,
        "andrew@aj.id.au" <andrew@aj.id.au>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        "joel@jms.id.au" <joel@jms.id.au>,
        "john.allen@amd.com" <john.allen@amd.com>,
        "thomas.lendacky@amd.com" <thomas.lendacky@amd.com>
CC:     "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] crypto: Move akcipher_request_cast helper to crypto
 header
Thread-Topic: [PATCH] crypto: Move akcipher_request_cast helper to crypto
 header
Thread-Index: AQHZ9KPWRcGTiWTCyUK/D0jNMoSECrA11bZg
Date:   Mon, 2 Oct 2023 03:21:56 +0000
Message-ID: <TYZPR06MB6770E43899C7AB66FF55FAC280C5A@TYZPR06MB6770.apcprd06.prod.outlook.com>
References: <20231001201357.2052949-1-clabbe@baylibre.com>
In-Reply-To: <20231001201357.2052949-1-clabbe@baylibre.com>
Accept-Language: en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XrPOdXYJM0o6v+mhhSYPJI4lKEfG3t4wODB4Mc7oWg79kXQw4NzbrtDbFMk2?=
 =?us-ascii?Q?Fp/sJ88Rxuq6CA+PDzovUQMw9gJOnRWciRlIukeTjYbiw8umucia3G/2xiJD?=
 =?us-ascii?Q?3vo3RyfGFz6avL/E84YTZlfhERq0/AlSm1kF+VOoUCfPdxC8oy/wyL4DEIQW?=
 =?us-ascii?Q?cqkMqEbVIgcjKIfNvqDcX0PCxONcnWcKxSsyBHB2RAIqSZMvkH3LqDxgTx2q?=
 =?us-ascii?Q?m1NwBawNrIkLxPxSSkaYU0kKIb7OObkjfGfvPCrn8xXbbcfS+hM5pUd5S6TO?=
 =?us-ascii?Q?NfNVF5EXeM8YYEQvptar1S92rYV/RqAaS/5ePSSADxfeyiHkRzfUJJ4TAAGI?=
 =?us-ascii?Q?k385GtNPStowNWcGU8jyEqrkI3CAovG2zSJeBoUTLVLuSH1m5Ubiqlp9YgED?=
 =?us-ascii?Q?TZGbaga/y8OweQfW0Y6cdzqBFHwtjST2IQnaxIJPRAfZjy15sZ7+dhB1s06r?=
 =?us-ascii?Q?cpIKzevecNaMTiL0EpquQLuVFwxtb5g+CeDEXIuejJho8ZDZkF69YEHQGKFi?=
 =?us-ascii?Q?rMdtkdvEbGwzfFJJvUOGMT5bWnwpeUqjkLc63Qeodh+o9pyfF2qLFRS1UHx8?=
 =?us-ascii?Q?S2zr9afKRCTgbFScrOuxGXDxk/Dpw/az9CI2rCxqVSH0pxZLnwzLT49+jlRh?=
 =?us-ascii?Q?4rcco2428eG/L2JMxFTwNzpkukHPR5IgrA+pI3aB5e2V+JPJp78CEbyOxfDf?=
 =?us-ascii?Q?dkBIUbrLdLeX0QS8JyOBGbENvK02JNgZ0kFn2XA/0vDLMkbrbPPh1L5yQDl7?=
 =?us-ascii?Q?SKv2sZ2gEqZF9H25JY84bNFELHgPu+1EohfbUMb25ejjKok4fdVLq5OJmSv9?=
 =?us-ascii?Q?I0P+TAtyHGjNKJiH0fwQTevrGTycNY6rBoqj7E/yKI13r9FFE0IRy8nqFoYT?=
 =?us-ascii?Q?YZNJB2c4zDVn3a5xhDRP7wqhh+pYKQf6uabBhBWQj5RkCeI0wQF9Kuvp7uvY?=
 =?us-ascii?Q?PGpOVwX//Z8HuoOUA2gz/Fs6iGvIFKr04C7xo41PCEnk3pyfl5pNa9RIlbsq?=
 =?us-ascii?Q?4rW0UNWK2pRBGcBjQV3KpYlq9bVMUwtFmEih1ozFCCAUIme1ysK4/S6LmOhU?=
 =?us-ascii?Q?VixxF+CzR5pFPDRT+D9wejZGJKpZyg+E1k/wkG+juKop4bE44r1rmMD52rf1?=
 =?us-ascii?Q?nqwGvs85xrBZV22Lsuur/F46//dOt4bfPz0P8xsZ/GtUOPXOjWRyvcTPSfSS?=
 =?us-ascii?Q?r5skRQ6zLq5YAuSQL0kMZD/Xw3qNFKZY46nSveoRqf+o7F/3WSNyOWkk+Kbc?=
 =?us-ascii?Q?dBW1X7YSYGWyCW6z/0655NI0NsAlSKlAEaiI0cUow/I1L0yVrOZ13RUku6HH?=
 =?us-ascii?Q?a3By51A1dMZswNR+Onum4pN4RXiUzidNqyte9BwjytN9QvX8M58MgzlY26Lo?=
 =?us-ascii?Q?74/cft6JKDIIWT12iv3iFTo26W5sgMjRa1qrX+8HeXvNI2kkWup1IoblvyUq?=
 =?us-ascii?Q?Hqpzhtb5AvTKX/4Q6W9Gi5PvzV0mZ9WzcJwiEIlmtLzGKum3gdrt8SwN5uD9?=
 =?us-ascii?Q?dF62cwXmzVno/xjB2nff9HIk+EBcDk9v12Is7u9sX1iCUllOMAu2fcx4bUqN?=
 =?us-ascii?Q?EydByR3DpVE65ajvfdwgbj0jmCc+kLz1Vnd9vZFZ?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB6770.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a80daac7-d270-4c76-fe64-08dbc2f6bb4f
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Oct 2023 03:21:56.3246
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 56r+V8lwcYhFyabpTPPXwlivq9/d5qLQo+bxIiZaYxZsq6bkAn8WrF+AdDwO2wsFlS8bLT2tBjps3QSfcq4NBQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6297
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sun, 01 Oct 2023 20:22:50 -0700 (PDT)

> -----Original Message-----
> From: Corentin Labbe <clabbe@baylibre.com>
> Sent: Monday, October 2, 2023 4:14 AM
> To: andrew@aj.id.au; davem@davemloft.net; herbert@gondor.apana.org.au;
> joel@jms.id.au; john.allen@amd.com; Neal Liu <neal_liu@aspeedtech.com>;
> thomas.lendacky@amd.com
> Cc: linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org;
> linux-crypto@vger.kernel.org; linux-kernel@vger.kernel.org; Corentin Labb=
e
> <clabbe@baylibre.com>
> Subject: [PATCH] crypto: Move akcipher_request_cast helper to crypto head=
er
>=20
> There is already 2 driver implementing their own akcipher_request_cast.
> In the future there will be also rockchip and allwinner driver that will =
need
> this.
> This is sufficient to move it in crypto headers.
>=20
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>

Reviewed-by: Neal Liu <neal_liu@aspeedtech.com>
Thanks.

> ---
>  drivers/crypto/aspeed/aspeed-acry.c | 6 ------
> drivers/crypto/ccp/ccp-crypto-rsa.c | 6 ------
>  include/crypto/akcipher.h           | 7 +++++++
>  3 files changed, 7 insertions(+), 12 deletions(-)
>=20
> diff --git a/drivers/crypto/aspeed/aspeed-acry.c
> b/drivers/crypto/aspeed/aspeed-acry.c
> index 247c568aa8df..ecb6e984367b 100644
> --- a/drivers/crypto/aspeed/aspeed-acry.c
> +++ b/drivers/crypto/aspeed/aspeed-acry.c
> @@ -137,12 +137,6 @@ enum aspeed_rsa_key_mode {
>  	ASPEED_RSA_DATA_MODE,
>  };
>=20
> -static inline struct akcipher_request *
> -	akcipher_request_cast(struct crypto_async_request *req)
> -{
> -	return container_of(req, struct akcipher_request, base);
> -}
> -
>  static int aspeed_acry_do_fallback(struct akcipher_request *req)  {
>  	struct crypto_akcipher *cipher =3D crypto_akcipher_reqtfm(req); diff --=
git
> a/drivers/crypto/ccp/ccp-crypto-rsa.c b/drivers/crypto/ccp/ccp-crypto-rsa=
.c
> index a14f85512cf4..32c9f524f3d5 100644
> --- a/drivers/crypto/ccp/ccp-crypto-rsa.c
> +++ b/drivers/crypto/ccp/ccp-crypto-rsa.c
> @@ -19,12 +19,6 @@
>=20
>  #include "ccp-crypto.h"
>=20
> -static inline struct akcipher_request *akcipher_request_cast(
> -	struct crypto_async_request *req)
> -{
> -	return container_of(req, struct akcipher_request, base);
> -}
> -
>  static inline int ccp_copy_and_save_keypart(u8 **kpbuf, unsigned int *kp=
len,
>  					    const u8 *buf, size_t sz)
>  {
> diff --git a/include/crypto/akcipher.h b/include/crypto/akcipher.h index
> 670508f1dca1..4b6e610db18d 100644
> --- a/include/crypto/akcipher.h
> +++ b/include/crypto/akcipher.h
> @@ -498,4 +498,11 @@ static inline int crypto_akcipher_set_priv_key(struc=
t
> crypto_akcipher *tfm,
>=20
>  	return alg->set_priv_key(tfm, key, keylen);  }
> +
> +static inline struct akcipher_request *
> +	akcipher_request_cast(struct crypto_async_request *req) {
> +	return container_of(req, struct akcipher_request, base); }
> +
>  #endif
> --
> 2.41.0